GitLab

This CL hides TabStrip IPH when bottom sheet shows and reshows IPH
right after bottom sheet hides. This CL is gated by Finch parameter
"enable_launch_bug_fix" under flag "enable-tab-grid-layout", with gate
function TabUiFeatureUtilities#isLaunchBugFixEnabled.

Bug: 1135926
Change-Id: I97c80177b3fabf82aab751c6bf95a1c9b1e27432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506618Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823416}

It is possible for the scrollable area that is targeted for a scrollbar
scroll to have a layout box, but the parent hosting iframe does not.
In these cases we should just return a null target since we should not
attempt to scroll something that will not be visible.

This is really hard to repro outside of using eventSender, since
getting code to run between the queuing of a GSB targeted at a
scrollable area and the GSB executing happens as the stack
unwinds, but fixing this will fix the clusterfuzz test case.


R=bokan@chromium.org

Bug: 1140886
Change-Id: I65675ac565bb5d860d2b1fd7209a58ff835d27bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511860
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823415}

Canvas can have an "image-rendering: pixelated" css property.
In those cases, nearest neighbor filter will be used instead of
bilinear.

Since we don't do nearest neighbor filter when scanning out buffers
via HW overlays, this CL simply rejects the HW overlay path in those
cases and always falls back to GPU compositing.


Test: SingleOverlayOnTopTest.RejectNearestNeighbor
Change-Id: I907998f5a23ed2888ff0b3c53b9d7a938164acdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510649Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823414}

Hook up SkiaRenderer to webview's secondary command buffer skia draw
context.

Introduce SkiaOutputDeviceSecondaryCB for this case. Still need to
refactor SkiaOutputSurfaceImplOnGpu. Eg SecondaryCB does not have access
to a SkSurface so anything that uses SkSurface needs to be abstracted by
SkiaOutputDevice. Also need to refactor draw context submit and swap
buffer calls since webview does not call submit itself, and instead gets
a callback after android calls submit.

Also add a way to get a SkSurfaceCharacterization from
SkiaOutputSurfaceDependency, since the SkDDL has to use the exact
characterization from the GrVkSecondaryCBDrawContext.

Add a check if there is a readback from the root surface. WebView
currently does not use this for any production features so should be ok
for now.

Bug: 1141683
Change-Id: I3a0ad5b0f3a99070ffe773f35ea69d0ba5eca036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513784Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823413}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9396c2b0646a..655afebfcd13

2020-11-02 brucedawson@chromium.org Support autoninja -o/--offline to disable goma

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: Ib0d6b4f15a2386de4554b8c95c1a48eafdcd346c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515082Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823412}

The seek operation is required for non-fragmented mp4 recording. This CL
adds the seek support for the underlying file writers, except the
Android intent writer.

Bug: 1140852
Test: Pass camera.CCAUIRecordVideo and camera.CCAUIIntent
Change-Id: I1e111f9776b1c44905a5de203dbe8c95570ce490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513961Reviewed-by: Inker Kuo <inker@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823411}

The Network Service previously used concrete net::CertVerifier
implementations, but is now switching to use the CertVerifierService.
When creating a NetworkContext, a remote to a CertVerifierService
needs to be included in the NetworkContextParams.

Some unit tests don't do this, which is fixed in this CL in preparation
for enabling the CertVerifierService by default.

Since there's no need to test cert verification in most of these
unit tests, just add a pipe to a fake CertVerifierService that
always passes cert verification.

Bug: 1015134, 1111472
Change-Id: I378ff0930148bcc229b774c1bec1f7020ce97082
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509429Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823410}

========================================================================
Overall the tool has two subcommands:
========================================================================

usage: PINPOINT_TRACES [-h] {fetch,extract} ...

Tool to download and aggregate traces from a given Pinpoint job.

The tool is intended to be used in two steps:

Step 1: Fetch all traces from a Pinpoint job. Example:

> pinpoint_traces.py fetch \
    --job=https://pinpoint-dot-chromeperf.appspot.com/job/1709f5ff920000

Step 2: Extract all events with a matching name into a CSV file. Example:

> pinpoint_traces.py extract --event='.*Looper.dispatch.*' --output events.csv

NOTE: Currently only supported on Linux.

WARNING: Uses multiprocessing with heavy use of memory and CPU resources in each
         subprocess. This causes problems when handling SIGINT (when ^C is
         pressed), instead it is recommended to stop by ^Z and using the shell
         job control to kill or continue the job (like: kill %1).

positional arguments:
  {fetch,extract}
    fetch          Fetches job_results.csv and the traces mentioned in it
    extract        Extracts information about an event from all downloaded tracesinto a CSV file
========================================================================
The 'fetch' command takes a JOB:
========================================================================

usage: PINPOINT_TRACES fetch [-h] --job JOB

required named arguments:
  --job JOB   Pinpoint job ID or URL

========================================================================
The 'extract' command takes a regex and an output file name:
========================================================================

usage: PINPOINT_TRACES extract [-h] -e EVENT -o OUTPUT

required named arguments:
  -e EVENT, --event EVENT
                        Regex to match event names against
  -o OUTPUT, --output OUTPUT
                        CSV output file name

Bug: 1119406
Change-Id: Ief2a3d5ab97c54aa6e98c6095c6fcadbe88e4907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461323
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823409}

The API is supposed to return a boolean 'success' value, but we forgot to.

Bug: 1141347
Change-Id: I9f06828e5219209972d478becab515c5b7240062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505856
Auto-Submit: Darren Shen <shend@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Commit-Queue: Keith Lee <keithlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823408}

This reverts commit 365f1d94.

Reason for revert: Fails deterministically on Webkit Linux Leak bot, first failure here: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/20367

Original change's description:
> WPT to check click/auxclick/contextmenu are pointerevents
>
> Verify that the user agent returns click/auxclick/contextmenu as pointerevents.
>
> Bug: 989958
> Change-Id: I02757ef704b605471614829177cba24a73b6c8db
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513801
> Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823332}

TBR=mustaq@chromium.org,liviutinta@chromium.org

Change-Id: Idf6e9caf6291aa9a35ddabbb8e8f18c45f004522
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 989958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515504Reviewed-by: Meredith Lane <meredithl@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823407}

This reverts commit 1d6d5027.

Reason for revert: Suspected culprit of win-asan failure: https://ci.chromium.org/p/chromium/builders/ci/win-asan/15420

Original change's description:
> Hooking up buffer_size in EtwTraceController::StartRealtimeSession
>
> I am working on some ETW stuff for Chrome Remote Desktop and I
> noticed that this parameter is unused and a default value of 16KB
> is always used.  This isn't a big deal as the only caller appears
> to be its unit tests but it seemed like the value passed in
> should do something.  The other approach would be to remove the
> param but adjusting the buffer size seems like a reasonable thing
> to expose (assuming the param is actually used).
>
> Change-Id: I453ac2417d68f6c16fecd517cf1cd74c5aa15731
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511290
> Commit-Queue: Joe Downing <joedow@google.com>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823240}

TBR=brucedawson@chromium.org,joedow@chromium.org

Change-Id: Iab1337eaf4c762f50074d56d8d7eaa0210fb7d0c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515503Reviewed-by: Meredith Lane <meredithl@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823406}

We needed to manually reset the frame host AssociatedReceiver after
reporting a bad message, since AssociatedReceiver didn't have a
ReportBadMessage until recently.

Bug: None
Change-Id: I49b13134f4dc4202d684248db4d5aa01c8fe5ad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514466Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823405}

https://pdfium.googlesource.com/pdfium.git/+log/1443e5ac0acf..af6371f32764

2020-11-02 tsepez@chromium.org Consolidate some tests in new fxv8:: functions.
2020-11-02 nigi@chromium.org Fix issue that some characters from the embedded font don't render.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Ia6f22975aa393d189816ddfd9dc96df61b2d5bff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515083Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823404}

Due to an error introduced in r678566 the set of configuration
descriptors was overwritten after parsing each one so that the device
info only contained the last configuration descriptor provided by the
device.

This change fixes that by waiting for all configuration descriptors to
be parsed before moving the list into the device info structure.

Bug: 1144532
Change-Id: Ic540986eb9cbc5a01391e581ce7c21ad219a2f76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514589
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823403}

This reverts commit 68dcf80e.

Reason for revert: Breaks copy/paste: https://bugs.chromium.org/p/chromium/issues/detail?id=1144289

Original change's description:
> Lacros: Enable IME.
>
> Bug: 1133732, 1123705
> Test: Ran Lacros locally.
> Change-Id: Id74573390f287512a4455636e7b636255df4e025
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503528
> Reviewed-by: James Cook <jamescook@chromium.org>
> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#821320}

TBR=jamescook@chromium.org,hidehiko@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1133732
Bug: 1123705
Change-Id: I087969af40be61dc325325c91f0502fc18e191dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515204Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823402}

FileManager UITests fail when native HTML Imports are disabled. Serve
the test files from the embedded test server to make the HTML imports
polyfill on the UITest test.html page work.

The tests now pass when HTML imports are disabled. All console errors
about Polymer not working are gone.

The Visual Signals xf* files 404 off the embedded test server but the
UITests still PASS.

Test: browser_tests --gtest_filter="FileManagerUITest*"
Bug: 1111393
Change-Id: Iec0133c61b7296ced6bb01fb740e1667b9aa8d0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515379
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Noel Gordon <noel@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823401}

Reland "NoStatePrefetch: Rename chrome/browser/prerender/ to chrome/browesr/prefetch/no_state_prefetch/"

This is a reland of 8436de62

The previous CL was reverted because unluckily conflicting CL that
refers to a pre-moved header file was landed before the CL. This reland
CL fixes it.

Original change's description:
> NoStatePrefetch: Rename chrome/browser/prerender/ to chrome/browesr/prefetch/no_state_prefetch/
>
> This is mechanical rename other than changes in OWNERS and
> flag-metadata.json.
>
> Change-Id: I9020d87a81ccad25aaa1ac5881f8cfdb52cce25f
> Bug: 1144577
> Tbr: fgorski@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512486
> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Robert Ogden <robertogden@chromium.org>
> Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823349}

Bug: 1144577
Change-Id: I82417260cfcf0ecda944d31e1901d25e542f4a2f
Tbr: fgorski@chromium.org, robertogden@chromium.org, ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515420Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823400}

When we are using Chromedriver ExecutePerformActions to simulate
three mouse click, it should set the mouse click count to 3, but if we
keep clicking, the click count should keep increasing on Windows and
Mac, reset to 1 otherwise. It should keep the mouse click count and
decide if we should increase the count or set to 1 when we have a mouse
press based on the interval of two mouse presses and difference between
the current mouse positions and the last one. I added three more tests
to verify these cases.

Bug: 1119679
Change-Id: I6f628e625e680870a77e18495eb0b4fab024fbbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508987Reviewed-by: Shengfa Lin <shengfa@google.com>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823399}

Test cc had date of 10/2020, which means it expired.
Setting exp year to use test::NextYear() so test can proceed.

Bug: 1144598
Change-Id: I018787f8003f3d48a0d56715a613163ae7c3158d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515263Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Cr-Commit-Position: refs/heads/master@{#823398}

 - Remove |deps| field from js_modulizer() definition.
 - Spit js_modulizer() targets with deps to two separate targets, one
   js_modulizer() and one group() target.
 - Change js_library() targets to only depend on "modulize_local"
   targets.

Bug: None
Change-Id: Ifb0ed2344f3ecc9e6699f88fc0676d339b2d3424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514071
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823397}

This also prints the parent ClassLoaders, to see if there is differences
there too.

Bug: 1142589
Change-Id: Ib8933bba6ce6bc66883a2bc88bee208383e41dcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514591
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823396}

Bug: 1144907
Change-Id: I5c66ef7b869ada7603fbc7e15c20007c078bb0d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515044
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823395}

The size limit optimization only applies for fragemented MP4. Chrome
needs the whole file of a non-fragemented MP4 to be able to play it.

Bug: 1140852
Test: Record a video and check the thumbnail manually.
Change-Id: I3f4d6d7c317c21203761372265b7283bac4734f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513415
Auto-Submit: Shik Chen <shik@chromium.org>
Commit-Queue: Inker Kuo <inker@chromium.org>
Reviewed-by: Inker Kuo <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823394}

This reverts commit 440bbbe7.

Reason for revert: causing crashes seen in https://crbug.com/1144621

Original change's description:
> [Sampling profiler] Restore callee-save registers in V8 unwind
>
> Restore the callee-save registers now provided in the V8 API when
> unwinding. This is a necessary condition to support unwinds of
> functions that use dynamic stack allocation, which is failure mode
> 1 in the corresponding bug.
>
> Bug: 1122124
> Change-Id: Ifb30bbdd9df343251a7c215e5a5fc140754ac216
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500453
> Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#822204}

TBR=wittman@chromium.org,etiennep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1122124, 1144621
Change-Id: I0e998ab210537a513cfc9a67d5e632b2aa73d9ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515202Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823393}

AppServiceAppIconLoader could call LoadIcon multiple times, because the
icon image is updated for each scale. Waiting icon update once might
cause the AppServiceAppIconLoader is destroyed before the icon loading
process is finish, so it might cause below error:
[app_service.mojom.cc(1174)] Check failed: !connected.
AppService::LoadIconCallback was destroyed...

This CL modifies the expected icon update count to wait the icon loading
process finish to avoid AppServiceAppIconLoader to be destroyed early.

BUG=1124972

Change-Id: Id7efc80d14ac1a0f6e4cfbe77223256922898599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494215
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#823392}

Previous CLs got rid of this flag in code as it was expired, this CL
only removes said flag from the flag-metadata file that keeps track of
flags and their milestones.

Bug: None
Test: build.
Change-Id: I476bf49ad50b189d05c919883052202f80327b56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515180
Commit-Queue: David Jacobo <djacobo@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: David Jacobo <djacobo@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823391}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I68f4d928659f3366732c12dd45fc36200a714130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514374Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823390}

This CL extends the expiration of the
'turn-off-streaming-media-caching-always' and
'turn-off-streaming-media-caching-on-battery' flags to m89 in order to
support the run of the corresponding finch trial.

Bug: 984851
Change-Id: Ib2f2e43b292cbf0d333558f8f47ecbb1db4a3928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514804Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#823389}

This removes adding the qualifier PageTransition.FROM_API for
TabLaunchTypes of FROM_LINK and FROM_RESTORE. I believe this was
unintentional, and doesn't make sense to use FROM_API with.

This also removes FROM_API for intents that came from chrome and
launched chrome. Again, seems like we shouldn't use FROM_API for
this scenario either.

I came across this while doing the other patches. AFAIK nothing
depends upon this, just seems worth cleaning up.

BUG=none
TEST=none

Change-Id: Id89fbc0e70fb52a662ac33a55d269460677ee152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511853
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823388}

Let user enable IME mojo decoder from chrome://flags.

BUG=b/171846787

Change-Id: Ie101b36d3b8bf64695039992b2aac108be6c69cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509150Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Leo Zhang <googleo@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823387}

https://swiftshader.googlesource.com/SwiftShader.git/+log/eaf1c53544a7..959f41988a18

2020-11-02 capn@google.com Set the LLVM module's target triple

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I90dc4e63d9b30f25f3c32c44f2dc9d43b71bdd27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514641Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823386}

This CL focuses on separating out the suites and setting up unified testing, without any optimization to tests themselves. Obvious unused headers were removed.

Bug: 1059779
Test: browser_tests --gtest_filter=Scanning*
Change-Id: I4898564e15777fa0bc1d1d0fa5d8581ea5eb235d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514080
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823385}

CastOptionsProvider is moved back into //chrome and Chrome's
base java module. A copy is also made for WebLayer shell.

Bug: 1144240
Change-Id: Ieed443a573ef8c2361f48dd4915a92569dd5a9e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512808
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823384}

The previous metric in this space,
SafeBrowsingBinaryUploadRequest.AdvancedProtectionScanVerdict
was removed by https://crrev.com/c/2505943, so take this opportunity
to re-implement it in a slightly more robust way, based on the trigger
rather than inspection of the Request.

Change-Id: Ib5418d3cba4eadb110503ca48d81aff7fe2e78aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506572Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823383}

Fixed: 1140261
Change-Id: I3048004ebe36c0562028f2034d94bf4245736e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510715
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823382}

Clicking on an item in the download shelf or in chrome://downloads
attempts to open it in the OS-native application for that file type.
For example, it might open a video player or image viewer.

This needs to be handled by ash, so wire it through the
crosapi::mojom::FileManager API.

In the future we will need to show error messages for files that fail
to open. The new methods return a result enum. We also need this for
the existing ShowItemInFolder method, so deprecate the old one and
introduce an updated version.

This implementation isn't perfect. In some cases the file should be
routed back to the browser for display in a tab. Right now some files
that can't be opened in an app end up opening in an ash-chrome tab.
In the future we will need to wire up the ash file_manager code to
make "open in browser" redirect back to lacros-chrome.

Bug: 1141616
Test: added to lacros_browser_tests
Change-Id: I8cd4166bc594bf83a3ce9458d7c1d767bbb8c041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511589
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823381}

Move some private methods of Xcode(11)LogParser to public, and call
these at tear down of test_runner module for GTests running as XCTests.

To avoid duplicate logic where touched, this change also:
- Added using_xcode_11_or_higher() to xcode_util module.
- Added get_parser() to xcode_log_parser module.
- Renamed coverage_util to file_util and added in an archiving utility.

Bug: 1047704
Change-Id: Id66ebd7a4ca1b2f7ea494eda66c015240f581c13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496345
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823380}

This reverts commit 530c8fd2.

Reason for revert: caused tree closer due to missing mojom file: https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-rel/39820?

Original change's description:
> [Media Session] Convert interface from mojo to CPP
>
> Context: https://crrev.com/c/2485850
>
> This converts the MSS interface to CPP since it does
> not need to be mojo.
>
> BUG=1140215
>
> Change-Id: I595bef21cddf755bc0fb423f87db9e620227d3e6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503393
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823358}

TBR=avi@chromium.org,xiyuan@chromium.org,dcheng@chromium.org,beccahughes@chromium.org

Change-Id: I729b898ef30c220c779be615b0b6eb6abf8cfed5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1140215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515502Reviewed-by: Meredith Lane <meredithl@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823379}

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 1007792
Change-Id: I16c66d31f3c95b179288d2586682d981d0b4f7a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505946
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Auto-Submit: Renjie Tang <renjietang@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823378}

Previously if user revokes the notification access they granted earlier
from the phone, notification set up UI cannot show up again unless you
close and reopen the bubble. This CL fixes this by observing the change
of notification access and update the view's visibility accordingly.

BUG=1141610, 1106937
TEST=unittested.

Change-Id: Ife8f19e7e5b8c2ec9ea12a7cc9e0e2cc739af72d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508398
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823377}