• Nasko Oskov's avatar
    Alter the WebUIReuseInSubframe test to avoid being flaky. · 04a0ec29
    Nasko Oskov authored
    Unfortunately, the WebUIReuseInSubframe test is running into issues with
    the memory allocator returning separate instances of WebUI objects at
    the exact same memory address. This means that even though we have
    different instances of the object, which is what the test aims to assert
    it isn't possible to use pointer inequality as the assertion.
    I've modified the test to use the RenderFrameHost global routing id
    since one cannot have the same WebUI instance be owned by more than
    one RenderFrameHost instance.
    
    Bug: 713313, 1002276
    Change-Id: Iea036b5cd10962c75f86a5b25d9f655012caf686
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886292Reviewed-by: default avatarAaron Colwell <acolwell@chromium.org>
    Commit-Queue: Nasko Oskov <nasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#710440}
    04a0ec29
web_ui_security_browsertest.cc 20.3 KB