• David 'Digit' Turner's avatar
    android_crazy_linker: Disable r_brk() call for release builds. · 062fb24e
    David 'Digit' Turner authored
    Completely remove the ability to call r_brk() at runtime for
    release builds. Normally, this is controlled at runtime by
    calling crazy_set_debugger_support(false), which is actually
    performed by the //base/android/linker/legacy_linker.cc.
    
    However, due to yet-unsolved reasons, runtime crashes in
    r_brk() still happen on Intel-based devices, even though
    this function is now supposed to never be called.
    
    This patch is an ugly hack that removes the ability to
    call r_brk() entirely from the library's code, to unlock
    the release.
    
    A proper fix would understand what's really going on (e.g.
    passing of dangling pointers in deferred task callbacks?)
    and address that accordingly. Unfortunately, the issue is
    really difficult to reproduce locally.
    
    BUG=796938
    R=agrieve@chromium.org,pasko@chromium.org,rmcilroy@chromium.org
    
    Change-Id: I10a08fe3d551be39b6b9919420224b925b8be9a0
    Reviewed-on: https://chromium-review.googlesource.com/889757Reviewed-by: default avataragrieve <agrieve@chromium.org>
    Commit-Queue: David Turner <digit@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#532429}
    062fb24e
README.chromium 3.2 KB