• James Cook's avatar
    cros: Fix PreferencesTest.MultiProfiles and re-enable everywhere · 0b38d859
    James Cook authored
    The crashes under --mash are due to heap corruption from code trying
    to disable multi-user switching animations. That code does not seem
    necessary any more. Per crrev.com/223823004 when it was added this
    test was reliably failing. The multi-user switch animations have
    been recently refactored and a shelf animation removed. The test
    now passes even without the animation disabling code.
    
    I cannot reproduce failures or crashes without --mash. I've done
    ASAN runs as well. I suspect the non-mash problem in the bug is
    unrelated to this test and may have been fixed separately.
    
    Bug: 787050
    Test: browser_tests --gtest_filter=PreferencesTest.* --gtest_repeat=100
    Change-Id: I08dc3897361440fdbd49df1a11429e06fb9bac51
    Reviewed-on: https://chromium-review.googlesource.com/804401Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#521134}
    0b38d859
preferences_chromeos_browsertest.cc 10.9 KB