• Taiju Tsuiki's avatar
    Revert "Correctly initialize and test SnapContainerData in cc." · 0fc70abb
    Taiju Tsuiki authored
    This reverts commit 37061f87.
    
    Reason for revert:
    The layout tests added by this CL is failing on the CL:
    https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804
    
    Original change's description:
    > Correctly initialize and test SnapContainerData in cc.
    > 
    > This patch initializes the rect_ field in SnapContainerData in copy
    > constructor and move constructor. Fixing a snapping issue in the
    > composited pages.
    > 
    > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded
    > test suite so that they are tested with the composited cases.
    > 
    > snap-at-user-scroll-end-manual-automation.js calls
    > mouseClickInTarget() of pointerevent_common_input.js. That method
    > invokes programmatic scrolls. The test was written before programmatic
    > scroll snapping was implemented so it worked at that time. However,
    > with programmatic scroll snapping implemented, it will always snap
    > in mouseClickIntarget() and cannot test whether the user scroll snaps.
    > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget
    > to avoid invoking programmatic scrolls in the test.
    > 
    > This patch also checks nullptr for layout_box in
    > ScrollManager::SnapAtGestureScrollEnd() to fix a crash.
    > 
    > Bug: 862406, 862571
    > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e
    > Reviewed-on: https://chromium-review.googlesource.com/1132386
    > Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
    > Reviewed-by: Majid Valipour <majidvp@chromium.org>
    > Reviewed-by: Robert Flack <flackr@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574781}
    
    TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org
    
    Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 862406, 862571
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Reviewed-on: https://chromium-review.googlesource.com/1136171Reviewed-by: default avatarTaiju Tsuiki <tzik@chromium.org>
    Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574825}
    0fc70abb
scroll_snap_data.cc 11.5 KB