- 13 Jul, 2018 40 commits
-
-
Taiju Tsuiki authored
This reverts commit 37061f87. Reason for revert: The layout tests added by this CL is failing on the CL: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804 Original change's description: > Correctly initialize and test SnapContainerData in cc. > > This patch initializes the rect_ field in SnapContainerData in copy > constructor and move constructor. Fixing a snapping issue in the > composited pages. > > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded > test suite so that they are tested with the composited cases. > > snap-at-user-scroll-end-manual-automation.js calls > mouseClickInTarget() of pointerevent_common_input.js. That method > invokes programmatic scrolls. The test was written before programmatic > scroll snapping was implemented so it worked at that time. However, > with programmatic scroll snapping implemented, it will always snap > in mouseClickIntarget() and cannot test whether the user scroll snaps. > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget > to avoid invoking programmatic scrolls in the test. > > This patch also checks nullptr for layout_box in > ScrollManager::SnapAtGestureScrollEnd() to fix a crash. > > Bug: 862406, 862571 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e > Reviewed-on: https://chromium-review.googlesource.com/1132386 > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574781} TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862406, 862571 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1136171Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#574825}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Idbeb132167cb747f2b3a432c21ad861864587a35 Reviewed-on: https://chromium-review.googlesource.com/1136032Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#574824}
-
Taiju Tsuiki authored
This reverts commit 51181f47. Reason for revert: Speculatively revert for resolving the bot failure on the CI: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14387 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28041 Original change's description: > Increase the UI paint timeout to 5 seconds. > > This fixes the first browser window appearing blank for a moment. In > general, it's better to block than to show the UI in an inconsistent > state. Web content should *not* wait this long. > > Bug: 849762 > Change-Id: I2b73e52a0425ee6fa583fcddc0300dc8a2d3ad73 > Reviewed-on: https://chromium-review.googlesource.com/1135119 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574731} TBR=ellyjones@chromium.org,ccameron@chromium.org,sdy@chromium.org Change-Id: I80bd11b7478bd1b40b11c9c71aa75de65a874da9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849762 Reviewed-on: https://chromium-review.googlesource.com/1136131Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#574823}
-
Maajid authored
This reverts commit e2cee66e. Reason for revert: broke tree Original change's description: > Record to UMA when starting an ARC++ app from the launcher. > > Bug: 854542 > Test: chrome://histograms > Change-Id: I635aa0522ebb2cac70f056937508ff5ef183d244 > Reviewed-on: https://chromium-review.googlesource.com/1112891 > Reviewed-by: Yury Khmel <khmel@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Maajid <maajid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574819} TBR=stevenjb@chromium.org,rkaplow@chromium.org,khmel@chromium.org,maajid@chromium.org Change-Id: I48cd080e2b59f5bad5ea7a12ca1e50da7cb3cbad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854542 Reviewed-on: https://chromium-review.googlesource.com/1136111Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Maajid <maajid@chromium.org> Cr-Commit-Position: refs/heads/master@{#574822}
-
Derek Cheng authored
To ensure MediaRouter's route list is updated when a DIAL launch app fails, we will need to invoke erase the route from the list of records before notifying DialMediaRouteProvider of the route list update. Bug: 808720 Change-Id: I65c925dc74a57a1c2d80dc1366f8be3ccbf40ce5 Reviewed-on: https://chromium-review.googlesource.com/1134867Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#574821}
-
Peter Mayo authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http/tests/security/setDomainRelaxationForbiddenForURLScheme.html indicates that on many builders (probably all those without DCHECK on) this test passes. Bug: 699347, 686118 Change-Id: I7496ce45d0ce5c196073acba954f8cd48c7f1f3b Reviewed-on: https://chromium-review.googlesource.com/1135661Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#574820}
-
Maajid authored
Bug: 854542 Test: chrome://histograms Change-Id: I635aa0522ebb2cac70f056937508ff5ef183d244 Reviewed-on: https://chromium-review.googlesource.com/1112891Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Maajid <maajid@chromium.org> Cr-Commit-Position: refs/heads/master@{#574819}
-
Tim Zheng authored
This change removes from the shelf all Crostini spinners when one Crostini app is starting in a window but fails to uniquely identify app ID. BUG=chromium:854911 TEST=Manually tested on an even device. Change-Id: I2924e33ac5f0e0b0bd34d4ed05307d3aa0512cdf Reviewed-on: https://chromium-review.googlesource.com/1135837Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#574818}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5bc4fc8f3f26..13ac194dbf99 git log 5bc4fc8f3f26..13ac194dbf99 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 fmalita@chromium.org [skottie] Fix matrix parenting for default/static values 2018-07-12 caryclark@skia.org fix include generation 2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-12 bungeman@google.com Remove SkRefCnt_SafeAssign. 2018-07-12 bungeman@google.com Remove SkSafeSetNull. 2018-07-12 herb@google.com Move to using pointers in simplifyDraw* 2018-07-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c9c259cccb2e..1617e69e3883 (5 commits) 2018-07-12 brianosman@google.com Replace nearly all kRespect with kIgnore Created with: gclient setdep -r src/third_party/skia@13ac194dbf99 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Icd0d4fe7cb01295422218ef08a860a681010beab Reviewed-on: https://chromium-review.googlesource.com/1135621Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574817}
-
James Darpinian authored
Second try after revert 6df2efa5. Original at https://crrev.com/c/1105505 Automatically grow the transfer buffer when it is full and shrink it when the full capacity is not being used. Start at a smaller size. Before we would only grow it when a single transfer request was larger than the whole buffer; requests smaller than the whole buffer would just block if the buffer was full. Also we would not ever shrink the buffer until someone called Free() manually. Bug: 850271, 835353, 828363, 856347 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id1223267d0ab444afe18f62f45ae5f365131e18c Reviewed-on: https://chromium-review.googlesource.com/1125503Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#574816}
-
Jinsuk Kim authored
|ContentViewCoreImpl.initialize| is called to create various browser components in content layer when instantiating ContentViewCore. This CL moves the method to WebContents as a public API and let embedders call it instead of creating CVC. It leaves CVC empty, so deletes the class entirely. With CVC gone, null check against CVC object can be replaced with that against WebContents as embedders are already managing their references to them in sync (init/nulling out at the same time). Some methods with ContentViewCore in there names are updated as well to reflect what they really do after the change, such as s/createContentViewCore/initWebContents. Bug: 598880 Change-Id: Ic1ae53ec1addf74b56e2ae4c972b41889005a359 Reviewed-on: https://chromium-review.googlesource.com/989515 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574815}
-
Devlin Cronin authored
Point apps-related directories to //apps/OWNERS as the source of truth, and remove asargent (who's no longer on chrome) as an OWNER. Bug: None Change-Id: I631772b7bb05eaadcd8b5ac7153fa9b8d7b3ee41 Reviewed-on: https://chromium-review.googlesource.com/1135586Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#574814}
-
bsheedy authored
Fixes gn gen failing on Android when incremental_apk_by_default is true due to not forwarding additional_apks for monochrome_public_test_ar_apk. Bug: 863102 Change-Id: If2c168e5e966f3464056131635be84ede8f568e3 Reviewed-on: https://chromium-review.googlesource.com/1135911 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#574813}
-
wutao authored
This patch dismiss a notification when the close button is clicked. Bug: b/79493568 Test: manual. Change-Id: I3a17690f9e8f6a3e4178239ff2787618f6500c36 Reviewed-on: https://chromium-review.googlesource.com/1132376Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#574812}
-
Luciano Pacheco authored
DirectoryItem created without a specific NavigationModelItem defaults to SubDirectoryItem. Change DirectoryItem to check if entry has a NavigationModelItem to generate the appropriate derived "item" type from DirectoryItem. In particular, crostini will generate FakeItem. This fixes issue where crostini wouldn't mount because the trigger to mount is on FakeItem. Change FakeItem to have updateSharedStatusIcon as no-op, since it doesn't have a shared state. This fixes an error where DirectoryItem calls updateSharedStatusIcon on its sub-items, before FakeItem was used only as top-level so nobody was calling updateSharedStatusIcon. Change DirectoryTree to call EntryList to update its sub-directories since those sub-directories are usually volumes that need to update themselves. Add test createFolderNestedDownloads to check that EntryListItem call to updateSubDirectories doesn't have to be recursive. Change SubDirectoryItem to add "volume-type-for-testing" in test to fix tests using this selector when running with My Files enabled if the item is a volume. Bug: 857335 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8a579b9c754143d9ba8322aba9014e82a3ac1757 Reviewed-on: https://chromium-review.googlesource.com/1133616 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#574811}
-
James Darpinian authored
AMD's Linux driver crashes when calling glCopyTexImage2D with GL_PIXEL_UNPACK_BUFFER set to a buffer that hasn't been initialized yet. Bug: 859998, 850271 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I013892e39c02cfb3abc7079363ea4146915a2ac4 Reviewed-on: https://chromium-review.googlesource.com/1135848Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#574810}
-
Daniel Murphy authored
This allows the graceful downgrade of the session storage database from the new servicified database to the pre-servicification database. R=mek@chromium.org Bug: 859464,857464 Change-Id: I7049444a9c11b394c704b6a523c51c5b1ce47735 Reviewed-on: https://chromium-review.googlesource.com/1135894Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#574809}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bc787be40f68..d464e6a80005 Created with: gclient setdep -r src-internal@d464e6a80005 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:857193 TBR=mmoss@chromium.org Change-Id: I19ceae1ab29c387475500c5269913be2f20633fe Reviewed-on: https://chromium-review.googlesource.com/1135620Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574808}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1617e69e3883..523c5e3122ed git log 1617e69e3883..523c5e3122ed --date=short --no-merges --format='%ad %ae %s' 2018-07-12 jmadill@chromium.org Vulkan: Suppress PointCoord test on Android. Created with: gclient setdep -r src/third_party/angle@523c5e3122ed The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I7c18581906dd8fec26de2735c6117d58ba3710c9 Reviewed-on: https://chromium-review.googlesource.com/1135221Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574807}
-
liberato@chromium.org authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I915cf5ef2ab6bd23ecbb8fdc31a818f3e4ddbcdc Reviewed-on: https://chromium-review.googlesource.com/1134436Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#574806}
-
edchin authored
Previously, the tab grid regular tabs panel was being obscured when the app is backgrounded. This is not correct behavior. This CL fixes the logic so that the app is only obscured when an incognito tab is shown (either in tab view or tab grid). Bug: 852353 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ieb1355601515acd3869a03406b5d9d20ffb61ee3 Reviewed-on: https://chromium-review.googlesource.com/1131917 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574805}
-
Peter Mayo authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html# testType=webkit_layout_tests& tests=fast%2Fevents%2Fwheel%2Fwheel-scroll-latching-on-scrollbar.html shows that this test mostly passes on ToT now. Bug: 526463 Change-Id: I1f8403bd36799e162dd090aece9f3662d0e0bd13 Reviewed-on: https://chromium-review.googlesource.com/1135431Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#574804}
-
Nico Weber authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1133329 they are no-ops, so no behavior change. Parts of the CL generated by running git grep -l CORE_TEMPLATE_CLASS_EXPORT third_party/blink/renderer/ | xargs sed -i 's/CORE_TEMPLATE_CLASS_EXPORT//' Bug: 859989 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia398e2a4aa511d10577f5ab535c7f54bc3ac47c4 Reviewed-on: https://chromium-review.googlesource.com/1135293 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#574803}
-
Ned Nguyen authored
Bug: 771597 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I6c56cc352acf0b00bc526dd032d5f9af5bbc2cd2 Reviewed-on: https://chromium-review.googlesource.com/1135873Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#574802}
-
Khushal authored
R=asvitkine@chromium.org Bug: 863038 Change-Id: I520fac764e1cc1fda499a29a46aff3a663ad9ed1 Reviewed-on: https://chromium-review.googlesource.com/1135963 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#574801}
-
Peter Mayo authored
https://test-results.appspot.com/dashboards/ flakiness_dashboard.html#testType=webkit_layout_tests& tests=http/tests/origin_trials/sample-api-workers.html shows this has been passsing across all platforms for a long time. Bug: 711529 Change-Id: I7dc075e73c47c8f70347e8784aad563b01463118 Reviewed-on: https://chromium-review.googlesource.com/1135633Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#574800}
-
Alexey Baskakov authored
1) WebApplicationInfo and web_app.h are unrelated. 2) shell_integration.h is used only in win. Drive by: Remove some unused includes. Bug: 860581 Change-Id: Ifd0cec57dd0a54d81487f50fed0de44b487076b6 Reviewed-on: https://chromium-review.googlesource.com/1134639Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#574799}
-
Stephen Martinis authored
Bug: 758256 Change-Id: Icbd47e057881ec2dc2e2eb1cc733b5dd34326991 Reviewed-on: https://chromium-review.googlesource.com/1130499Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#574798}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8a2e331aa718..882c91ed97c3 git log 8a2e331aa718..882c91ed97c3 --date=short --no-merges --format='%ad %ae %s' 2018-07-12 jbudorick@chromium.org Revert "gclient: Add support for the branch:revision format." 2018-07-12 ehmaldonado@chromium.org gclient: Add support for the branch:revision format. Created with: gclient setdep -r src/third_party/depot_tools@882c91ed97c3 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850812,chromium:853032,chromium:850812,chromium:853032 TBR=agable@chromium.org Change-Id: I0d20f9028843ba043b8adbeee7f10bd0e8ad68f1 Reviewed-on: https://chromium-review.googlesource.com/1135220Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574797}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/66447ba64fcc..8495de1eb482 git log 66447ba64fcc..8495de1eb482 --date=short --no-merges --format='%ad %ae %s' 2018-07-12 dtu@chromium.org [pinpoint] Fix: Use new results path for performance_webview_test_suite. 2018-07-12 dtu@chromium.org [pinpoint] Use old isolate target for jobs before OBBS migration. 2018-07-12 benjhayden@chromium.org Add /api/timeseries2 Created with: gclient setdep -r src/third_party/catapult@8495de1eb482 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:862654 TBR=sullivan@chromium.org Change-Id: Ifb6b94cad8056d5d2b668fe3acde70ea8d00fbeb Reviewed-on: https://chromium-review.googlesource.com/1135218Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574796}
-
Ian Kilpatrick authored
This removes the layout-tree fixup which kept leading abs-pos & floats in an inline context in a block context. This makes an additional 8 tests pass which needed this fix. The failures in the patch broadly fall into these buckets. 1) Paint invalidation changes. Now that the floats are within the line boxes, and the paint invaldation is different. This was likely hiding other issues, and we'll need to investigate these. 2) Three crashes which I believe might be fixed by Christian's pending min/max fix. 3) One selection and one editing failure. 4) Static position of abs-pos and text alignment failures. (this was hiding a larger bug). 5) A few other random failures. The rebaselines are from new layout-tree dumps, and/or "simple" (i.e. just name changes) within the paint invalidation dumps. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib5cc99219d31cb11ef18c8f10f7f4e9e0fea8db6 Bug: 734554 Reviewed-on: https://chromium-review.googlesource.com/1132541 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#574795}
-
Zhiheng Vincent Li authored
There is a flashing page when transiting from one cast app to another cast app or when stopping a cast app. It is caused by redrawing the webcontent view when destroying the WebContents. Bug: internal b/79172781 b/79694573 Test: manually tested on Jasper Change-Id: Ib445301a1f0d2a79cdf5a7dd2652a0666c570f06 Reviewed-on: https://chromium-review.googlesource.com/1132622Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Cr-Commit-Position: refs/heads/master@{#574794}
-
Christian Biesinger authored
When we are sized to shrink-to-fit, we can use the cached preferred logical width when we have one; this patch implements that. It also changes ComputeInlineSizeForFragment to take a Node, which simplifies several callers. While writing this CL, I discovered a missing check for IsParallelWritingMode in ComputeMinAndMaxContentContribution; that change is conceptually unrelated to this CL but without it 20 tests fail. Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id793856d86b12bd46fd7e1bab42541520c7ea031 Reviewed-on: https://chromium-review.googlesource.com/1128195 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#574793}
-
Moe Ahmadi authored
__gCrWeb.fill.setInputElementValue gives the input element focus prior to setting its value and restores the focus to the previously focused element afterwards. When a suggestion is selected, the previously focused element can be <body> which leads to focus events on the body with no useful form activity information to be sent to the WebStateObservers. This CL adds a |hasUserGesture| parameter to the FormActivityParams so that the observers can detect and avoid acting on such events. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I67f993dd2e7737f3a37f479df4ade1932e94666d Reviewed-on: https://chromium-review.googlesource.com/1126480 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574792}
-
xlou authored
Missed some in CL: crrev.com/c/1128325. Since the UI displays Pages Per Sheet for the N-up setting, and there was a review comment previously to rename it to pages_per_sheet, so I am renaming the variable name here. In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. Bug: 775999 Change-Id: Ie605699d64a3ad1fcf2f943378e08065048183e5 Reviewed-on: https://chromium-review.googlesource.com/1135895Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Shirleen Lou <xlou@chromium.org> Cr-Commit-Position: refs/heads/master@{#574791}
-
Kim Paulhamus authored
Tbr: tkent@chromium.org Bug: 863067 Change-Id: I913685da055480d9cddea105808a16fd7e70facd Reviewed-on: https://chromium-review.googlesource.com/1135982Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#574790}
-
Xu Xing authored
BUG=857217 Change-Id: I328529cc444ddcadad83eeb4b9aa5ff445844912 Reviewed-on: https://chromium-review.googlesource.com/1125518Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#574789}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ed5e651e. With Chromium commits locally applied on WPT: a9045946 "Add a fail-fast for longtask layouttests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21191 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=foolip No-Export: true Change-Id: I8cbb857220afec37734ab39cca07d888d7d3c941 Reviewed-on: https://chromium-review.googlesource.com/1135754 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#574788}
-
Marc-Antoine Ruel authored
This is a reland of 3bcc71d8 Now code search should be fine. Original change's description: > Add luci-go tool to be fetched via CIPD > > Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes > need to be updated. > > Change analyze to not ignore changes to isolate. > > R=tandrii@chromium.org > > Bug: 851596 > Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5 > Reviewed-on: https://chromium-review.googlesource.com/1097623 > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569688} Bug: 851596 Change-Id: Icd227efde182ff844e93dbb692124c1297ab0d7c Reviewed-on: https://chromium-review.googlesource.com/1135791Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#574787}
-
siyua authored
This is the 2nd CL wiring things up with changes in AutofillClient and BrowserCommands. There will be one following CL on unit-test and metrics. Previous CL: 1128569. For project details, please refer to design doc go/ib-paradise. This project is to offer users an option to upload chrome local credit cards to Google Pay server. This bubble UI is the entry point of the entire flow. It should be anchored to a credit card icon in the location bar and be shown from it. Bug: 852904 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5a53f54fda97157cd0d0e7a8fe500728b4733515 Reviewed-on: https://chromium-review.googlesource.com/1134193 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574786}
-