• Dominic Battre's avatar
    Introduce Finch parameter for hiding a password generation popup · 147162d9
    Dominic Battre authored
    If a user focuses a field for which password generation is promoted, a popup is
    shown.
    
    http://crrev.com/288935 introduced that this popup remains visible until the
    user has typed 5 characters, hypothesizing that users look at their keyboard
    while typing and therefore not notice the popup.
    
    Our new hypothesis is that this a) may not be true, and b) may bother users
    because the popup occludes part of the website, in particular it can occlude
    password requirements for users who chose to invent their own password.
    
    This CL introduces a Finch experiement such that we can test whether keeping the
    popup visible until the user has typed >5 characters produces a statistically
    significant higher number of generated passwords. If not, we can just hide the
    password generation popup as soon as the user has typed a key.
    
    The default configuration sticks to the 5 character threshold.
    
    Bug: 859472
    Change-Id: I1d2a82ce90f696dc32d97633ac29ba15f3ea9bbd
    Reviewed-on: https://chromium-review.googlesource.com/1122399
    Commit-Queue: Dominic Battré <battre@chromium.org>
    Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#572131}
    147162d9
password_generation_agent.h 9.75 KB