• Samuel Huang's avatar
    Revert "Downloads: detect failed file icons and show default thumbnail" · 14d25fb9
    Samuel Huang authored
    This reverts commit 1ec12653.
    
    Reason for revert: Likely to cause consistent failures in single_process_mash_interactive_ui_tests for linux-chromeos-dbg due to assertion failure from missing icon "cr:insert-drive-file".
    
    Bug: 912678
    
    Original change's description:
    > Downloads: detect failed file icons and show default thumbnail
    > 
    > On the downloads page, we consult the system for a themed image for the
    > type of file downloads. Ex: zip files -> archive icon.
    > 
    > When a system doesn't know why type of icon to show for a specific file
    > type, it can either return a default or nothing. Right now, Linux
    > returns nothing, so we show nothing.  chrome://fileicon tries to warn
    > us by giving a network error (which has been ignored until now).
    > 
    > So, when a chrome://fileicon fails to load, show a default filetype
    > icon in respond.
    > 
    > Before & after screenshots: https://imgur.com/a/txRbfIG
    > 
    > R=​dpapad@chromium.org
    > BUG=855259
    > 
    > Change-Id: I370fd8ea119b194ad8e1ba7e0dfad32c6cea1bbe
    > Reviewed-on: https://chromium-review.googlesource.com/c/1132560
    > Commit-Queue: Dan Beam <dbeam@chromium.org>
    > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614581}
    
    TBR=dbeam@chromium.org,dpapad@chromium.org
    
    Change-Id: I4ef27f132954754a80e3b3def4aadf5774b3875d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 855259
    Reviewed-on: https://chromium-review.googlesource.com/c/1367933Reviewed-by: default avatarSamuel Huang <huangs@chromium.org>
    Commit-Queue: Samuel Huang <huangs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614713}
    14d25fb9
icons.html 2.53 KB