• xhwang@chromium.org's avatar
    Add CHECK on file descriptor in various IPC::ChannelHandle passed in. · 1749d14a
    xhwang@chromium.org authored
    Regarding Chromium issues 73355, 95129, 95732, 97285, 103957 and Chromium-os issue 18437, 22372, we suspect the channel handles passed to the renderer have invalid file descriptors (fd). This is supported by the fact that using a channel handle with a valid name but an invalid fd will produce crashes with exactly the same stack trace as reported in these issues. Running out of fd in either the renderer, browser or the other process (GPU, broker, etc) could cause this to happen, but we are not sure if that's the real cause.
    
    Adding check for the fd in various places to help investigate these issues further. We will be able to tell if invalid fd is passed in and if yes, which process generates it. Browser side check is only added for the broker case to limit the scale of bad user experience, while providing enough cases for investigation.
    
    BUG=none
    TEST=passed unit tests
    
    Review URL: http://codereview.chromium.org/8735015
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112647 0039d316-1c4b-4281-b951-d872f2087c98
    1749d14a
gpu_channel_manager.cc 4.71 KB