• James Cook's avatar
    lacros: Avoid login crash when user disables the LacrosSupport flag · 179337dd
    James Cook authored
    CrOSComponentManager::Unload() calls into code in MetadataTable that
    assumes that system salt is available. This isn't always true when
    chrome restarts to apply non-owner flags.
    
    Unfortunately the MetadataTable API is synchronous and non-trivial
    to convert to async. Work around the crash by ensuring system salt
    is available before attempting to unload the lacros component.
    
    Filed crbug.com/1122753 to track refactoring MetadataTable so it
    doesn't depend on data that isn't guaranteed to be available.
    
      in about:flags, restart and let Lacros download/install. Then
      explicitly set flag to "Disabled" and sign out (not restart).
      Sign in again. No crash.
    
    Test: With non-owner account (secondary user), enable LacrosSupport
    Bug: 1122674
    Change-Id: Idf25ef8955315e92c6f823a0da8f8b65fd0a40c9
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380320Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#802427}
    179337dd
browser_loader.h 2.04 KB