• sebmarchand@chromium.org's avatar
    Rename FORCE_DETERMINISTIC_BUILD to DONT_EMBED_BUILD_METADATA. · 19677409
    sebmarchand@chromium.org authored
    Strictly speaking this flag isn't here to force a deterministic build, it's here to help us to make sure that no build metadata ends up in the build artifacts to help us guarantee a deterministic build.
    
    (See the discussion in https://codereview.chromium.org/324403006/ for more details)
    
    FTR, Nico said he'll take care of getting rid of __DATE__ and __TIME__ so this
    new define will not be necessary for that.
    
    On the other hand we may have issues with absolute path in __FILE__ and whatever
    unforeseen C++ issue. This would require #ifdef'ing them out. This is not
    something devs would want to do normally so this flag is off by default.
    
    Eventually we'll want to fix the build system to not have to hack __FILE__ out
    by ensuring they are *always* relative paths but until then, this variable can
    be used to make progress
    
    
    R=maruel@chromium.org, thakis@chromium.org
    TBR=brettw@chromium.org
    
    BUG=314403
    
    Review URL: https://codereview.chromium.org/330813003
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278053 0039d316-1c4b-4281-b951-d872f2087c98
    19677409
common.gypi 208 KB