• Reilly Grant's avatar
    serial: Use USB driver name to disambiguate ports · 19e1c500
    Reilly Grant authored
    On systems with both the built-in serial driver and a third-party driver
    the same port can be enumerated more than once. This difference is
    visible to the user in the device path shown in the chooser but was
    previously ignored when constructing a persistent ID for the port.
    
    This patch replaces the generic persistent ID field with the individual
    components that are available on each platform. This should make it
    easier to modify these rules over time as the components won't be opaque
    to SerialChooserContext. This is a breaking change which will cause
    previously granted persistent permissions to be ignored.
    
    On macOS the name of the USB driver (the parent of the BSD serial
    port) is now included in the set of fields used to identify a device in
    order to differentiate between USB devices with otherwise have the same
    USB vendor ID, product ID and serial number.
    
    Bug: 1127535
    Change-Id: If1b06ab82a975976e1e3b7d2075216f11afda5dd
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413176
    Commit-Queue: Reilly Grant <reillyg@chromium.org>
    Reviewed-by: default avatarTom Sepez <tsepez@chromium.org>
    Reviewed-by: default avatarJames Hollyer <jameshollyer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#811028}
    19e1c500
serial_chooser_context.cc 14.2 KB