GitLab

SyncData::ToString() is used for logging and, starting with
https://crrev.com/c/2562659, it can DCHECK-fail if the sync entity's
title is empty.

This patch removes the DCHECK from SyncData::GetTitle(), since it
seems overly strict, and the main calling site in
SyncableServiceBasedBridge already verifies that the title is non-empty.
To make this more obvious, an additional DCHECKs is introduced (which
is redundant with pre-existing DCHECKs) and two functions renamed for
clarity.

Change-Id: Ib499e6a07132ab21033d83a241e5e380226913b0
Fixed: 1156130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577468
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#834673}