• Bartek Nowierski's avatar
    PA: Remove DCHECK from AllocFlagsNoHooks->PartitionRefCountPointer path · 253798c2
    Bartek Nowierski authored
    If GigaCage isn't enabled, this DCHECK will get triggered:
    AllocFlagsNoHooks->PartitionRefCountPointer->DCheckGetSlotOffsetIsZero->
    ->PartitionAllocGetSlotOffset->
    ->DCheckIfManagedByPartitionAllocNormalBuckets
    
    GigaCage isn't needed to set up PartitionRefCount. It's only needed to
    easily detect from BackupRefPtr code if PartitionRefCount is available,
    but this won't be an issue because BackupRefPtr is disabled when
    GigaCage isn't needed.
    
    Bug: 1073933
    Change-Id: Iaea2781d207e9534293a1b3dd57dd6c42a422ed7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620922Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
    Commit-Queue: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
    Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#842036}
    253798c2
partition_root.h 53 KB