• Darren Shen's avatar
    ime: Fix handling autocorrect during key event. · 2cfbefe0
    Darren Shen authored
    When an IME issues autocorrect related operations during a key event,
    the operation is not immediately executed, but stored as 'pending'.
    After the key event is handled, the pending operation is executed.
    
    However, there is a boolean guard to see if there is any pending
    operations in the first place. Unfortunately, the guard doesn't check
    for autocorrect related operations, only commits and compositions.
    
    So pending autocorrects are executed only when it is accompanied by a
    pending commit / composition.
    
    To fix this in a robust way, simply delete the guard, since we do the
    same check in the function that executes the pending operations anyway.
    Eliminating the check means we don't have to remember to update the
    guard whenever we add a new type of pending operation.
    
    Bug: b/176942429
    Change-Id: Ie6178d1b139d27fb9ffb40cffe3d29ddd2b548d6
    Fixed: b/176942429
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612551Reviewed-by: default avatarJohn Palmer <jopalmer@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#841342}
    2cfbefe0
input_method_chromeos.h 7.17 KB