- 08 Jan, 2021 40 commits
-
-
Darren Shen authored
When an IME issues autocorrect related operations during a key event, the operation is not immediately executed, but stored as 'pending'. After the key event is handled, the pending operation is executed. However, there is a boolean guard to see if there is any pending operations in the first place. Unfortunately, the guard doesn't check for autocorrect related operations, only commits and compositions. So pending autocorrects are executed only when it is accompanied by a pending commit / composition. To fix this in a robust way, simply delete the guard, since we do the same check in the function that executes the pending operations anyway. Eliminating the check means we don't have to remember to update the guard whenever we add a new type of pending operation. Bug: b/176942429 Change-Id: Ie6178d1b139d27fb9ffb40cffe3d29ddd2b548d6 Fixed: b/176942429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612551Reviewed-by:
John Palmer <jopalmer@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#841342}
-
Shakti Sahu authored
This CL fixes IPH card rounded corner color for night mode. Also added test for video player URL builder. Bug: 1117148 Change-Id: Ia798a7122f6b992e758629d2d1d0830892090a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613933 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841341}
-
John Chen authored
Update bot dimensions for linux-perf after OS upgrade from Ubuntu 14.04 to 18.04. Bug: 1162000 Change-Id: Ia2f40977120ccf0ac4b2037114c3d20ba5bdeb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617240Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841340}
-
Matt Reynolds authored
The Device Class Definition for HID defines a bitfield that accompanies each Main item in the HID report descriptor. The bitfield is a 32-bit value that defines 9 attributes. Three of these attributes were already exposed in the HID report item dictionary (isAbsolute, isArray, hasNull), this CL adds the remaining six. Bug: 1156954 Change-Id: Ic0d7d069010bdc0c75369fbc1fb85586d5caeefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605585Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#841339}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610042255-43b4d84a21124c058546cf1e621ecfbb55dbe4e7.profdata to chrome-linux-master-1610063718-75764fb6f7cc7a2d4d8119e0952784a5ac3fa72a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If182b483b8f8bb52c056e7a0682240110bf374a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617302Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841338}
-
Tal Pressman authored
We are in the process of attributing as many mojo interfaces as possible to specific execution contexts, which would enable better control by the browser over those contexts. As part of that effort, this CL uses the execution context's BrowserInterfaceBroker to bind the PushMessaging remote and moves the code registering the binders accordingly. Bug: 1126758 Change-Id: Idfd27baf90fc2fa5e150f0d97753e21757104607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596587Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#841337}
-
Evan Stade authored
Bug: 1158941 Change-Id: Iac4c4b0c662d556100a908ab4f878237fb810b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611697 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841336}
-
Elly Fong-Jones authored
Bug: 1075649 Change-Id: I362bc9bc9416a941821d2213473d618539729026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615204Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#841335}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a7158eb524dd..f99ccb082ba5 2021-01-07 syoussefi@chromium.org Vulkan: Add a perf warning when dropping superseded updates 2021-01-07 jonahr@google.com GLX: Avoid creating child window when X visual ID is specified. 2021-01-07 timvp@google.com Capture/Replay: Capture glBindBufferBase during MEC setup If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132827 Tbr: ianelliott@google.com Test: Test: angle_perftests --gtest_filter="*world_war_doh*" Change-Id: I60d3b4a7a2c0ce2683f45c73ccb260c0eb8f3cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616731Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841334}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c392afda300..60b433cf0b29 2021-01-08 sokcevic@google.com Enable packfile offloading on all builders 2021-01-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136986 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I164d956916abe371e94d4d20efb76274f1b46359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617028Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841333}
-
Sebastien Marchand authored
The impl of ConfigurePartitionAlloc is already behind a allocator_shim_default_dispatch_to_partition_alloc.cc but its declaration isn't, this cause some linker issues when doing some non-PAE builds: lld-link: error: undefined symbol: void __cdecl base::allocator::ConfigurePartitionAlloc(void) >>> referenced by .\..\..\chrome\app\chrome_main.cc:74 >>> obj/chrome/chrome_dll/chrome_main.obj:(ChromeMain) Bug: 1121427 Change-Id: Ie589f1b3ac57d6a13be361e9669c2fc6855e8115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616460Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#841332}
-
Wenyu Fu authored
The PendingIntent created by FRE is not expected to be changed after creation. Bug: 1164088 Change-Id: I8330329bb7f340c6375a82db23f11e2880894abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617120Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841331}
-
Luciano Pacheco authored
Move launchFileManager() from `launcher` namespace and registerDialog() from global namespace to the interface FileBrowserBackgroundFull. This keeps consistent all access from foreground page going through this interface. Bug: 1133186 Change-Id: I342af2db0aaec75843a9dccff777a6da29d3b9b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613848Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#841330}
-
Jiewei Qian authored
Test is failing on Mac10.14 Tests. Tbr: johnchen@chromium.org Bug: 1164115 Change-Id: Iadec9aa292b612e0b01c598b322b149ca1c6d3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615721 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#841329}
-
Xing Liu authored
This matches the behavior when the URL is not supported by download. Bug: 1157808 Change-Id: I5300adefc2d4f8e90c2345d0aacb38514ba55d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616481 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#841328}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610042255-6162d74e2be35377f4b6bbd9ca05127a363b0c50.profdata to chrome-win32-master-1610052964-246b43420c64aac53ecf14d1b97c19dc58b69e86.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I02b5252c5d3d9d9ca29fde6f4b82128a696ae7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616840Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841327}
-
Rakib M. Hasan authored
The GOMA freeze has ended. Now we can use GOMA to compile the weblayer skew tests on the refresh-weblayer-skew-tests builder. Bug: 1041619, 1099017 Change-Id: I0794c836add2498b8dfc9f52f3b82ff7fbd4ff6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616959Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#841326}
-
Matt Falkenhagen authored
This is a reland of 28610054 It was reverted as a suspected cause of AutofillPrivateApiTest.GetCountryList browser_test failure. https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/59127 But that test has been flaky from before the CL and is now disabled, see https://crbug.com/1155072 and https://crbug.com/1162474. Original change's description: > service worker: Simplify main resource "handler" & "interceptor" (2/3) > > The "handler" can call the loader callback directly. > > Bug: 1138155 > Change-Id: I618991ca62f83d1336405de7f824fcf43c893ac0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596592 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Asami Doi <asamidoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840521} Bug: 1138155 Change-Id: I53b8b4734bcc4abf0ee53fc8e30552bb2a1abb51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616639Reviewed-by:
Asami Doi <asamidoi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#841325}
-
Christopher Lam authored
This CL fixes an issue where target=_blank links in Chrome Apps wouldn't open when clicked. This CL adds a target_blank_implies_no_opener WebPreference as enabled by default and plumbs the disabling from extension_webkit_preferences.cc. Bug: 1152286 Change-Id: Ib4e86c5df9c2a2f8945178c47bcd6cb4cd62ff9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612624Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#841324}
-
Bao-Duy Tran authored
Window::GetRootWindow() returns a nullable but there's currently no null guard nor DCHECK at callsite KeyboardUIController::DeactivateKeyboard(). This is causing some nullptr crash. The crash cannot be repro'd manually and it's unclear as to why this didn't cause issues earlier. Bug: 1162338 Change-Id: I40baabcb32aa4d41943af27372c8e2410c2d49f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612587Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#841323}
-
David Bienvenu authored
Bug: 1145235 Change-Id: I5f47f1d107dce8bdc1fe50b5ffb9b600771bf1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614845 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#841322}
-
Reilly Grant authored
This change implements a blocklist for USB serial devices similar to the one used for the WebUSB API. The implementation is kept separate because the set of filterable device properties will be different for serial ports even though the current implementation only supports matching USB devices. Devices on the blocklist will not appear in the device chooser prompt and previously granted permissions will be ignored. Bug: 884928 Change-Id: I4397452aad0738bc80b31c82460f3f37b5fc6324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613792 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#841321}
-
Azeem Arshad authored
This CL moves the cellular_eid_popup element from settings/chromeos to cr_components/chromeos since this components will also be used in cellular_setup in OOBE. Bug: 1093185 Change-Id: If5d74c365377bbbd4d4732ec82eb981e14bfff01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612219 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#841320}
-
Hassan Talat authored
This CL pulls out the tasks from the chromeos folder and moves it to the webshare root folder so the macOS implementation can use it. Bug: 1144920 Change-Id: I942399d1da8759bcbd77e46a3fde0b400e96789c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615664 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#841319}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/57e353f840ef..db2dad5c644f 2021-01-07 brianosman@google.com SkSL-to-SkVM: Prepare to handle function calling 2021-01-07 ethannicholas@google.com Beginnings of the SkSL DSL framework 2021-01-07 johnstiles@google.com Report a parsing error when invalid tokens are detected. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I9a6d43fc7a3733a79d8caaecd287ec8ea84c87cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616919Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841318}
-
Eric Willigers authored
Change-Id: I117057cb9ca420b082fa7e66a5362b2c41866483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615720 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#841317}
-
Xing Liu authored
Add "New" text through IPH system to provide FRE for reading list. Bug: 1151567 Change-Id: I62534a77be3b3ac931c2e5cdf53028480dd1795f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597814Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841316}
-
mlcui authored
Like the V1 settings page, every disabled IME can be tab-selected to enable it. However, the outline showing that the IME was selected was hidden, which made it unclear what the currently tab-selected item was without using ChromeVox. This CL unhides the outline, making it clear that the IME item is selected. Fixed: 1163872 Change-Id: I708f2e2d666da0dfe6e4a6f3a831f8e5a92b0bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616640Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: Michael Cui <mlcui@google.com> Cr-Commit-Position: refs/heads/master@{#841315}
-
Sammie Quon authored
Some functions mostly for testing that are no longer used. Bug: none Test: compiles Change-Id: I7f6c6cdc51595668109923c3c199a9a1d969af0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616758Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#841314}
-
Harvey Yang authored
This commit adds OnECLidAngleDriverStatusChanged in AccelerometerReader::Observer, which simplifies implementations of AccelerometerProviderInterface by removing the one-time-read. This commit also implements AddObserver, RemoveObserver, StartListenToTabletModeController, and StopListenToTabletModeController in AccelerometerProviderInterface instead of the derived classes. BUG=b:171446270, b:172414227 TEST=unit tests and run on kohaku(with iioservice) and helios(without iioservice) Change-Id: Ic0d37edc8df22cbd6facf54fe5fb0d11425be2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538855 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#841313}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5e4ae54dec3d..cdb3bc3b93da 2021-01-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a66f367f..aff08690 (841068:841210) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2a504654a37c2a0c23a3f2947b3ad6edf22b7f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617027Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841312}
-
Jeffrey Kardatzke authored
This adds a parameter to CreateCdm so we can pass the origin to the CdmFactoryDaemon so it can use proper per-site identifiers in provisioning requests. BUG=b:153111783 TEST=Verified with corresponding ChromeOS change that origin is sent Change-Id: Ic2cfbdf54feb173969bee7377acdc244422eccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613944 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#841311}
-
Nancy Wang authored
Add the restore_id to AppLaunchParams and browser::CreateParams, to set the id from the restore data as the window's property: kRestoreWindowIdKey, for the full restore to restore browser windows. Modify the web app interface CreateWebApplicationWindow to pass the restore id to the browser class. BUG=1146900 Change-Id: Ia9c88a7f3eddcd0d984d555c6cd15a9351fa5248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599650 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#841310}
-
Clark DuVall authored
The supports_isolated_split arg is no longer needed since all DFMs support isolated splits. Bug: 1126301 Change-Id: Idf1ef64bec372f21efd68cb9d05933690cf8b1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617118 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#841309}
-
Leonid Baraz authored
The declaration in proto would now match code and TIN. Bug: b:170054326 Change-Id: I1204ec91bf592ba31d592abb4461f9b83c81ae7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615102 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#841308}
-
Aaron Leventhal authored
Help determine causes of flakiness for Hyperlink issues, as well as flaky tests for aria-hidden iframes. Use @WAIT-FOR done with 50ms timeout in order to give iframe sub documents a chance to load. The timeout is not ideal, but there currently is no better way unless the iframe has some actual contents to wait for. Bug: 1158699,1157731 Change-Id: If6526616f6f9ceeac59a80c8ee8c2cb6b4d6e83a Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611284 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#841307}
-
Ken MacKay authored
The mixer ensures this in actual operation, and some postprocessors assume that the frame count is divisible by 8. Change-Id: I8fb5cd808c0e481f9a19e77c96595023e1320112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616867Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#841306}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fc4d8fb1. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing domenic@chromium.org, hiroshige@chromium.org: external/wpt/import-maps eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer rego@igalia.com: external/wpt/css/css-grid external/wpt/css/selectors NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I0f399ae6788eaf391e9423a24d82b45a50ecfa13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616341Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841305}
-
Victor Costan authored
The MediaCodecVideoDecoderAV1Test test suite is currently not instantiated, so it does not run at all. Also, the MediaCodecVideoDecoderTest suite is not currently run for the AV1 codec. This CL fixes both problems. The first problem was discovered by attempting to roll googletest past CL 315255779, which causes test binaries to fail when they include test suites / parametrized tests that are not instantiated, and when they include empty test suites. Bug: 1163396 Change-Id: Id2a070cfeed6d37b920b5d28f947037ac5699fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616486 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841304}
-
Tommy Nyquist authored
This reverts commit 8ce519f2. Reason for revert: FeedProcessScopeDependencyProviderTest fails to initialize on internal buildbot. Original change's description: > Feedv2: Add a persistent key value store > > This is provided for use by xsurface. It is backed by Chrome's > shared ProtoDatabase. Data is automatically wiped on the same > events that wipe other feed data. > > Bug: 1158468 > Change-Id: Id215ec00311883acc65c7f3d6b87570c4b255278 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590649 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841148} TBR=sky@chromium.org,thakis@chromium.org,isherman@chromium.org,dewittj@chromium.org,ssid@chromium.org,freedjm@chromium.org,harringtond@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: If83ab5a8f427a2cd269d89c4957e475dd861545e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1158468, 1164102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617198Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#841303}
-