GitLab

This reverts commit c10ef92a.

Reason for revert: Causes GATT connection failures on Windows
(crbug.com/1106597)

This is a partial revert. I'm not including updates to the comments in
device/bluetooth/bluetooth_discovery_session.h because they were
unrelated to the actual change and are still correct despite the revert.
(See the PS1/PS2 diff for the re-revert.)

Original change's description:
> fido: stop scanning for BLE advertisements before connecting
>
> Anecdotally, GATT connection reliability on Windows is higher if the
> Bluetooth adapter is not scanning while the connection attempt occurs.
> Hence, make FidoCableDiscovery invoke BluetoothDiscoverySession::Stop()
> before connecting to a device. Obviously, there is a possibility of
> scans occurring for other reasons. But that's unlikely to happen and we
> can't do anything about it.
>
> Note that stopping the scan probably means a single FidoCableDiscovery
> instance can at most connect a single device. However, caBLEv1
> currently only really supports a single authenticator anyway.
>
> Change-Id: Ibaac6bc1563e4429dad0df9570f77c594ed1469c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211281
> Commit-Queue: Martin Kreichgauer <martinkr@google.com>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Adam Langley <agl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#781094}

Bug: 1106597
Change-Id: I1e4fcf5b6be1d26a4d7634ad1fe96df1d07b176a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303683
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789705}