- 18 Jul, 2020 7 commits
-
-
Martin Kreichgauer authored
This reverts commit c10ef92a. Reason for revert: Causes GATT connection failures on Windows (crbug.com/1106597) This is a partial revert. I'm not including updates to the comments in device/bluetooth/bluetooth_discovery_session.h because they were unrelated to the actual change and are still correct despite the revert. (See the PS1/PS2 diff for the re-revert.) Original change's description: > fido: stop scanning for BLE advertisements before connecting > > Anecdotally, GATT connection reliability on Windows is higher if the > Bluetooth adapter is not scanning while the connection attempt occurs. > Hence, make FidoCableDiscovery invoke BluetoothDiscoverySession::Stop() > before connecting to a device. Obviously, there is a possibility of > scans occurring for other reasons. But that's unlikely to happen and we > can't do anything about it. > > Note that stopping the scan probably means a single FidoCableDiscovery > instance can at most connect a single device. However, caBLEv1 > currently only really supports a single authenticator anyway. > > Change-Id: Ibaac6bc1563e4429dad0df9570f77c594ed1469c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211281 > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781094} Bug: 1106597 Change-Id: I1e4fcf5b6be1d26a4d7634ad1fe96df1d07b176a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303683 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#789705}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/320ceb93a21c..4bbdfa583e74 2020-07-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib06e97bec490a7100e713362a05d6469cc458390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305233 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789704}
-
Matt Menke authored
These are not commonly included in header files, but fairly often used in cc files, so including them in a widely used header can lead to IWYU issues (this header isn't widely used directly, but was transitively included in 8,000+ files). Bug: None Change-Id: Id08418b088d6b9e55cd9c86852363b016b842b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300033Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#789703}
-
Greg Thompson authored
This CL adds FLAG_SHARE_DELETE to many file operations in Chrome's installer; including in delta patch processing and archive extraction utilities. This allows processing on files that are held open to be deleted by another entity so that we can eventually hold temporary files open with FILE_FLAG_DELETE_ON_CLOSE. BUG=516207 Change-Id: I1cd03f6360dfcd61fcd2f09797f0923331076415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302109Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#789702}
-
Alexander Alekseev authored
This Cl exposes viz::DebugRendererSettings members as checkboxes in ash HUD overlay. Bug: 1085288,1085287,1085279 Change-Id: Id6ad4aa632cb552277ba47d076056b5ca0cc51f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303468Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#789701}
-
Collin Baker authored
This adds another step to the in-product help promo for creating a new tab group. If a tab context menu is opened before IPH times out, the new group menu item will be highlighted. Bug: 1102655 Change-Id: I6955445394fdd01bffb33ba73e98be914cd93b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297811 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#789700}
-
Mohamed Heikal authored
This reverts commit 7a1a3bdc. Reason for revert: breaks android-archive-rel https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/13342 Original change's description: > Fix build issues with creating R.java in java_library targets > > A collection of bugfixes for creating R.java in java_library_impl > targets: > - test libraries support. > - apk under test R.java shadowing bugfix. > - always generate onResourcesLoaded like package resources did. > - Fix issue where R.java is not generated for the apk package name. > > Bug: 1073476 > Change-Id: I0cebd9626b0ce9049554f8345af516f7bd0ec2aa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302919 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789690} TBR=agrieve@chromium.org,mheikal@chromium.org Change-Id: I0113b626a076a3b01abbe985560c5d9f1470faa9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1073476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302816Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789699}
-
- 17 Jul, 2020 33 commits
-
-
manuk authored
With the 1-line UI, rich autocompletion adds a label adjacent to the omnibox and then resizes the two as the autocompletion length changes. On location bar focus, the omnibox is unelided; e.g. google.com is unelided to https://www.google.com. Before this CL, unelision occurs *after* the location bar is given focus and its layout computed. With this CL, unelision occurs *before* the location bar is given focus so that it can reserve sufficient width for the unelided URL when updating its layout. Bug: 1062446 Change-Id: Id78d635255de69d9af97a5589a9e001eee3d0feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304666 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#789698}
-
Jonah Chin authored
This change sets up PaintImage to lazily trigger a readback of SkImage via MailboxTextureBacking. It also implements the readback API itself in RasterImplementation. This API is required for OOPR-Canvas as certain PaintImage users need image pixels in CPU memory. More details about overall PaintImage effort: crbug.com/1023259 Info about the OOPR-Canvas2D project: crbug.com/1018894 Bug: 1023281, 1031050 Change-Id: Ib1a1ee3c8ceef72b045277540393a5f55f3135ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280391Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#789697}
-
Weilun Shi authored
After moving some functions from net// to base//, the UnescapeValue no longer needs to depend on net// so it can be moved to base/metrics/field_trial_params where it gets used. Also replace the temporary NoOpDecodeFunc with the UnescapeValue as it's available now. Bug: 1068052 Change-Id: I1b1790a3e1491a834822d017a5f2f4bfa34ffbec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298942 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#789696}
-
Devlin Cronin authored
Some features specified more types than corresponded to the allowlisted IDs. Remove the unnecessary types. (There may be more entries with this issue, but these were the ones I saw.) Bug: None Change-Id: Ib19bc8691b569127a835edc2a967c2f6ca1082a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304957Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789695}
-
K. Moon authored
Adds functions for converting from gfx::Rect to pp::Rect, and from gfx::Size to pp::Size. Also makes a few extra improvements: 1. Adds unit tests. 2. Orders Point functions before Rect and Size, for consistency. Bug: 1101101 Change-Id: I5e3b0a3e5361d799103c9771ac29a9c0b74df999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304931 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#789694}
-
rbpotter authored
These flags aren't needed once Polymer 3 code is fully checked in, except for cases where import paths don't match the source tree structure (e.g. Print Preview). Bug: None Change-Id: Ie040cbb7498afc0aa2ec847b0993f6fcaac9aed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303308Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#789693}
-
Clark DuVall authored
This callback should never be null. Bug: 1062962 Change-Id: Ie81c2f52914823df3fa2e55a0d2633779d18a826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305117 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789692}
-
Emily Stark authored
In the simplified domain field trials, the path, scheme, and optionally subdomains get faded to transparent when the user interacts with the page or after the user hovers and exits the mouse. But there are various ways that it's possible to transition from this state (path, scheme, subdomains faded out) to showing the full URL. However, the method that shows the full URL wasn't applying any color changes, only changing the display area/offset. This could lead to some situations where the full URL is scrolled into view, but some parts of it were still transparent (see bug for repro). To fix this, ShowFullURL() now resets the text color and applies emphasis by calling EmphasizeURLComponents(). This ensures that all components of the URL are not just scrolled into the display area but also colored properly and not transparent. Bug: 1106478 Change-Id: Ifc57b33c8e6604764ca004a7035c382465711b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305031 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#789691}
-
Mohamed Heikal authored
A collection of bugfixes for creating R.java in java_library_impl targets: - test libraries support. - apk under test R.java shadowing bugfix. - always generate onResourcesLoaded like package resources did. - Fix issue where R.java is not generated for the apk package name. Bug: 1073476 Change-Id: I0cebd9626b0ce9049554f8345af516f7bd0ec2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302919 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#789690}
-
Piotr Bialecki authored
Changes: - Roll ARCore SDK to version 1.18. - Updated device implementation to opt in to use 30FPS. - Updated ARCore APK version to 1.18.200603086 for the test bots to use. - Updated ARCore session recording - now that the code opts in to use 30FPS, the recordings need to be done at 30FPS as well, otherwise the camera configuration will fail. ~3kb since it needs to consume newly introduced APIs to configure AR session. The remaining size increase can be mostly attributed to the dependency growing (+8kb) and overhead (~4kb) - see breakdown for details. Binary-Size: Size increase is unavoidable. The product code increased by Change-Id: Ied48a1d4e6203e697ff5489547f7e9a67be6af0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300808 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789689}
-
Edward Lesmes authored
It was moved to the infra repo [1] so that it could be used by projects other than chromium. [1] https://chromium.googlesource.com/infra/infra/+/HEAD/go/src/infra/tools/dirmd/README.md Bug: 1102997 Change-Id: Idef030d4630d2408acf803e405f3e3b5b06d223c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304105Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#789688}
-
shrekshao authored
Sync with spec update: https://github.com/KhronosGroup/WebGL/pull/3115 Bug: angleproject:4838 Change-Id: Iefa754f90b42f8557c4aa088d0bad5b0d2013317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304134Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#789687}
-
Xiaoling Bao authored
1) Copy raw bytes from std::string to NSData when making request. 2) Copy raw bytes from NSMutableData to std::string when post response back to caller. 3) Forward additional post headers to NSMutableURLRequest so they can be actually sent. Bug: 1106820 Change-Id: I4517abea4ffb087f4bd433dcea85ff0e1a0427d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304994 Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789686}
-
Ian Kilpatrick authored
This reverts commit d73ae868. The issue which caused the bot failures was due to a difference in logic between 32bit, and 64bit arch. See: https://chromium-review.googlesource.com/c/chromium/src/+/2304143 This patch has remained unchanged except for part which landed before to fix another unrelated issue. See: https://chromium-review.googlesource.com/c/chromium/src/+/2304659 Original change's description: > Revert "[LayoutNG] Move relative position calculation into NG." > > This reverts commit 27880cb4. > > Reason for revert: > > Suspect of blink_web_tests failures in a lot of bots, like this one: > > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/70261 > > Unexpected Failures: > * fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html > * fast/css/relative-positioned-block-nested-with-inline-parent.html > * paint/invalidation/compositing/composited-float-under-composited-inline-individual.html > * paint/invalidation/compositing/composited-float-under-composited-inline.html > * paint/invalidation/compositing/stacked-float-under-composited-inline.html > > Original change's description: > > [LayoutNG] Move relative position calculation into NG. > > > > This patch moves the relative position calculation into NG. Previously > > we needed to manually account for the relative position of an object > > in many different places, overflow calculation, geometry APIs etc. > > > > This patch directly updates the child's offset (relative to its parent) > > to directly incorporate this additional offset. > > > > This calculation occurs within the NGBoxFragmentBuilder, and if an > > object is *placed* by LayoutNG... > > ...LayoutBoxModelObject::RelativePositionOffset returns an empty offset. > > > > This fixes a few small issues where previously we didn't resolve > > percentages against the correct available size when contained within > > an anonymous block. > > > > Bug: 1070822, 1058690 > > Change-Id: I2c623b02cc5a4605d310596f5c60353a21236bff > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214608 > > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#787991} > > TBR=yosin@chromium.org,wangxianzhu@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org,yosin@google.com,mstensho@chromium.org > > Change-Id: I5ca67701222509693d3020fa068c279cef39ecbb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1070822, 1058690 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296628 > Reviewed-by: Jian Li <jianli@chromium.org> > Commit-Queue: Jian Li <jianli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788228} Bug: 1070822, 1058690 Change-Id: I85a51c06d47c9eb451e8e7b77418913e288b7758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300667Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#789685}
-
Alex Cooper authored
https://crrev.com/c/2304097 updated the tests that originally required this exception to be added so that they now automatically skip/pass on Windows 7, so we don't need to keep these exceptions anymore. Bug: 1106809 Change-Id: Ia84e677ed9d6f74e040a24a73a0fa4a14720b778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304936 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#789684}
-
Gabriel Charette authored
R=mpearson@chromium.org Bug: 969934 Change-Id: I422cc9030ea6c48870a3c82df85ce343b92f0607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304168 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#789683}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Id3b57710dde76947090ebcc89c00fb1384a2a7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305014Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789682}
-
Yuke Liao authored
The existing setup of enabling code coverage in try builder is incorrect, and this CL fixes the issue with the following steps: 1. 'Win x64 Builder', 'Win10 x64 Release (NVIDIA)' and 'Win10 Tests x64' have isolate_profile_data mixin. 2. 'win10_chromium_x64_rel_ng' is switched to mirror the builders mentioned in 1 instead of their code coverage counterparts. 3. Remove the code coverage counterparts of the builders in 1. Bug: 1004523 Change-Id: I34348739e7ef9ea608593ba75f31781d1b84d486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197858 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#789681}
-
Brian Sheedy authored
Makes the following changes to //content/test/gpu: 1. Adds an explanation for why too-few-public-methods shouldn't be removed. 2. Removes the general broad-except disable and inline disables it in the few valid use cases we have. 3. Removes the general too-many-branches disable and inline disables or fixes the resulting errors. Bug: 1076144 Change-Id: If357e34f3e935464db54136b87f7c260ba4e5e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303597Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789680}
-
David Maunder authored
Currently PersistedTabData is in chrome/android. This causes problems as we migrate tab fields to the CriticalPersistedTabData UserData object. Bug: 1105667 Change-Id: I4364df3dc70723f2f522714afac64ee4d2c1d757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300328Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#789679}
-
Sebastien Lalancette authored
TBR=robertma@chromium.org Bug: 1106861 Change-Id: Idd91371a1d9e6bb4013e3d7b147ecdbe4b6461d2 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304103 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789678}
-
Reilly Grant authored
This change enhances the cancel() method on SerialPort.readable so that is requests a flush of the serial port's receive buffer as required by the draft specification[1]. [1]: https://reillyeon.github.io/serial/#dfn-serialportsourcecancelalgorithm Bug: 989653 Change-Id: I8f6550ea6ac7093a04ca814b1f1b6b8d5d08ee76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250366 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#789677}
-
Sonny Sasaka authored
This CL adds BluetoothBatteryClient which is a proxy to BlueZ's org.bluez.Battery1 interface. Future CLs will interact with this new interface to get battery level of Bluetooth devices and store the value to BluetoothDevice object. Battery API Doc: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/refs/heads/chromeos-5.54/doc/battery-api.txt Bug: b:160905767 Change-Id: I2bee100b25518b48a296b87657026769058384d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296266 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#789676}
-
Scott Violet authored
This is in preparation for using favicons in WebLayer, which won't use history. BUG=1076463 TEST=covered by tests Change-Id: I4adc5bd015cfdda16e3189f30df5a854dc0a4a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305038Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789675}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9109ad22..c80db6e1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8853506baf40fdbbca7b3df04929b4a3ae5f0d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303704Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789674}
-
Ben Joyce authored
Jacoco is not generating .exec files for junit targets. I traced the root of the issue to the out/Debug/lib.java/base/base_java.jar (and other host jars) not being run through jacoco. Less redundant code would be to set the _previous_output_jar to the results of the host_filter jar, but then that'd get run through desugar, which was the reason for the changes in the first place (see https://chromium-review.googlesource.com/c/chromium/src/+/2241865) We were running on-the-fly code coverage with a javaagent sent as an arg to the jvm, but that did not generate the desired coverage data so we're going to use all offline. Bug: 1097815 Change-Id: I0d9b4a48f921b743ee5179345fd6a81fa9437cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291835 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#789673}
-
Gabriel Charette authored
Currently being used for MessagePump jank investigations R=chromium-metrics-reviews@google.com, fdoray@chromium.org Bug: 1104928 Change-Id: I97cd90523dad2fc561155b0e45d4fcc9be855be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305033 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#789672}
-
Dean Michael Berris authored
In the ReportSender API, the callbacks are semantically called once and therefore should be base::OnceCallback instances instead of base::Callback (an alias to base::RepeatingCallback). Bug: chromium:1007815 Change-Id: I2a2f1d79f2c6c6dba1282174e71108b2c8e66c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291307 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Dean Berris <dberris@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#789671}
-
George Steel authored
The vscode clangd extension now uses this directory. Change-Id: I0232a3ac556ddbe2b867e8db508e1a86380fd6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297814Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789670}
-
Ian Kilpatrick authored
Previously we used slightly different logic for storing ink-overflow in the compressed "outsets" format, and the "NGSingleInkOverflow" object format. This resulted in differences in when running a 64bit binary (typical) vs. a 32bit binary with large ink-overflows (which are relative uncommon). This patch changes the "NGSingleInkOverflow" to have the same outset logic. Change-Id: If9d5146ec3fad1de27cfda2c13980312886b1e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304143Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#789669}
-
James Cook authored
set_sources_assignment_filter() causes files to be magically excluded from sources lists based on path (e.g. *_win*). It is considered a misfeature of gn, see bug or docs/no_sources_assignment_filter.md Convert BUILD.gn to use conditionals to include source files only on the platform where they are used. Bug: 1018739, 1096762 Test: compiles Change-Id: Ic5563a3558d9bdc8b9bc22bb6275d869a0985c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303463 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#789668}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaca01acfdb0fab350ca38a6d96e042e3d33f7356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304101Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789667}
-
Alexander Cooper authored
Converts the OpenLoginTabCallback from Callback to RepeatingCallback. Converts base::Bind calls that were being passed to methods that take RepeatingCallback's to BindRepeating. Converts a few Callbacks being used as OpenLoginTabCallback in chrome/browser as well, since that is how the initial need for changes was discovered. Bug: 1007635,714018 Change-Id: I3a514a2eff2d821e2a34d9537440407eab1619e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297565 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#789666}
-