• Yuichiro Hanada's avatar
    Revert "Floating Keyboard stops propagation of drag handle events" · 35a52924
    Yuichiro Hanada authored
    This reverts commit 6b3d6841.
    
    Reason for revert: Please refer to crbug.com/831521 . We need to pass tap events in the drag handle.
    
    Original change's description:
    > Floating Keyboard stops propagation of drag handle events
    > 
    > If a touch/mouse event occurs and it is interpreted as a floating
    > keyboard drag event, do not propagate the event to the javascript
    > keyboard extension as there is no reason to.
    > 
    > This was causing the drag event to cause the gesture swiping to be
    > active while dragging the keyboard around, particularly if the keyboard
    > was bounded to the bottom of the screen and the user's finger is able
    > to move around on the keys while still moving the keyboard (see
    > attached bug for repro/video).
    > 
    > Bug: 826078
    > Change-Id: I40c859f979d41a5d61e88ff0bd41808dcf3940c2
    > Reviewed-on: https://chromium-review.googlesource.com/997195
    > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
    > Commit-Queue: Blake O'Hare <blakeo@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#548374}
    
    TBR=yhanada@chromium.org,blakeo@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 826078
    Bug: 831521
    Change-Id: I9dded92a6e7b2ec1f97ebd169c463686c23d5d7c
    Reviewed-on: https://chromium-review.googlesource.com/1006715
    Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
    Reviewed-by: default avatarYuichiro Hanada <yhanada@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#549862}
    35a52924
keyboard_controller.cc 28.5 KB