• David Van Cleve's avatar
    Trust Tokens: Avoid printing console errors on "unactionable" failures · 3e32429d
    David Van Cleve authored
    We occasionally fail Trust Tokens operations due to transient
    unavailability of the entire Trust Tokens logic, for instance when third
    party cookies are being blocked unconditionally due a user setting. This
    logic (in url_loader_factory.cc, providing the `authorizer` callback
    argument to TrustTokenRequestHelperFactory) means that Trust Tokens
    operations will sometimes fail "during normal operation," at no fault of
    the caller's.
    
    We'd like to avoid printing console errors in this case. For instance,
    right now because third party cookies are disabled by default in
    incognito mode, we print a console error on every Trust Tokens operation
    executed in incognito mode.
    
    This CL extends the Trust Tokens-related console message suppression in
    FrameConsole to encompass "unactionable" Trust Tokens failures, like
    ones due to TrustTokenOperationStatus::kUnavailable, which represents an
    unavoidable unavailability of the Trust Tokens subsystem.
    
    Test: Adds an inspector-protocol WPT ensuring no errors are logged
    Bug: 1111572
    Change-Id: I53898a272fb8063cdbddfda0e916e49525973d09
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385878Reviewed-by: default avatarYutaka Hirano <yhirano@chromium.org>
    Commit-Queue: David Van Cleve <davidvc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#804251}
    3e32429d
NeverFixTests 162 KB