• Fady Samuel's avatar
    Surface synchronization: Add diagnostic CHECK · 3fb6e543
    Fady Samuel authored
    Current evidence points to a race in cc that is causing surface invariants
    violations (No invariants violations detected in LayerTreeHost but detected
    in ClientLayerTreeFrameSink).
    
    My suspicion is viewport is updated out of sync with LocalSurfaceId and
    device scale factor.
    
    This CL adds a diagnostic CHECK between the pending and active LayerImpls to
    attempt to detect the race and produce a better stack trace. The invariant
    we want to test here is if active tree has an invalid viewport (viewport has
    changed), then the LocalSurfaceId MUST change.
    
    Bug: 672962
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I975c9dfb9c86c292d7aac052bac01510e6efb1c2
    Reviewed-on: https://chromium-review.googlesource.com/989851Reviewed-by: default avatarenne <enne@chromium.org>
    Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#547457}
    3fb6e543
layer_tree_impl.cc 78 KB