• Reilly Grant's avatar
    Revert "Stop building SkCodec" · 445fcc90
    Reilly Grant authored
    This reverts commit fd493b4b.
    
    Reason for revert: Broken build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/114259
    
    Original change's description:
    > Stop building SkCodec
    > 
    > Bug: 768878
    > 
    > Building SkCodec seems to have caused a paint regression on a webpage
    > without any images. This leads us to suspect "some minor compiler
    > optimization tickling". Stop building it to confirm. Two CLs rely on
    > SkCodec:
    > 
    > "Use SkCodec internally in GIFImageDecoder"
    > 4fed3346. This introduced building
    > SkCodec.
    > 
    > "Enable Skia's SkImageGenerator implementation"
    > f5eb27c2. This used SkCodec to fix
    > crbug.com/758459, but that seems to have been fixed in another way.
    > 
    > In addition, this corrects some formatting in the old code (as
    > commanded by presubmit), and makes some other minor changes (no more
    > PassRefPtr, FrameDurationAtIndex now returns a TimeDelta).
    > 
    > Change-Id: Ic2bdd87740da0232c9c07e27eed6049efc26d76c
    > Reviewed-on: https://chromium-review.googlesource.com/718918
    > Commit-Queue: Leon Scroggins <scroggo@chromium.org>
    > Reviewed-by: Chris Blume <cblume@chromium.org>
    > Reviewed-by: Fredrik Söderquist <fs@opera.com>
    > Reviewed-by: Leon Scroggins <scroggo@chromium.org>
    > Reviewed-by: Philip Rogers <pdr@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#509570}
    
    TBR=scroggo@chromium.org,pdr@chromium.org,fs@opera.com,cblume@chromium.org
    
    Change-Id: Ib4c5be2e885f483d881ca65689cb5e9f3dc755df
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 768878
    Reviewed-on: https://chromium-review.googlesource.com/724359Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
    Commit-Queue: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#509577}
    445fcc90
ImageDecoder.h 17.4 KB