• Giovanni Ortuño Urquidi's avatar
    Revert "Support feedback keyboard shortcut in views login screen." · 47a732b0
    Giovanni Ortuño Urquidi authored
    This reverts commit b0278053.
    
    Reason for revert: UserAddingScreenTest.ScreenVisibility has been
    flaky since this landed:
    
    https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=UserAddingScreenTest.ScreenVisibility
    
    [28936:28936:0617/213745.316026:FATAL:accelerator_manager.cc(32)] Check failed: !base::ContainsValue(targets, target). Registering the same target multiple times
    #0 0x000004980f5c base::debug::StackTrace::StackTrace()
    #1 0x000004902b4b logging::LogMessage::~LogMessage()
    #2 0x000005857d49 ui::AcceleratorManager::Register()
    #3 0x000001ca3442 chromeos::WebUILoginView::WebUILoginView()
    #4 0x000001c9a51c chromeos::LoginDisplayHostWebUI::InitLoginWindowAndView()
    #5 0x000001c98cc5 chromeos::LoginDisplayHostWebUI::OnStartUserAdding()
    #6 0x000001ca20c7 chromeos::(anonymous namespace)::UserAddingScreenImpl::Start()
    #7 0x0000015dfd1c chromeos::UserAddingScreenTest_ScreenVisibility_Test::RunTestOnMainThread()
    #8 0x000004f449b7 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
    
    Original change's description:
    > Support feedback keyboard shortcut in views login screen.
    >
    > This CL supports alt+shift+i to open the feedback dialog in views login
    > screen.
    >
    > Bug: 852242
    > Change-Id: I9a285c6929fd2302d22f90fbefbb32bcd814359d
    > Reviewed-on: https://chromium-review.googlesource.com/1102035
    > Reviewed-by: Tom Sepez <tsepez@chromium.org>
    > Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#567829}
    
    TBR=xiyuan@chromium.org,tsepez@chromium.org,jdufault@chromium.org,xiaoyinh@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 852242, 853445
    Change-Id: I21afadf31af3c9ae8e04a30f6021b928efde43f8
    Reviewed-on: https://chromium-review.googlesource.com/1103957
    Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Reviewed-by: default avatarGiovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#567935}
    47a732b0
lock_contents_view.h 14.7 KB