• Mike Dougherty's avatar
    Revert "Do not recover incognito tabs if user deliberately terminates Chrome." · 47c34860
    Mike Dougherty authored
    This reverts commit 0928665a.
    
    Reason for revert: This behavior is causing more confusion for users than it is helping. See crbug.com/854274 for details.
    
    Original change's description:
    > Do not recover incognito tabs if user deliberately terminates Chrome.
    >
    > Previously incognito tabs were always recovered no matter how the app
    > was last shutdown.
    >
    > Instead, do not restore the incognito tabs if the user explicitly closes
    > Chrome. If the system terminates the app, the tabs should be restored.
    > (This can happen at any time and without user notice, so such
    > terminations should not lead to a loss of the user's incognito tabs.)
    >
    > Bug: 653248
    > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    > Change-Id: I018cdf5cda2004e32e1010c4d9bab4bd10c0ae99
    > Reviewed-on: https://chromium-review.googlesource.com/835532
    > Reviewed-by: Eugene But <eugenebut@chromium.org>
    > Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#526099}
    
    TBR=marq@chromium.org,eugenebut@chromium.org,michaeldo@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 653248, 854274
    Change-Id: I952db05d6364d0944c3e46b9fa78b1432e889830
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1106777
    Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
    Reviewed-by: default avatarMike Dougherty <michaeldo@chromium.org>
    Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#568603}
    47c34860
app_state_unittest.mm 37.9 KB