• robhogan's avatar
    Reland of Don't paint underline or selections over ellipsis in mixed-flow... · 495d8354
    robhogan authored
    Reland of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #1 id:1 of https://codereview.chromium.org/2615843002/ )
    
    Reason for revert:
    This patch was not the culprit for the layout test failures.
    
    Original issue's description:
    > Revert of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ )
    >
    > Reason for revert:
    > Causes test failures on Win10 Win7 bots:
    > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/18739
    >
    > webkit_tests webkit_tests
    >
    > unexpected_failures:
    > fast/forms/select/menulist-appearance-basic.html
    > fast/forms/select/menulist-style-color.html
    > fast/forms/select/select-selected.html
    > fast/forms/select/menulist-width-change.html
    > fast/forms/select/option-text-clip.html
    > fast/forms/select/option-script.html
    > fast/forms/select/option-strip-whitespace.html
    > fast/forms/color/input-appearance-color.html
    > fast/forms/select/select-dirty-parent-pref-widths.html
    > fast/forms/select/select-initial-position.html
    > fast/forms/select/menulist-deselect-update.html
    > fast/forms/select/select-change-listbox-to-popup.html
    > fast/forms/select/select-background-none.html
    > fast/forms/select/menulist-update-text-popup.html
    > fast/forms/select/select-baseline.html
    >
    > Original issue's description:
    > > Don't paint underline or selections over ellipsis in mixed-flow contexts
    > >
    > > Also, ensure the selected text is painted correctly when an ellipsis is present
    > > in a mixed-flow context (e.g. ltr text in an rtl container).
    > >
    > > BUG=642454, 642450, 642460
    > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    > >
    > > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
    > > Cr-Commit-Position: refs/heads/master@{#441486}
    >
    > TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
    > # Skipping CQ checks because original CL landed less than 1 days ago.
    > NOPRESUBMIT=true
    > NOTREECHECKS=true
    > NOTRY=true
    > BUG=642454, 642450, 642460
    >
    > Committed: https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d
    > Cr-Commit-Position: refs/heads/master@{#441599}
    
    TBR=eae@chromium.org,szager@chromium.org,loyso@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=642454, 642450, 642460
    
    Review-Url: https://codereview.chromium.org/2611233002
    Cr-Commit-Position: refs/heads/master@{#441775}
    495d8354
ellipsis-mixed-text-in-rtl-flow-underline-2.html 483 Bytes