• Mohammad Refaat's avatar
    Stop sending TabChange notification for Favicon updates. · 49ad9b78
    Mohammad Refaat authored
    TabStripController used didChangeTab TabModelObserver's method
    to monitor favicon changes. This was done through TabModelFaviconDriverObserver
    which used to forward to Favicon driver notification through didChangeTab.
    So to remove the connection between didChangeTab and favicon notification i
    changed TabModelFaviconDriverObserver to be WebStateListFaviconDriverObserver
    and it will have a bridge to be used to monitor the favicon driver observer.
    Also instead of going through TabModel, WebStateListFaviconObserver will be
    monitoring the webStateList given at its constructor and Observing each of its'
    webstates favicon drivers. TabStripController conform to the bridge protocol and
    creates a WebStateListFaviconObserver giving it the webStateList to monitor its
    drivers.
    
    
    
    Bug: 911350
    Change-Id: I19a8523c368aa06dabc80005ffcf65d78c00e07f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626544
    Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
    Reviewed-by: default avatarMark Cogan <marq@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#663090}
    49ad9b78
BUILD.gn 6.43 KB