GitLab

TabStripController used didChangeTab TabModelObserver's method
to monitor favicon changes. This was done through TabModelFaviconDriverObserver
which used to forward to Favicon driver notification through didChangeTab.
So to remove the connection between didChangeTab and favicon notification i
changed TabModelFaviconDriverObserver to be WebStateListFaviconDriverObserver
and it will have a bridge to be used to monitor the favicon driver observer.
Also instead of going through TabModel, WebStateListFaviconObserver will be
monitoring the webStateList given at its constructor and Observing each of its'
webstates favicon drivers. TabStripController conform to the bridge protocol and
creates a WebStateListFaviconObserver giving it the webStateList to monitor its
drivers.



Bug: 911350
Change-Id: I19a8523c368aa06dabc80005ffcf65d78c00e07f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626544
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663090}

This change adds a PopupType parameter to both AutofillClient's
ShowAutofillPopup() and AutofillPopupControllerImpl's Show(). This will
be needed for the ManualFillingController on Android to determine
whether to show the TouchToFill Sheet for Passwords or not.

Bug: 957532
Change-Id: I31cd1ecee7d403adea8dfee894b0271b19c35213
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619946Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663089}

ThreadPoolImpl tests currently run for each combination of:
- thread pool type
- traits
- execution mode

In preparation for a CL that adds new traits, this CL extracts tests
that don't query the traits and execution mode to a separate test
class that only runs for each thread pool type.

Change-Id: Ic8406101eeb10288dd5e797747ec2be3fc8f654a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626872Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663088}

Error badges should not participate in the reading from screen readers
like ChromeVox. This is similar to the other error icon:
|IDR_WEBUI_IMAGES_ERROR|, which is always set as a background image and
never with an |img| tag.

Bug: 966770
Change-Id: I798edae34aca18c0f2e7be927bc452cf90c05b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628735
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663087}

This is needed for a few operations that can bypass prefs, like users
clearing all the cookies.

Bug: 958923
Change-Id: Id5551698f5664f8f4356827ed0f4456c813c2e70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625045
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663086}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c308a3de9628..21e35ed8258b


Created with:
  gclient setdep -r src-internal@21e35ed8258b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=yukishiino@google.com,lgrey@google.com,masonfreed@google.com,rsorokin@google.com

Change-Id: I42d229dec70e62433b1d04802115b43b50386150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628459Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663085}

Code from this CL is now unnecessarily complicated (and might have been
so all along):
https://chromium-review.googlesource.com/c/chromium/src/+/1560298
There is no need for OverviewSession::GetGridWithOverviewItem() when we
have OverviewItem::overview_grid(). Then there is also no need for
OverviewSession::AddDropTargetForDraggingFromOverview() or
OverviewSession::RemoveDropTargetForDraggingFromOverview(), as the whole
purpose of putting them in OverviewSession was so that they could call
OverviewSession::GetGridWithOverviewItem(). In fact, currently,
OverviewWindowDragController::CompleteNormalDrag() uses
item_->overview_grid()->RemoveDropTarget() whereas
OverviewWindowDragController::ResetGesture() uses
overview_session_->RemoveDropTargetForDraggingFromOverview(item_), and
there is no reason why they should use different code to remove the drop
target.

Test: manual
Change-Id: Ic973e90d08c9b81b00566306e6b3e3e655939ef4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628233Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663084}

Currently, this doesn't do much because showcase has no way to fetch the
image, but the URL is there just in case.

Bug: 966429
Change-Id: I34f7bf7a329e60774c7ca314994e86123dae451d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627374
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663083}

TBR=nasko@chromium.org
Bug: 947715,966488

Change-Id: Ic2a11f998a315ee5dc111168db20423b5a6f17d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620365Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663082}

Revert "Changing OAuth2TokenService::Observer and its subclasses to use CoreAccountId instead of std::string"

This reverts commit 2669b5b5.

Reason for revert: I believe this one is responsible for compile failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8912567103159431936/+/steps/compile/0/stdout

Original change's description:
> Changing OAuth2TokenService::Observer and its subclasses to use CoreAccountId instead of std::string
> 
> This cl is part of the effort to use CoreAccountId instead of std::string
> to denote account_id.
> 
> Bug: 959157
> Change-Id: I6b95b6adf7d73228c399162daf2867c532acd7cd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626599
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: Tanmoy Mollik <triploblastic@google.com>
> Cr-Commit-Position: refs/heads/master@{#663069}

TBR=droger@chromium.org,sdefresne@chromium.org,triploblastic@google.com

Change-Id: I716aa951acef794062444f73954083e5b0981c29
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 959157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628724Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663081}

webrtc::acm1::AudioCodingModuleImpl::PlayoutData10Ms can no longer be found in
code search, so remove the style suppression.

Bug: 348511
Change-Id: Id723f1ca2bb0927be198f1b4166f8fd786fc2893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620590
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663080}

And specifically set it when processing windows messages. As almost everything
starts from a windows message setting the id when processing a windows message
should help us better attribute which code is at fault.

BUG=966526
TEST=covered by test

Change-Id: I48851150fa55523cffb936d0f2f199ade04cac0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626640Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663079}

This CL merges ProvidedByWebApkSplashDelegate and
SameActivityWebappSplashDelegate. As a benefit of the merging,
new-style WebAPKs get:
- offline error dialog
- splash screen hiding functionality

BUG=817263
R=dominickn
TBR=yfriedman (for renaming SameActivityWebappSplashDelegate->WebappSplashDelegate)

Change-Id: I930817d457c51b45156cecf06ce23a94432fa613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608728
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663078}

      change to Accept-Encoding requested headers, and www.google.com
      returns a brotli-compressed response that is correctly rendered.

Test: Local inspection shows enabling the feature causes the correct
Bug: 961735
Change-Id: I1afe26e9c539e639b07ab70fdbccb36c908e7cd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628614Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663077}

This reverts commit 6a008993.

Reason for revert: https://crbug.com/966766, more information at https://crbug.com/955936 beginning at comment 13

Original change's description:
> [Mac] Preserve symbolic link in the copy_bundle_data tool.
> 
> The copy_bundle_data tool is implemented in terms of pax for directories
> and ln hard links for files. The pax command does preserve symbolic
> links within the tree that is being copied. But with the way that pax is
> invoked by the tool, cd-ing into the source, if the source is itself
> a symbolic link to a directory, the tree will be logically copied rather
> than just as a symbolic link.
> 
> A similar issue exists with the non-directory symbolic link source case,
> where a hard link will be produced instead of a symbolic link.
> 
> Fix both of these cases by specifically testing if the source is a
> symbolic link and then re-creating it if so.
> 
> Bug: 955936
> Change-Id: I69cf96878e59b0b7b121ae46cba5bc1e81f261ae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626269
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662575}

TBR=sdefresne@chromium.org,rsesek@chromium.org,mark@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 955936
Change-Id: Ia1489278b62d0cdb33ed8980bbd6a6bcab0bb199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628045Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663076}

This is a reland of 4ded38ed

The original CL was reverted due to timeouts on ChromeOS debug for the
enabled test. It turns out that the underlying issue is most probably
due to a race condition which exists in loading and MHV creation
process in the absence of NetworkService. Since this has nothing to do
with the underlying fix, relanding the same CL but disabling the
test on ChromeOS when the MVH flag is on but NetworkService is not.
Also adding comment to link to the current outstanding bug for
similar timeout failures in some MHV tests on debug ChromeOS bots.

Original change's description:
> [ MimeHandlerView ] Block PluginStatus != kAllowed/kPlayImportantContent
>
> Currently, a MimeHandlerView is created as long as there is a plugin
> for it. This behavior undermines issues such as <webview> permissions
> API.
>
> This CL will avoid creating MimeHandlerView if the plugin is not
> allowed. This change will also make the test
> WebViewPluginTest.TestLoadPluginInternalResource pass with the flag
> MimeHandlerViewInCrossProcessFrame.
>
> Note that when the plugin is not allowed, no (frame-based)
> MimeHandlerView will be created and the code will follow the ordinary
> CreatePlugin code path.
>
> Bug: 963694
> Change-Id: I91b88956480139ffdb0df06077d099746b713751
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622890
> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
> Reviewed-by: James MacLean <wjmaclean@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662641}

TBR=tommycli@chromium.org, thestig@chromium.org, wjmaclean@chromium.org

Bug: 963694, 949565
Change-Id: If3c2f33b4722f28e7ad35b91139cc73118e923dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626335Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663075}

This CL moves the enum that is needed for every action out of the
metrics helper and uses it to disambiguate footer commands more reliably
than the currently used title string.

It uses the enum wherever we know it's needed and extends it with the
missing options.

Bug: 902425, 905669, 962548
Change-Id: I6ae9ed561e3a85a483c7d7d3ffdd07a4cb125689
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626421
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663074}

We previously created a SkSurface for the sole purpose of allocating
a GrBackendTexture and keeping it alive. This was a minor misuse of
the Skia API. This CL uses a proper API that Skia just added.
It allows us to remove a workaround for Nexus 5X.

Change-Id: Icbd6c7a86914eab080b7673a87201ca4e0c55345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627631
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#663073}

Bug: 966336
Change-Id: I586a9f43fe2ef3956ba43af2197d634c1de189d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626595
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Pavel Shmakov <pshmakov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663072}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/aabc54e8..5d3500a1

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I929c7fdf099c7634f39699d08eddfc3c1389f562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626336Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663071}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ie4a1dd9c47e3d4371a603eb6752de67b6851c024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628119Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663070}

Changing OAuth2TokenService::Observer and its subclasses to use CoreAccountId instead of std::string

This cl is part of the effort to use CoreAccountId instead of std::string
to denote account_id.

Bug: 959157
Change-Id: I6b95b6adf7d73228c399162daf2867c532acd7cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626599Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@google.com>
Cr-Commit-Position: refs/heads/master@{#663069}

Due to https://crbug.com/965688 we need to dismiss the InfobarBanner
before presenting a new ViewController.

Most Coordinators present without checking if baseVC is already
presenting another VC (Even some where web is triggering the presentation,
like PassKitCoordinator).

Before this CL the VC's trying to be presented will NO-OP if a VC is already
presented.
This CL stops checking if baseVC is presenting so it lets BVC decide if it
should present or not (BVC will dismiss any InfobarBanner before presenting
any other VC).

This means that if an InfobarBanner is being presented
this will no longer NO-OP. It will dismiss the InfobarBanner first and then
present StoreKit or ARQuickLook.

In order to make sure that we don't re-present a ViewController again, the
properties are now weak so a failed presentation (meaning they are not part
of the view hierarchy) will set the ViewController property to nil.

StoreKitCoordinatorTest now uses a real UIViewController since
FakeUIViewController presentedViewController doesn't behave as a
UIViewController, meaning that if we present a VC on top of an already
presented VC the new VC gets presented, which shouldn't happen.


Bug: 911864
Change-Id: I15f8d5b4a7f866295fece58423fde8c59ec97e7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623497Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663068}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/54434e7e1dab..60c7eaa7fb0c


git log 54434e7e1dab..60c7eaa7fb0c --date=short --no-merges --format='%ad %ae %s'
2019-05-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@60c7eaa7fb0c

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I4755fcdaf23b6a863ab7c8e5f7bd03d194cf2985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628117Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663067}

On Linux/Chrome OS debug bots

TBR=harrisjay@chromium.org
TBR=benwells@chromium.org

Bug: 966834
Change-Id: I3244d6298c704d9afa755c090829f82c4f10cf4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628749
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663066}

This splits up omnibox_icon_formatter and omnibox_util so the important
pieces can be used in showcase. omnibox_icon_formatter needs
AutocompleteMatchType, which is in components. omnibox_util needs
security stuff from components code.

Now, showcase can directly use simple_omnibox_icon.

Bug: 965511
Change-Id: Ifdddc5dab36d34dd14fec8ed13f4f8c32c225731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622171Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#663065}

There is already code in the omnibox_mediator to load the default
search engine's favicon every time it changes or the consumer is set.
We also load this favicon every time the top suggestion is a search
suggestion. Caching the favicon would simplify all this loading.

Bug: 966771
Change-Id: Iaef03730b603cb1dff6af163f6ebcaa2d9c9fb1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628611Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#663064}

Change-Id: Ic6bb6ba4ac4caa6afb55739224d827caa3e72989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628715Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663063}

This reverts commit adc543fe.

Reason for revert: This change is not necessary anymore and it causes no shadows problem.
https://crbug.com/965433

Original change's description:
> Fix the flash for any new created window.
>
> The flash is because the child window created by GLSurfaceGLX doesn't
> match the visual of parent window. Fix the problem by always creating
> parent window with the same visual.
>
> Bug: 956061
> Change-Id: I88cb65b4a0313be6fdea1bd8d6770d351500ccbb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591946
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656497}

TBR=penghuang@chromium.org,piman@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 956061,965433
Change-Id: Ic5818e9d3d80cf646582db34dd14f02d7b5a713f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626340
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663062}

In order to better convey property object ownership,
changed WrapViewForPreferredSize() to take and return std::unique_ptr.

Bug: 961657
Change-Id: Ib06871c5bd0dcef357d160b8784f8541b839f59d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607707Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yeol Park <peary2@gmail.com>
Cr-Commit-Position: refs/heads/master@{#663061}

Before this patch, fuzz test for payment method manifest parser failed
because the command line data structure was not initialized. The command
line was being checked for the flag
--unsafely-treat-insecure-origin-as-secure=<origin> to validate URLs for
payment context.

This patch initializes the command line in the manifest parsing fuzz
test and adds class comments for the classes that require a command
line.

After this patch, fuzz test for payment method manifest does not fail
with the repro case reported in the bug.

Bug: 966694
Change-Id: I3544518468594a6903f713b026fba5bee217e295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628043
Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663060}

We already tested offscreen elements and elements hidden
(covered) by other elements but we lacked tests for:

|opacity: 0|
|visibility: hidden|
|display: none|

This CL adds testing for all three.

Note: crrev.com/659441 recently fixed the |opacity: 0|
case. The other two were already passing.

Bug: None (as crrev.com/659441)
Change-Id: Ia20e123c4f8b9e43b2ada9aef3ce0d9ac7f29aed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628612
Commit-Queue: Hugo Holgersson <hholgersson@fb.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#663059}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/111b91377eec..c308a3de9628


Created with:
  gclient setdep -r src-internal@c308a3de9628

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=yukishiino@google.com,lgrey@google.com,masonfreed@google.com,rsorokin@google.com

Change-Id: If82f8d3be67cb67c4b062857968fa072e55d3da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627639Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#663058}

From documentation on -[NSNotificationCenter addObserverForName:...]:
If you pass nil, the block is run synchronously on the posting thread.

Change-Id: Ib036764cb144d74750e9e1878d0cf7f239e25f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626390
Auto-Submit: John Wu <jzw@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663057}

--local-output prevents bug reports being generated when things go wrong
(annoying for local dev), and causes html report to be generated locally
(often not necessary, but sometimes useful)

Change-Id: Ib089f3a496569904df4ccc5486fbf0e5403e428d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627527Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663056}

On Linux CFI

TBR=takumif@chromium.org

Bug: 966827
Change-Id: Ib18260b9a2efb5b63dd671ef9a94d0e76418b42c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628713Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663055}

On Android CFI

TBR=kinuko@chromium.org

Bug: 966820
Change-Id: I2726d8e6e2a5c39ab683e682558b0198a1efbb1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628730Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663054}

Avoid false positives from DefinitelyNewFormattingContext().

If an OBJECT element ends up using its fallback content, we cannot claim
that it's going to establish a new formatting context, just by looking
at the element type. Then the OBJECT behaves just like any generic
element.

Always reporting that an OBJECT establishes a new formatting context,
allowed the parent to use LayoutNG, although the OBJECT had children
(e.g. a RUBY element) that require legacy layout. Letting NG and legacy
cooperate in the same block formatting context is something we don't
support.

Bug: 966363
Change-Id: Ica9247e9936eb1dbdfc8dabdc96cdb2afdad5bac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628711
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Auto-Submit: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663053}

With great power comes great responsibility.

R=rkaplow@chromium.org

Change-Id: I214f6eecf652d61eb62db903f341724be28ee1b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627037Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663052}

When we're not fragmenting, we shouldn't touch any of the fragmentation
related values in the container builder.

Added DCHECKs that would fail without this fix (and that will catch any
similar problems in the future at an earlier stage).

Bug: 966369
Change-Id: I8f6300435e211086fea8ea381912ad595e9a91ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628707
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663051}