• Noel Gordon's avatar
    [directorytree] Add a keyboard horizontal scroll test · 4acb3251
    Noel Gordon authored
    CL:1924341 limited the horizontal scroll of the directorytree to 0, to
    resolve issue 1025581, and needs a test of this behavior.
    
    Test: create a nested set of test folders, and use keyboard arrow-left
    (provided by expandSelectedFolderInTree, note) to navigate to the last
    of those folders. Post navigation, verify the navigation, and that the
    directory tree is not horizontally scrolled.
    
    This new test passes with CL:1924341, and fails before that CL (good).
    The CL used requestAnimationFrame (rAF) to limit the scroll. Add async
    test rAF helper and call it to ensure the scroll rAF is done, and that
    expandSelectedFolderInTree events have been processed.
    
    Test: browser_tests --gtest_filter="*TreeKeyboardHorizontalScroll*"
    Bug: 1025581
    Change-Id: Iff79b963559d282841f1d2045aadcee7e5840cea
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936579Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
    Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
    Reviewed-by: default avatarAlex Danilo <adanilo@chromium.org>
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#719411}
    4acb3251
file_manager_browsertest.cc 35.7 KB