GitLab

CL:1924341 limited the horizontal scroll of the directorytree to 0, to
resolve issue 1025581, and needs a test of this behavior.

Test: create a nested set of test folders, and use keyboard arrow-left
(provided by expandSelectedFolderInTree, note) to navigate to the last
of those folders. Post navigation, verify the navigation, and that the
directory tree is not horizontally scrolled.

This new test passes with CL:1924341, and fails before that CL (good).
The CL used requestAnimationFrame (rAF) to limit the scroll. Add async
test rAF helper and call it to ensure the scroll rAF is done, and that
expandSelectedFolderInTree events have been processed.

Test: browser_tests --gtest_filter="*TreeKeyboardHorizontalScroll*"
Bug: 1025581
Change-Id: Iff79b963559d282841f1d2045aadcee7e5840cea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936579Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719411}

Currently base::ReplaceChars() accepts std::string for the 3rd
parameter, and immediately converts it to base::StringPiece.

To avoid string copies on the caller side, it should accept
base::StringPiece instead.

This change became possible after r504430.

BUG=760330
TEST=base_unittests --gtest_filter=StringUtilTest.ReplaceChars

Change-Id: I9a3a4cc02cfbfb8c8a258dc077612dd5146b9592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930799
Auto-Submit: Andrei Polushin <anpol@yandex-team.ru>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719410}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0f1fce1f..f1c7d33e

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia075ef59363e2e993415199109e0953772976764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937251Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#719409}

https://webrtc.googlesource.com/src.git/+log/44d7ec06830e..7a9a092708f1

git log 44d7ec06830e..7a9a092708f1 --date=short --first-parent --format='%ad %ae %s'
2019-11-26 mellem@webrtc.org Delete media transport integration.
2019-11-26 saza@webrtc.org Fix fuzzer-found bug in fuzzer

Created with:
  gclient setdep -r src/third_party/webrtc@7a9a092708f1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1028614
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I6f34bbebe369ce18678cd82740ec7bd8ef8b8abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937689Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#719408}

Bug: 1007632
Change-Id: Ic571ca1cb670e8387ff64b3e6f84aee3f6679a4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931152
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719407}

Except on Fuchsia (https://crbug.com/1028723) and macOS
(testing/libfuzzer/fuzzers/mach/mach_message_converter.cc) for now.

Bug: 999871
Change-Id: Iad97504432c293c880698cb28d0efb6c3611bbe7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937650
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719406}

The .json files are generated by using the following command:
src/tools/perf$ ./generate_perf_sharding update --builders android-pixel2_weblayer-perf


Bug: 965158, 1026327
Change-Id: I45eee6660b225e298def222135b1ad41af435ff5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935752
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719405}

Change-Id: I81afd25f1124dd18da8e406bb46156ffccfbd616
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937864
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Auto-Submit: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719404}

This CL adds cancel() method to hit test sources. Details can be found
here:
https://github.com/immersive-web/hit-test/blob/master/hit-testing-explainer.md#unsubscribing-from-hit-test

Change-Id: Ia988497ebb26b4c5b76f71de323398593b883b5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937140
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719403}

This patch splits the SkipToGPay experiment into two phases that can be
tested separately per request from early partners:

1) kSkipToGPayIfNoCard: enables skip-to-GPay if and only if user doesn't
   have a usable autofill instrument.
2) kSkipToGPay: enables skip-to-GPay regardless of availability of
   autofill instruments in the user's profile.

Part (1) required an extra lookup from the PersonalDataManager before
dispatching payment app creation. Manual profiling on a Nexus 5 showed
that this added 0.3-19ms extra main thread processing, with average
around 3ms for profiles that contain at least one credit card. This is a
relatively small performance penalty.

Bug: 877284
Change-Id: If465bb1fe0c1f79979cc3743af5474662bd6dd68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936107Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719402}

This reverts commit ec3649f6.

Reason for revert: attempt to re-land the original change while maintaining protocol copy where devtools-frontend expects to find it.

TBR=dgozman@chromium.org,tapted@chromium.org,caseq@chromium.org,pfeldman@chromium.org,jochen@chromium.org

Original change's description:
> Revert "Move browser_protocol.pdl to third_party/blink/public/devtools_protocol"
>
> This reverts commit 3e9d66eb.
>
> Reason for revert: Widespread bot failures for Step "isolate tests"
>
> error like:
>
> isolate: isolate /b/s/w/ir/cache/builder/src/out/Release/devtools_type_check.isolate: partitioning deps: lstat /b/s/w/ir/cache/builder/src/third_party/blink/renderer/core/inspector/browser_protocol.pdl: no such file or directory
>
> Bug: 1028446
>
> Original change's description:
> > Move browser_protocol.pdl to third_party/blink/public/devtools_protocol
> >
> > Bug: 1018108
> >
> > This still retains a copy of protocol.json for compatibility with
> > devtools front_end.
> > Also, remove a presubmit for front-end compilation upon a change to PDL
> > since the front-end is in another repository now.
> >
> > Change-Id: I2faea62feca80776d2fc0a0b4ea00a90439ae005
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898538
> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#718903}
>
> TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org,jochen@chromium.org
>
> Change-Id: I39435e4be7dde62ffd48d1f72a0ecbbac9165ae1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1018108
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935479
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Commit-Queue: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718977}

Change-Id: Iae5bdbd809cea60fe566b1ebf160836982c4cfcd
Bug: 1028446, 1018108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937860
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719401}

During local development it's possible for these tests to fail due to
reaching the timout limits for polling that the error state has been
reached. This bumps up the timeout to ensure that the tests can pass in
local development environments as well as the waterfall.

Bug: 1028777
Change-Id: Iaf6d93295cfe044046ef989710f0894ee8e6b850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938031
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719400}

GPU compositing is never specifically blacklisted in
software_rendering_list.json, only when all are disabled, so remove it,
and add GPU_FEATURE_TYPE_GL. Use this as a proxy for GPU compositing for
now. This will need to be fixed to support the case where GL is
blacklisted, but Vulkan is still enabled.

Bug: 1005383
Change-Id: I0330021cfa59c6c4cf2719785f7931e53ec50f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917753
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719399}

Currently, we opened suggestions in a background tab when holding the
super (Linux) or command (Mac) keys and pressing enter. The code implies
pressing the window key and pressing enter should behave likewise on
Windows; but this didn't work because key presses aren't propagated when
the window key is held down.

With this CL, holding alt+shift and pressing enter behaves similarly.
This
1) brings feature parity to Windows, and
2) is symmetric to alt+enter which opens the suggestion in a new
foreground tab.

Bug: 898277
Change-Id: Ia6423435e9a3c9de81746ceda266803cad18704c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937687
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719398}

From Pinpoint, end user can launch a job by selecting a benchmark together
with a story or a story tag. Though, there's no way to run all stories of
a benchmark. The reason behind this is that Pinpoint does not have enough
devices so it wants to limit the duration of each job. However, some
benchmarks are small and it won't be a big load even running all of their
stories.

Per Blink team's request, this CL adds "all" tag to two of its benchmarks:
blink_perf.layout
blink_perf.paint


Bug: 1023451
Change-Id: I8754a40a283564677562bb0594dea07a8ba25d9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929757
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719397}

Adds new APIs to web_idl.FunctionLike:
  overload_group
  overload_index
Accordingly, set_overload_group is added with guards against abuse.

In order to avoid circular imports, OverloadGroup is moved into
function_like.py with only change in OverloadGroup.__init__.

Bug: 839389
Change-Id: I8cf6b8550596d939eda1acc162959012e1d26b93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936691Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719396}

All implementations of ExtensionHostDelegate::GetExtensionHostQueue()
returned a singleton instance of an ExtensionHostQueue. Instead of this
piping, introduce ExtensionHostQueue::GetInstance(), which does the same
thing without needing to be implemented by the embedder.

TBR=atwilson@chromium.org (trivial background_contents.cc change)

Bug: 1028334
Change-Id: I339267c2a8193c27bd782b63a8f8cc5e15957be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935489
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719395}

This CL makes SkiaOutputDeviceBufferQueue work with Vulkan.
It creates GLSurfaceEGLSurfaceControl for
SkiaOutputDeviceBufferQueue. So SkiaOutputDeviceBufferQueue
and SkiaOutputSurfaceImplOnGPU can use this GLSurface to
present the SharedImage (AHardwareBuffer) as an overlay.

TODO:
* Refactor GL unrelated code out of GLSurfaceEGLSurfaceControl,
so we can used them for both GL and vulkan.
* Remove GL dependencies from SkiaOutputDeviceBufferQueue

Bug: 1012401
Change-Id: Ic58e82d9f3cde86ac1601dc4f330a4309bff6178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931376Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719394}

Disable the test on Mac and ChromeOS

Bug: 1028765
Tbr: kolos@chromium.org
Change-Id: Ic5a0f3ae6e20fea7dc507ce2d890a374eee53cbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937776Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719393}

https://chromium-review.googlesource.com/c/catapult/+/1896356
changed the default so that now you need to pass in
--run-abridged-story-set or else the full story set will run.

Bug: 965158
Change-Id: I4453359f2bea160200c47befd118894d239a4634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935787
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719392}

This was causing problems with the QA testing, since many sites open new
tabs for signin pages, etc.

Bug: 1028695
Change-Id: I14a3f1ca644e5a0dfd0efad9ef3070de093804bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937865Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719391}

Fix some of the more trivial presubmit warnings and  errors in the
preferences package. This will reduce the number of failures we'll need
to bypass in the upcoming package renaming.

Bug: 1027271
Change-Id: I5bda8192c91158d281f214a4d91e907f058a24d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935716Reviewed-by: Gang Wu <gangwu@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719390}

The "Added Symbols named -ForTest" check is no longer disabled.

Change-Id: I3b42550f138de7146627591b5dc4b48d2406e2e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937861
Auto-Submit: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719389}

Implemented common mechanism for targeting animation events initiated by animations and
worklet animations. Changes made:

- AnimationHost::SetAnimationEvents consults animation timeline to find a target animation.
- Moved animation events routing logic from cc:ElementAnimations to cc:Animation.
- Directly route to the target keyframe model using keyframe id and model id instead of using
  element id and group id to identify the target keyframe model.

Bug: 1013727
Change-Id: I28613b0e708258e6433a45e828710caa3e73e280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872486
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719388}

This is a reland of 507f4ee8

It seems like CL:1935027 caused the failures and the revert. Once this change
relands with a fix (CL:1935212), I'll reland this one.

Original change's description:
> Do not return InlineTextBox nodes from UIA GetEnclosingElement
>
> In AXPlatformNodeTextRangeProviderWin, nodes with role kInlineTextBox
> should never be exposed to UIA. This CL introduces a simple fix.
>
> In GetEnclosingElement(), if the enclosing node is an inline text box,
> we simply return its parent. I also updated a unit test for this case.
>
> Bug: 928948
> Change-Id: I31a31566461c3091bed36ebad626c4f51afc55a3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931753
> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#718920}

Bug: 928948
Change-Id: I6dbac3eae0a17d29f13c3d6b75532018729782de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937134Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#719387}

Change-Id: Ifea3556a96b99f27a13c6ba0b3785d4ddefe28a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937351
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719386}

Chromium's GN rules generator previous generated GN targets with names
based on the last part of FIDL library names. This could lead to target
name clashes, so switch to using fully-qualified target names.

To allow soft migration of [public_]deps targets are also emitted for
most of the old names, for now.

Bug: fuchsia:42135
Change-Id: Ic63f423bbe934ff346fda625eff1b060450f573b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937767
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719385}

Bug: 1013389
Change-Id: I71e8a014660b6144c7f8a13c11bb6e692e331487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937856
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719384}

The ExtensionSpeed field trial was used to introduce a delay between
extension host starts (to reduce jank). This field trial has been
expired for some time. Remove its usage from the code.

Bug: 1028334, 477445
Change-Id: I963c0fa9236b86a4fd8c6c6d90296c9b00d8a360
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937347
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719383}

This CL cleans up old Mojo types for CompositorFrameSinkClient and
CompositorFrameSink from SynchronousLayerTreeFrameSink and uses
PendingReceiver, Receiver, and PendingRemote instead of them.

Bug: 955171
Change-Id: Id0aa5d5dc2409a1de878764514b599a12dcce46b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935973Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#719382}

This CL cleans up old mojo types for blink::mojom::AecDumpManager
using PendingReceiver instead of InterfaceRequest.

Bug: 955171
Change-Id: I62a57912cf87ffc41c16c153c7ecf353378cfbc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935275Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#719381}

* Separate feature related logic so that Duet and Adaptive toolbar can
  be enabled when flags of TabGroup and Duet-TabStrip integration are
  both on.
* Modify the logic in ToolbarManager so that this CL should be no-op
  when new flag is off and expose integration functionality when new
  flag and duet are both turned on.
* Setup up the basic structure of TabGroupPopUi component and
  specify the entry point and dependencies.

TBR=mdjones@chromium.org

Bug: 1022827
Change-Id: I6e99ec73b5603688c40dc884f8dbdc450961bf6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935490Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719380}

Add 3 use counters to track the following usages
1) Different Agent Clusters
2) Same Agent Clusters
3) Same Origin

Adds counters for https://github.com/whatwg/html/issues/4920

Change-Id: Ia9aeb1afb1f355790c5dfb549f1e2459d95d98ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925218
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719379}

If the build configurations supports stripping of absolute paths from debug
symbols by default, then it cannot be disabled. If it's causing problems, then
the user should file a bug.

This was prompted by this discussion thread:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/kE1HeGL4mj0/w_E5OCRLAwAJ

where a user disabled the configuration when the real problem was that they were
using Xcode 10.1, which had a bug that was fixed in Xcode 10.3.

Change-Id: I87598a84bf0c16d777114774656fc9b0b06999ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898778
Commit-Queue: Erik Chen <erikchen@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719378}

Each of the test suites modified had a per-shard runtime of more than 10
minutes. This CL updates all of them to have expected runtimes of 10 minutes,
while still keeping overhead below 10%.

Timings come from:
https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/430164

Pre-patch runtimes, timings from
https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/430164
interactive_ui_tests [31 minutes, 35 second overhead]
content_browsertests [24 minutes, 35 second overhead]
cc_unittests [21 minutes, 13 second overhead]
components_unittests [17 minutes, 41 second overhead]
webkit_unit_tests [17 minutes, 22 second overhead]


Bug: 1028289
Change-Id: I3254bdb3f26e07a5eec77da4633cd6e0ea1d8311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937574
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719377}

https://chromium.googlesource.com/angle/angle.git/+log/5b2740c57090..88752889c721

git log 5b2740c57090..88752889c721 --date=short --first-parent --format='%ad %ae %s'
2019-11-26 syoussefi@chromium.org Vulkan: Fix barriers w.r.t sampled->storage image update

Created with:
  gclient setdep -r src/third_party/angle@88752889c721

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I5e35454f74446c6be9157c54fc18775418f99731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937869Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#719376}

Bug: 1028095

Change-Id: I6ca136c360e3ad62a171445f2a8e256b248a4d77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937327
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719375}

A null site_for_cookies means the containing frame is already cross-site, not that
it's top-level. (And it's impossible to see from it whether it's same-site with
a resource --- for purposes of cookies everything below is third-party)

Also simplify the function to not distinguish 5 cases when it's only used
to tell 2 apart.

Bug: 1006328
Change-Id: I41d46e990fe9afe78ba502a76b85621dce74d8b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932088Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719374}

Adds the infrastructure to support a dynamic feature module for Android
stack unwinding. This module will provide the native code implementation
of a stack unwinder supporting unwinding of stack frames corresponding
to native system libraries and Java code.

This CL contains just the infrastructure to set up the DFM, which
is derived from the existing 'test dummy' DFM. The stack unwinder
implementation and the use of the module from Chrome code are deferred
to later CLs.

Bug: 1027654
Change-Id: I4b5dca1294fa1aa8197eab4544a03dd7d5bc48a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934774
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719373}

This change converts the remaining instances of base::Bind,
base::Closure and base::Callback to explicitly choose between
call-once and call-repeating semantics.

Bug: 1007633
Change-Id: Id3636e2f3af003fdf705ba339db8173d27714eb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937913
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719372}