GitLab

This also disambiguates the Active, Open, and Pinned states from their -ness suffixed equivalents. The -ness versions are floats that are animation-specific -- TabAnimationState keeps track of the tweened values between 0 and 1. Most implementations only need to care about the binary non-suffixed versions.

For now this is just a find-and-replace and does not change any boolean APIs (e.g. https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_strip.cc?l=982,1004-1005&rcl=1ad5374935374da746af65d05b41104c711fd5cc). There are many examples in tab_strip.cc where ternary operators could be removed if a boolean were converted into enum values. That is next on the list of refactors.

Bug: 966627
Change-Id: Icc2a0aaea0a06186d0bd3fefda645e97252968cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764419
Commit-Queue: Connie Wan <connily@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692182}