GitLab

This also disambiguates the Active, Open, and Pinned states from their -ness suffixed equivalents. The -ness versions are floats that are animation-specific -- TabAnimationState keeps track of the tweened values between 0 and 1. Most implementations only need to care about the binary non-suffixed versions.

For now this is just a find-and-replace and does not change any boolean APIs (e.g. https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_strip.cc?l=982,1004-1005&rcl=1ad5374935374da746af65d05b41104c711fd5cc). There are many examples in tab_strip.cc where ternary operators could be removed if a boolean were converted into enum values. That is next on the list of refactors.

Bug: 966627
Change-Id: Icc2a0aaea0a06186d0bd3fefda645e97252968cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764419
Commit-Queue: Connie Wan <connily@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692182}

This is part of phase 1.11 on the design document [1].

[1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/

Since there are clients in //content directly referencing to this class,
it was temporarily placed in blink/public/platform.

BUG=787254
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I1b5db2b166f8b698701a8bfa31282f940ee46c4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778006
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692181}

This is part of phase 1.9 on the design document [1].

[1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/

Since there are clients in //content directly referencing to this class,
it was temporarily placed in blink/public/platform.

Also, once its clients get moved to Blink, and so this API, it can
switch over from STL types (std::string and vector) to its WTF
counterparts. TODO is left.

BUG=787254
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I3519318d5ae6f5b3641442f78d5e6116801dbbe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778005
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692180}

TargetAutoAttacher::UpdatePortals currently adds all inner WebContents
including guest views. When devtools closes, SetAutoAttach clears
|auto_attached_hosts_| of any portals, but leaves any guest views which
leads to the failed DCHECK that all auto attached hosts have been
removed.

Now in UpdatePortals, we check that the inner contents is a portal
before adding it.

Bug: 961113
Change-Id: I758b3818c3f390f47c4020d88094387ee85d07e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777022Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692179}

This reverts commit ba5eedd3.

Reason for revert: <Did no fix the issues.

Original change's description:
> Revert "devtools: Prepare for service worker UI thread core."
> 
> This reverts commit b9e16d2b.
> 
> Reason for revert: Speculative revert for
> 
> Unexpected Failures:
> * http/tests/devtools/a11y-axe-core/elements/event-listeners-a11y-test.js
> * http/tests/devtools/a11y-axe-core/security/security-origin-a11y-test.js
> * http/tests/devtools/a11y-axe-core/sources/sources-editor-pane-a11y-test.js
> 
> See builds
> https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/3809
> to
> https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/3842
> 
> Original change's description:
> > devtools: Prepare for service worker UI thread core.
> > 
> > The thread ServiceWorkerContextCore lives on (the "core thread") will move from
> > the IO thread to the UI thread when the ServiceWorkerOnUI feature is enabled.
> > 
> > This CL makes DevTools aware of the core thread instead of assuming the IO
> > thread. This makes https/tests/devtools web_tests pass when the feature is
> > enabled.
> > 
> > Bug: 824858
> > Change-Id: I20e38f50998f4b0cd9d8b8cc43526665d92dbf94
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775655
> > Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#691689}
> 
> TBR=falken@chromium.org,caseq@chromium.org
> 
> Change-Id: I2d49a0fe27f033a7b8bd74e3a50fd9d78a4f1f58
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 824858
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778403
> Reviewed-by: sebsg <sebsg@chromium.org>
> Commit-Queue: sebsg <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#692059}

TBR=falken@chromium.org,caseq@chromium.org,sebsg@chromium.org

Change-Id: I05e78908c372fd01350bd16eca9d45bb5095c152
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 824858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779069Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692178}

This is much more necessary with the view repaint optimization enabled
via the EnableViewPaintOptimization feature. Without that optimization,
the BubbleFrameView was getting repainted by accident: usually a
control in the bubble would change in response to a theme change, and
that would damage the BubbleFrameView's bounds rect, which would cause
a repaint of the BubbleFrameView.

Bug: 999208
Change-Id: Ia71d5e7474a00971502a87dcc2d9cea7c4368853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774787
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692177}

When SplitSettings is enabled the route to APPEARANCE doesn't exist,
so clicking the link throws an error. Instead, open the browser setting
in a new browser tab.

Test: Open OS settings > Advanced > Accessibility > Manage
accessibility features, click "Open appearance settings"

Bug: 999354
Change-Id: Ibb1e42dccfef72a42779c330ba189061e398da4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778815Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692176}

This is necessitated by Navigation not having const functions. It would be
nice for Navigation to have const functions, but that isn't possible because
we generally don't have const functions in content.

BUG=none
TEST=none

Change-Id: I57f7385730e0eca623d8762512fff8403699c779
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779002Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692175}

This CL disable
ClearBrowsingDataPreferencesTest#testImportantSitesDialogNoFiltering
on O+ builders.

TBR=dullweber@chromium.org

Bug: 999361
Change-Id: I9d40b6f4013f310664f4726349298d63fb2b42bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779004Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692174}

This is phase 1.10 on the design document [1].

[1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/

BUG=787254
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ibe985afbdd84f4e191cf49457cd5232d9796b7f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778003Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#692173}

When we add default tick duration of two-frame time, we see some tests
memory leak which may end the tests when the page is still active, so
I add promise to each tests, once the actions are all finished, we will
call the test end in the promise callback.

Bug: 606367
Change-Id: I679e7b066087b1a6ba68f79fccf9d5432e1f873c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774713Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692172}

Fix bug on Android O in which the view was changed not on the UI thread.
Tested on API levels 26 and 27.

Bug: 999360
Change-Id: I4bd7a335013262337140e9595e24b9d114ea3e3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778490
Commit-Queue: Andrei Chulkov <achulkov@google.com>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692171}

FidoReturnCode is a unified namespace for any higher-level status of a
FidoRequestHandler. This was somewhat convient because security key
operations share certain failure modes (e.g. kSuccess,
kInvalidAuthenticatorResponse or kSoftPINBlock). On the other hand, it
meant that users of each FidoRequestHandler needed to implicitly know
which subset of FidoReturnCode was applicable to the particular
subclass.

This change replaces FidoReturnCode with separate status enums for each
request handler. This gets us better type safety and smaller
"switch(status) { ... }" blocks at the expense of having to duplicate
the few common status values across request handlers.

Bug: 876109

Change-Id: Ic0f5bfc08d6c2d4186bf4e2ca9bf99edf0bf6c87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774825
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692170}

media router benchmark now lives in https://cs.chromium.org/chromium/src/tools/perf/contrib/media_router_benchmarks/

R=cliffordcheng@chromium.org, perezju@chromium.org

Bug: 921000
Change-Id: If0a93cdfcfa41539b3828d2eee6cbb4719111eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779163Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692169}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Iaa7bb37749e3f4ce3b88b443ca48314a6192087f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779095Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692168}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ab1d1a8d60dd..34facef63327

git log ab1d1a8d60dd..34facef63327 --date=short --no-merges --format='%ad %ae %s'
2019-08-30 chrome-bot@chromium.org Update config settings by config-updater.

Created with:
  gclient setdep -r src/third_party/chromite@34facef63327

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Idd4c097cb7d08c600da0d2dc595f22e31261ddb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778645Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692167}

Add a tab model observer so that when tab is added due to multi-window
close or moving between multiple windows, force hiding the selection
editor.

Bug: 994647
Change-Id: If540754bf89c9d7b9d231058fabbfa11260e8b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757294
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692166}

This reverts commit 7296d844.

Reason for revert: <Crashes caused by this CL has been fixed>

Original change's description:
> Revert "Enable GpuWatchdogV2 in Field trial testing for all platforms"
> 
> This reverts commit 752f7f2c.
> 
> Reason for revert: <Watchdog V2 causes crashes in the bots and it falls back to SwiftShader. bug 995372>
> 
> Original change's description:
> > Enable GpuWatchdogV2 in Field trial testing for all platforms
> > 
> > Bug: 949839
> > Change-Id: I5939069144719c501209af3cda3b7693f61f8866
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682315
> > Commit-Queue: Maggie Chen <magchen@chromium.org>
> > Reviewed-by: Ilya Sherman <isherman@chromium.org>
> > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#688375}
> 
> TBR=isherman@chromium.org,zmo@chromium.org,magchen@chromium.org
> 
> Change-Id: I2f64da411b2289265c1a9657fae85c083953bfb8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 949839
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761559
> Reviewed-by: Maggie Chen <magchen@chromium.org>
> Commit-Queue: Maggie Chen <magchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#688690}

TBR=isherman@chromium.org,zmo@chromium.org,magchen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 949839
Change-Id: Ib92ed2d060f278ca9c53e78edf06822cbb2f487a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779222Reviewed-by: Maggie Chen <magchen@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692165}

See https://docs.google.com/document/d/1DFKZsXCU4GySB9Ry8Bhd8k8sB7pO5wOz0GBcFmAq5B4/edit#heading=h.ekjb61oacmwf
for the colors of kProminentIconButton.

Bug: 982950
Change-Id: I921c053c2fcd5c6a30dcf26acc995ce060a90e67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775499Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692164}

Screen context setting state is not being synced during Assistant pref
registration which is causing any screen context related features to
fail until the user explicitly goes to settings and toggles the setting
off and back on again.

Bug: b:138679823
Change-Id: Idbdc300282caf731487480b8bbc28397c9a8606b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777066Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#692163}

Bug: 954508
Change-Id: Ie26ef9d68247828d2b2a4c9088ae03da856270d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778592Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692162}

ProcessAlternativeServices which is used by HttpStreamFactory
and SpdySession.

Change-Id: I3df00e4ec0bc1b55015e7ba0e1d9af913d7b161b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776735
Auto-Submit: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692161}

blink::TransferableMessage was failing to build, as it had its move operator and
assignment operators set as noexcept, but their default implementation depended
on mojo::UserActivationSnapshotPtr to have noexcept too. This missed it
because its type was mojom::InlinedStructPtr, that was missing noexcept.

Bug: 819294
Change-Id: I0aaaf179a9f5240c4706cca5128568df45c0de25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768516Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#692160}

This change adds byte (as opposed to std::string) based functions to
save callers some copies and casts.

Change-Id: Ib3306c6abf14c8ff849009e1752284bc693da44a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776793
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692159}

Convert both the implementation and clients in the browser and renderer
processes for the blink.mojom.IDBCallbacks interface, and
adapt unit tests.

Bug: 955171, 978694
Change-Id: I14aa9ac688dc657b7303b5c04ad50c98e92eda31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774440
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692158}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ee8d9ce83d7c..17016be940ad

git log ee8d9ce83d7c..17016be940ad --date=short --no-merges --format='%ad %ae %s'
2019-08-30 maruel@chromium.org README.git-cl.md: Remove reference to Rietveld

Created with:
  gclient setdep -r src/third_party/depot_tools@17016be940ad

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:770408
Change-Id: Ic3d241d53f363f0df8ec91095f2899a969b31851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779088Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692157}

Autogenerate Polymer 3 version of cr-drawer, as well as tests for the
Polymer 3 version. Update the demo page to include a drawer.

Bug: 965770
Change-Id: I6df30fdcbe819a94ad1745425619e8df7a5d1b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776610
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692156}

This CL changes the behavior of cancel() as a no-op because the request
cannot be cancelled once sent to gmscore since gmscore does not support
request cancellation yet.

Bug: 999095
Change-Id: I8d6172386191534855ddbd374555c13e088b2561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777050Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Suzy Li <suzyli@google.com>
Cr-Commit-Position: refs/heads/master@{#692155}

Bug: 993611
Change-Id: I58a9e4ed71bdbd29663f24942f6e00bfe5068532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764565
Auto-Submit: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692154}

- Autogenerate Polymer 3 version of cr-radio-group
- Add to the Polymer 3 demo page
- Add an autogenerated JS module version of event tracker, since this is
used by cr-radio-group
- Autogenerate cr-radio-group v3 automated test.

Bug: 965770
Change-Id: I41034878bb76a769da0c10b37fcf8a698a8f421d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775582
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692153}

This is in our style guide, but not enforced:
https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md#curly-braces

Still allowed:
if (someConditional) return false;
for (int i = 0; i < 10; ++i) callThing(i);

Now prohibited:
if (someConditional)
  return false;

Bug: 999554
Change-Id: I58906bace6dd9aa3754cf7a9503d6c8703764a91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778809Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692152}

When the WebAuthenticationPhoneSupport feature is enabled, a random key
is generated by |AuthenticatorCommon| and fed into the discovery factory
and into the UI. This allows caBLE to be used without an extension.

Change-Id: I30e07a7dc21ef44a7cb8c6b9d63068faeffab64d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776792Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692151}

In the past we wanted to separate IPC stuff from other parts and that's
why WebSocketHandle[Impl] was created, but with mojo we don't need the
separation.

Bug: 977912
Change-Id: I35dd04c17ef4df8e0122ac0490696c255b5c1192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773010
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692150}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cc61f5424733..d70702fad6d1


Created with:
  gclient setdep -r src-internal@d70702fad6d1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I04d11fc1ae812662a41e184bfa1d49b543a472b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779086Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692149}

This is the first CL for clean-up the old parser.

Bug: 949519

Change-Id: I962a4f7c437fc42b761612de1289e2dec43c17e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768457
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692148}

This CL has no behavior changes.

Bug: 972476
Change-Id: I0c42df15da53b361602e64ae6891ee9c45a9ab9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777448
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692147}

Two fixes:
1) Move static getters to a separate LibraryLoaderConfig.java
   * Required because of the non-trivial class initializer in
     LibraryLoader preventing inlining.
2) Change JNI proguard rules to not -keep natives when the linker
   is not used.

TBR=agrieve  # Renames

Change-Id: I0f4a40af6168cbe7243f462c24d230d277e642ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703155
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692146}

Roll ChromeOS orderfile from 78-3865.18-1566209693-benchmark-78.0.3888.0-r1 to 78-3877.0-1566814872-benchmark-78.0.3893.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_EXTRA_TRYBOTS=
TBR=c-compiler-chrome@google.com

Change-Id: I0edb8963b3737db6db270b5f17bb27aa19601b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778644Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#692145}

DCHECK in OverviewGrid::AddDropTargetForDraggingFromOverview can be hit
if long-press two items at the same time with different fingers. One
test was flaky on mash.

Test: none
Bug: 941048
Change-Id: I6a1f1884ecec53714d915cf4a671c621c18d7793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776592
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692144}

Bug: 552274
Change-Id: Ieaef52c738965861b31fde06ee9b2d5c9a95f967
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777120Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692143}