• Darren Shen's avatar
    login: Revert account switching on focus in lock screen. · 550642a7
    Darren Shen authored
    In https://codereview.chromium.org/2035753003, we started switching the
    user account as soon as the user focused on a user pod in the lock
    screen. This was to update parts of the "shelf user icon" based on
    the focused user pod.
    
    However, this has unintended consequences. When the screen is locked,
    the system is in a special "locked" state. Switching the active user
    assumes we're in interactive user session state, so it breaks this
    assumption system wide.
    
    One unintended consequence is on IMEs: The lock screen code assumes
    that active user can only change after auth success, and uses this
    assumption for managing the user's IME state.
    
    This causes the IME state to be incorrectly restored in some cases,
    which breaks keyboard typing for some users, breaks the virtual
    keyboard, and shows an incorrect list of IMEs in the shelf.
    
    We revert this change as it may have consequences for not just IMEs.
    We need to implement this feature in a different way (without
    switching the active user).
    
    Bug: 911699, 942392, 980792, b:143235444, b:143906227, 614926
    Change-Id: I0691256ecad20c683003004d99469692b4e4ac8e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904558
    Commit-Queue: Darren Shen <shend@chromium.org>
    Reviewed-by: default avatarAlexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#713697}
    550642a7
views_screen_locker.cc 13.9 KB