- 08 Nov, 2019 27 commits
-
-
Darren Shen authored
In https://codereview.chromium.org/2035753003, we started switching the user account as soon as the user focused on a user pod in the lock screen. This was to update parts of the "shelf user icon" based on the focused user pod. However, this has unintended consequences. When the screen is locked, the system is in a special "locked" state. Switching the active user assumes we're in interactive user session state, so it breaks this assumption system wide. One unintended consequence is on IMEs: The lock screen code assumes that active user can only change after auth success, and uses this assumption for managing the user's IME state. This causes the IME state to be incorrectly restored in some cases, which breaks keyboard typing for some users, breaks the virtual keyboard, and shows an incorrect list of IMEs in the shelf. We revert this change as it may have consequences for not just IMEs. We need to implement this feature in a different way (without switching the active user). Bug: 911699, 942392, 980792, b:143235444, b:143906227, 614926 Change-Id: I0691256ecad20c683003004d99469692b4e4ac8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904558 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#713697}
-
Kouhei Ueno authored
Bug: 981740 Change-Id: Iade267628067ecc39dcc84be6b721b59eddb9db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903241Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#713696}
-
Dana Fried authored
We'll need these when we do our "webby UI" exploration, which has been put on hold temporarily but will resume in a month or so. Bug: 1021148 Change-Id: I3e4bb2244ad2fee46f698520ed7827e7f0259991 Fixes: 1021148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900133 Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#713695}
-
Tim Song authored
The CollapseState indicates whether the tray is collapsed or expanded or not collapsable (default behaviour) at all. Currently, the status area will only be collapsable in tablet mode and in-app. The visibility logic for individual tray items is also being cleaned up in this CL, as this logic is fairly complex. We rename SetVisible() to SetVisiblePreferred() because the effective visibility also depends on factors such as the virtual keyboard and status area collapse state. Future CLs will properly update the CollapseState as well as calculate which tray items should be visible when collapsed. TEST=unit tests BUG=982511 Change-Id: I6f6fed7836d0b1dc4991319fb4ec8e58a522da37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903399 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#713694}
-
Alex Cooper authored
This change removes the infrastructure around the WebVr displayactivate events, including XRRuntimeEventListener methods and XRRuntime's SetListeningForActivate for notifications to the browser process. This also remvoes the VRDisplayClient, and some compatibility methods on the VRService. Future work will remove GetImmersiveVRDisplayInfo, which should be the last remaining WebVr-only method in the mojom files. Bug: 1017872 Change-Id: Ic149384917a25d6db4fceef35091f28350025f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898506Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#713693}
-
Xiyuan Xia authored
This reverts commit ddbd49f9. Reason for revert: CL:1879255 is causing the flakiness and is reverted (CL:1904504). Revert this CL to re-enable the tests. Original change's description: > Disable flaky TaskManagerBrowserTest.NoticeHostedAppTab*Reload on Linux. > > TBR=afakhry@chromium.org > > Bug: 1021553 > Change-Id: I6d6170beb77d08da192d24e7ebb7246a83926a7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899334 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712622} TBR=waffles@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1021553 Change-Id: I1fe435871e401d46cff04c1e16604214e3d2ea43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904215Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713692}
-
Anand K. Mistry authored
Also convert usages of Bind -> Bind{Once,Repeating}. Bug: 1007814 Change-Id: I205f9a8ff20900eb42e8b2225a1ca3fb49a4a989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902178 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#713691}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a942a9f9a235..26c5a8d1e381 git log a942a9f9a235..26c5a8d1e381 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 achuith@chromium.org OWNERS: Add chromeos ui folks to chrome_ files. Created with: gclient setdep -r src/third_party/chromite@26c5a8d1e381 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6352481284ca566c618426b0b6e2d5b24013cf00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713690}
-
Adam Langley authored
After doing real-world testing against SIKE[1], re-add the feature flag purely to enable CECPQ2, in the hopes of reaching Stable with it. [1] https://www.imperialviolet.org/2019/10/30/pqsivssl.html Bug: 930812 Change-Id: I4b05b5b1eff7288269640496735ae81168920f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904754 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#713689}
-
Wez authored
https://chromium-review.googlesource.com/c/chromium/src/+/1895745 migrated the GPU process' surface to be embedded as a child View, setting ViewProperties on it to prevent it receiving focus. Because the ViewProperties had no bounding_box set this prevented the GPU surface View from actually being displayed. Bug: fuchsia:29945, 974826, 1022586 Change-Id: Iba93746719751911d645f067ad52e7b9bb8b661d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904557 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#713688}
-
Kenneth Russell authored
In certain situations upon switching between the integrated and discrete GPUs on dual-GPU MacBook Pros, the WebGL context has to be lost and restored because its contents can not be preserved: - If the user allocated multisampled renderbuffers using the WebGL 2.0 API. - If preserveDrawingBuffer:true and antialias:true are both specified. To implement this, notify client code which GPU is active after the switch, by sending the existing gl::GpuPreference enum via both GPU IPC and Mojo. Fix several bugs in dispatch of the GPU switched notifications, and handling of context loss and restoration. Fix an existing race condition where the antialias:true but preserveDrawingBuffer:false case would reallocate the back buffer unnecessarily. Add tests for these code paths, including covering previous CLs' work. Some of the new tests are being skipped while landing this CL to avoid having this CL reverted if flakiness in them is discovered. They will be enabled in a subsequent CL. Bug: 681341 Change-Id: I5f7aa6b24fd54ba6cf77403c33367956ff00bd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885636Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#713687}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/76ee91e12642..f7e05c734266 git log 76ee91e12642..f7e05c734266 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 rharrison@google.com Remove deprecated API elements (#870) 2019-11-07 9856269+sarahM0@users.noreply.github.com Add support and unit test for OpTypeInt, OpTypePointer and OpConstant (#872) Created with: gclient setdep -r src/third_party/shaderc/src@f7e05c734266 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I62d60c539c538455fa4da9731d33c16ab9c171ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904625Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713686}
-
Finnur Thorarinsson authored
Bug: 1016870, 860467 Change-Id: I185dc9f2eb07b0471ddf3eb8ceafdd3768c02af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897700 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#713685}
-
Scott Violet authored
These come from running the android linter. BUG=1020414 TEST=none Change-Id: I02069762e3cbadf595884ddaa607c810a30fc45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904763 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#713684}
-
John Budorick authored
Bug: 984162, 1004848 Change-Id: Ibb7c47f0188de8e077cd30aa8d68ca61133d2037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904549 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#713683}
-
Kai Ninomiya authored
Specification change: https://github.com/gpuweb/gpuweb/pull/469 Dawn roll: https://dawn.googlesource.com/dawn/+log/c3284fa40ec6b12731ed66c2f2a9256ae3fa692e..ae1f25fee85ebf2773b24a0a4f39c160839b1dbb CTS roll: https://github.com/gpuweb/cts/compare/3dc37c83a70667e9a92df773f34d154ec600d203...e114192747a54f34157eb65754e037701fbdf98b TBR: haraken@chromium.org Bug: dawn:22 Change-Id: Ib427760b9fba4b2cc4290de046c4a31d77e0b67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900807Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Yunchao He <yunchao.he@intel.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#713682}
-
Nasko Oskov authored
Bug: 763548, 1002276 Change-Id: I31ce542d39baee996359ba179759ac00239744c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904448 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713681}
-
Armando Miraglia authored
http://crrev.com/c/1831763 introduced a policy to make sure that enterprises can explicitly control the audio sandbox. The CL assumed that all calls of IsAudioSandboxEnabled() would happen on the browser process. It was, however, noticed that this is not the case as IsAudioSandboxEnabled() is called on the audio utility process to configure the sandbox. This caused the sandbox to always be enabled, since the default value for g_audio_sandbox_enabled is true. This CL fixes the behavior by replacing the global static variable with a switch which is then copied over to the audio utility process. Bug: 1018580 Change-Id: I810ca1f0c9aed43b892c06960cd8a87fc6debd8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901029Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#713680}
-
Robert Liao authored
BUG=5027 Change-Id: If972ad1381437b116f3279a3a51480dd2098d564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904495 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713679}
-
yjliu authored
Added VLOG to trace the bug where switching users with both having sunset-to-sunrise schedules may not apply NL correctly Bug: 1015474 Change-Id: Ib8a92dad84563175a48bce1a5270b341716b15e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902114Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713678}
-
Xiaoqian Dai authored
For a fling event, if the hotseat was hidden when the drag started, only if the fling event position exceeds the restore-to-maximized threshold, the window will be taken back to home screen. Also, remove the logic to decide if drag can be allowed from DragWindowFromShelfController as ShelfLayoutManager already handled it. Bug: 997885 Change-Id: I35b9c35df1477b92b5c01db49c9302b6f3bace60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902176 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713677}
-
Ben Kelly authored
This was an oversight in crrev.com/c/1884932 and effectively made the CacheStorageHighPriorityMatch feature have no effect. Bug: 1018920 Change-Id: Ib962f254c9204cdcde1c817cf7ecfa13360ac2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904125 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#713676}
-
David Grogan authored
We had been reversing the position of the items ignoring the fact that margin-top and margin-bottom shouldn't flip. Bug: 845235 Change-Id: I943c454fdb5f850a1e1294349abc9e9fe8c46aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903616 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#713675}
-
wutao authored
For Assistant web container, we do not need to clip the contents corners. Bug: b/144047917 Test: manual Change-Id: I865bb375c52faee3b5cda708b48b137aa07452ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902715 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713674}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I1e74a496b861354f9b5e83d74610b87c491af991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904536Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#713673}
-
Wenjie Shi authored
The PlatformSensorReaderWinrtBase::IsSensorCreateSuccess function has a switch case that determines whether a PlatformSensorReader was successfully created. The kErrorGetMinReportIntervalFailed (which is not fatal) and kErrorISensorWinrtStaticsActivationFailedcases (which is fatal) cases should have been swapped. This is causing a non-null PlatformSensorReader to be returned, but the underlying WinRT sensor object was null which triggers a null pointer deference the next time it is used. The fix is to swap the switch cases. Verified by running the new unit test. Bug: 1020987 Change-Id: Ia9ac960fb95de0b028677c1ff97b632aecd0b6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904503 Commit-Queue: Wenjie Shi <wensh@microsoft.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713672}
-
Daniel Rubery authored
Extend the lifetime of ZipFileSuccess, because the current status is somewhat surprising to me (only 85% extract successfully). crbug/1022564 has been opened to track the investigation into this fact. Fixed: 1021142 Change-Id: I34670e18c13ceeef98800b48be1fdda1492fae22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904621 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#713671}
-
- 07 Nov, 2019 13 commits
-
-
John Rummell authored
QueryOutputProtectionStatus() should report that a MediaRecorder is capturing audio/video streams. This adds a test that sets up a MediaRecorder using getDisplayMedia() to provide the stream, and verifies that the query does detect it. ClearKey CDM updated to periodically query for changes, and if a network link is detected, generate a keystatuseschange event with a dummy key ID and status 'output-restricted'. Bug: 856276 Test: new browser_test passes Change-Id: I3f9f200dded6647ec9526d929b962b3ccfae1d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894356 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713670}
-
Vladimir Levin authored
A recent change for intrinsic-size forgot to update the enums.xml file. (crrev.com/ae891958) This patch updates said file. R=chrishtr@chromium.org Change-Id: I332d69cfdf1974e709bf6c9d3c14a998c51c38f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904498 Auto-Submit: vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#713669}
-
Matt Menke authored
Somehow managed not to delete it in when I removed it from net/BUILD.gn in https://chromium-review.googlesource.com/c/chromium/src/+/1869725. Bug: 934009 Change-Id: I1a85d090064e472e04d9f7d9767d6f5399a767b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903830Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#713668}
-
Ionel Popescu authored
This CL removes the rounded corners and padding for select options to avoid exposing the underneath background of the select. The new behavior is validated by select-popup-appearance-basic.html and by new tests added in select-multiple-appearance-basic.html Bug: 1021227 Change-Id: I6e6c45fc6627187f18511e0409ca0e20e07e1d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902525 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#713667}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/27a3d31d7a9d..d9ed1c2732ba git log 27a3d31d7a9d..d9ed1c2732ba --date=short --no-merges --format='%ad %ae %s' 2019-11-07 sugoi@google.com Prevent rasterizing fragments outside the framebuffer Created with: gclient setdep -r src/third_party/swiftshader@d9ed1c2732ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141999739 Change-Id: I281ee29a1bb2124be08fba5ad65fe00923530a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904608Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713666}
-
Hongchan Choi authored
As suggested in: https://chromium-review.googlesource.com/c/chromium/src/+/1903756 TBR=sky@chromium.org Bug: 1022319 Change-Id: I31474c0f0242ca5177ef2bfca9b2415c6448f437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904543Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Auto-Submit: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713665}
-
Chris Blume authored
SurfaceAggregator's call to AddColorConversionPass() currently happens on all platforms. But it should be a no-op on every platform except Windows. On other platforms, there is a proper gamma curve. But on Windows it is linear. This results in color values that are outside an acceptable threshold. That is why a color conversion is necessary. The intent was for this to only happen on Windows. This CL matches that intent by explicitly marking that function call as only happening on Windows. Change-Id: I66ebf3b42b84729e6062ff738c25d903aac2dc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900286Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#713664}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a9c5d494..29e8c96f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifab465b945682f6272f0f3f0ac38bb56a450cc59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904668Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713663}
-
Takumi Fujimoto authored
Fix histogram names that got swapped around during a refactoring. Change-Id: I8f680a9c0ae28ab287656fea1981f26bd338f712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904540 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#713662}
-
Michael Crouse authored
This change allows the folder that an optimization guide store uses to persist its data on disk in. A future change will create a store with a folder for only the prediction model and host model feature data to be held. Bug: 1001194 Change-Id: I0f03fea562a69eb8ddc4ea3f7e69ee2f1a999162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904612Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#713661}
-
Donn Denman authored
Adds side-shadow assets to the Overlay in the new layout that already has rounded corners. These assets just add a shadow, so there are no dark versions needed, and we just have one side (using code to flip it for the other side). Binary-Size: +2K for the side shadow assets. BUG=1005975 Change-Id: I31ebf657b2e9f49822c5aeb525b655c91d9b81aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895924 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#713660}
-
Christopher Cameron authored
This is now in a good enough shape to turn on. The remaining work is to add tracking to ensure that we open the most-recently-used profile on launch. Bug: 982024 Change-Id: Ib6b922a1ebca043a6c8f8eb2ded2cd3c837cc80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902866 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#713659}
-
Jinsong Fan authored
Since ContentVideoView has been removed for a long time, kUseContentVideoView is no longer used. The CL removes it and related codes, replaces the switch::kUseAndroidOverlay by the switch::kOverlayFullscreenVideo everywhere. Bug: None Change-Id: I95e9d6ec33fd8027914770cd5224163018fd6399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890510Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#713658}
-