• Nektarios Paisios's avatar
    Fixes crashes in AXPosition · 6412addb
    Nektarios Paisios authored
    We recently migrated to the NGOffsetMapping class to convert from DOM offsets, which might have uncompressed white-space, to text offsets
    which are used in the accessibility tree.
    However, the assumption was that NGOffsetMapping supports returning text offsets for
    all block flow elements, which is untrue. Only block flow elements that are at inline or inline-block level are supported.
    Unfortunately, allowing block-level elements through to the NGOffsetMapping class could cause a serious crash in Blink.
    
    AX-Relnotes: n/a.
    
    R=dmazzoni@chromium.org, aleventhal@chromium.org, yosin@chromium.org
    
    Change-Id: I311be3cbc01abd8d1819c405bf7c63aaa62785d5
    Bug: 1124963
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436748
    Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
    Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
    Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
    Auto-Submit: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#811915}
    6412addb
ax_position.cc 44 KB