GitLab

We recently migrated to the NGOffsetMapping class to convert from DOM offsets, which might have uncompressed white-space, to text offsets
which are used in the accessibility tree.
However, the assumption was that NGOffsetMapping supports returning text offsets for
all block flow elements, which is untrue. Only block flow elements that are at inline or inline-block level are supported.
Unfortunately, allowing block-level elements through to the NGOffsetMapping class could cause a serious crash in Blink.

AX-Relnotes: n/a.

R=dmazzoni@chromium.org, aleventhal@chromium.org, yosin@chromium.org

Change-Id: I311be3cbc01abd8d1819c405bf7c63aaa62785d5
Bug: 1124963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436748
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811915}

Bug: none
Change-Id: If156da0fe3fb65e99ad00984cf65c0b962a6bbf8
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438732
Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Reviewed-by: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811914}

This CL updates descriptions on two Language Settings strings based on
feedback from translators.

Bug: 1133470
Change-Id: I91c27b06104fea6b3bb57a3033aec3cc1136450b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438311
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Auto-Submit: Trevor  Perrier <perrier@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811913}

Add tests for base::TimeDelta parameters of zero, min, max, and
negative. Fix errors in constructor DCHECK's uncovered by the tests.

Add a gmock InSequence declaration to ExpectBindAndRespondToQuery, which
included two expectations that happened to be in the wrong order. This
makes it usable from inside another InSequence block, and also enforces
the correct order in tests that don't already use InSequence.

R=chrisha

Bug: 1080672
Change-Id: I39ece84cbbeaf23466fd1678bd761f62f54f7d71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422903
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Auto-Submit: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811912}

The PasswordProtectionService and
PasswordProtectionNavigationThrottle both
own a scoped_refptr to PasswordProtectionRequest.
When both the Service and Throttle class are
created, two scoped_refptrs are created for
the same PasswordProtectionRequest. When
the request is finished, the Service class
erases the scoped_reptrs, but the Throttle
class still contains a reference to the
scoped_refptr, which causes a page hang.
Thus, the Throttle class also needs to
release the scoped_refptr when navigation
is resumed or canceled.

A follow up is to refactor the PasswordProtectionRequest
and not have it RefCounted.

Bug: 1110427
Change-Id: Idf66b0451036099d0a417a42b6a37f5a5b10cf13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406599
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811911}

This adds code to enable media router features, although the
implementation is still missing.

Notably,
- a feature flag is added to enable/disable MediaRouter code
- Media-related java, new and old, is moved into weblayer_private.media

Bug: 1057100
Change-Id: Ied1cfd60e19890166568fc3facbd012285c9fabf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427289Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811910}

Bug: 1123769
Change-Id: I9cc14ddb946dcd50b34854374b581f5c4b28ed30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429981Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811909}

When rendering HTML, specify charset. Without this, we get some
strange looking characters in the render. This should not fix all cases,
but hopefully fixes the majority.

Bug: 1128615
Change-Id: Ie81e2278c29c6f056bc5b4a1af886f5f9c089a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437706
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811908}

Reduce the scope of |kBuiltInHost| so it is created on first use. Also
fix a bunch of nits in the file.

Bug: 537099
Change-Id: I5834a415fb26cd1b4cd071fbdb938453b1757d8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430767Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811907}

Also, fix typo in a method name.

Bug: None
Change-Id: I53912102768cc98dcad18377859d2bb8664ddb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437539
Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org>
Reviewed-by: My Nguyen <myy@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811906}

This CL adjusts layout to match the spec, adds ink drop to action
buttons, and adds a drop down icon next to title label.

Bug: 1133026
Change-Id: I46a8af315c98b43e2b557908dfebf810c1666ef0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436419Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811905}

* Add Finch to control snooze duration experiment.
* Add UMA to track 4 events, all with the count of previous snoozes.
  1) Tab Group IPH trigger.
  2) Tab Group IPH dismiss by dismiss button.
  3) Tab Group IPH dismiss by right-click on tab.
  4) Tab Group IPH snooze.

Bug: 1121399
Change-Id: Ib5aa2ed0c92d5bf8cfe2f1744d596ac2d03e6a0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425230
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811904}

Test: none
Change-Id: If8a7d3c203a36f342440f4046c5c1fc789c4e9b2
Fixed: 1088590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438873Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811903}

This reverts commit 6c5fa707.

Reason for revert: VTConfigUtil.FormatDescriptionBT709 and FormatDescriptionInvalid are failing on mac
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/58972

Original change's description:
> Add media::GetFormatDescriptionColorSpace
>
> This function is nearly identical to media::GetImageBufferColorSpace,
> but instead operates on a CMFormatDescriptionRef.
>
> Add DCHECKs that the behavior of the two functions be the same, that is,
> the kCVImageBuffer-prefixed and  kCMFormatDescription-prefixed
> constants be equal.
>
> Use base::mac::CFCast instead of reinterpret_casts.
>
> The next patch in this sequence will move these two functions over
> to media/base/mac, because it will be accessed in capture.
>
> Bug: 959962
> Change-Id: I8a4d8468abc866a13cb6181cbd49d9ee04288124
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436513
> Commit-Queue: ccameron <ccameron@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811829}

TBR=dalecurtis@chromium.org,ccameron@chromium.org

Change-Id: Iaa57cf20273eb0bcdace23a1ee9e588da15ea733
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 959962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438551Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811902}

This CL adds a new parameter to all AffiliationFetcherDelegate virtual methods - a pointer to AffiliationFetcher.
This change is required to later handle multiple pending fetchers logic in AffiliationServiceImpl to process each result per specific fetcher.

Bug: 1117045
Change-Id: I26ad49ba7bca605c2117ce8a88ce017de2dda276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433927
Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811901}

Change-Id: I6ad2476f440e02c5ce2580a540b0e76a2afcb1f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439536Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811900}

This CL accomplishes two things:
(1) Select the first menu item as default after the multipaste menu
shows.
(2) Update the selected menu item after item deletion.

Bug: 1130737, 1128720
Change-Id: I2ddc0923679b0e95ebe0f746d790dfc11a146668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434365
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811899}

piex-wasm assumes a fileSystemURL input as the RAW image source. Allow
other users to input the RAW image source in a File.

Add readFile helper, and make fileSystemURL and File source inputs use
it to read the file.

fileSystemURL case has automated test coverage, so readFIle is tested,
so no change in files app behavior.

Bug: 1132695
Change-Id: Ic05c5b5a2178826445221448824f8ef41dc81ea7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437084Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Auto-Submit: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811898}

This is not needed and should only be done for promise_test.

Change-Id: I53aaee9d8f500c85a7d74be0f92ffcb6164b2424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436654
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811897}

The FidoAuthenticationStrikeDatabase was added in
https://chromium-review.googlesource.com/c/chromium/src/+/1824362.
However, the "Autofill.StrikeDatabase.NthStrikeAdded" and
"Autofill.StrikeDatabase.StrikesPresentWhenStrikeExpired" histograms
are part of strike_database_integrator_base.cc, which all
project-specific Autofill strike databases inherit from.
As a result, CL 1824362 missed updating histograms.xml at the time,
since it was the superclass doing new automatic logging.

Change-Id: Ie791e52dfd51139986553e29230ad23960ee46f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437018
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811896}

This ensures that leaving the Cast Activity by pressing Back on
the remote will return to the Home screen, rather than whatever
app had been in the foreground previously.

Bug: Internal b/163998933
Test: launch Netflix with remote, Cast YouTube, press Back
Change-Id: Ib8936e874a80441a4e5c163794ff2576ffbef717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438991
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org>
Auto-Submit: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811895}

This changes the location of the chrome_renderers freezer cgroup to
match pending changes.

/sys/fs/cgroup/freezer/early_freezer/chrome_renderers/to_be_frozen/tasks
file

Bug: b/134792837
Test: suspend_stress_test and check for PIDs in
Change-Id: Ibf76f4e2f6cbb527dd738194f3baea506447f8d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337546
Commit-Queue: Derek Basehore <dbasehore@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811894}

Bad logic in PowerMonitorDeviceSource::IsOnBatteryPowerImpl()
meant that Macs with no batteries were reported as being on
battery power.

Fixed: 1132422
Change-Id: Ifa174a0164c4d4d31bdd2dc494b2b7f83fd48bca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432765
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811893}

Bug: 989569
Change-Id: I2c76acfbcf05454aa73e298ffc4acae689441756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437702
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811892}

See https://chromium-review.googlesource.com/c/chromium/src/+/2435724/
for more thorough explanation.

Bug: 989569
Change-Id: Icd7d64e2a3716e8aaf66dd757ea4d0433c3a2209
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435814
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811891}

Removing cross-origin dialogs is being worked on in
https://chromestatus.com/feature/5148698084376576. Make sure
that the relevant UMAs don't expire.

Fixed: 1130653
Bug: 1065085
Change-Id: I1fb2167f80e9b8337d4169f2236c84822dbce973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438891
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811890}

The text color is currently set to a dark shade of grey. However,
devices with dark launchers can have dark backgrounds and this makes the
dark grey text unreadable. This CL updates the text color to be
determined by the app list color provider instead, which will take into
account the dark or light theme of the launcher.

Bug: 1079169
Change-Id: Ica64fffb6e7f83b1e028088af4649c470c4f36fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437075Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Rachel Wong <wrong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811889}

Bug: 1129023
Change-Id: Icae4a8c1de05954f7467edae7c477ec41f4fa183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438037
Auto-Submit: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#811888}

This CL updates CheckedPtr docs:

- Rewrite examples are provided
  (e.g. |SomeClass*| -> |CheckedPtr<SomeClass|).

- Updated the "Benefits and costs of CheckedPtr" section to reflect
  BackupRefPtr's characteristics (avoiding dereference-time checks
  and instead working in ctor/dtor to quarantine the freed memory).

- Moved and updated the section on unions - because BackupRefPtr
  requires CheckedPtr to have a non-trivial destructor, it is
  incompatible with union fields.

- Removed most of the "Runtime errors" section, since with BackupRefPtr:
    - `operator*` no longer needs to compare tags (as with CheckedPtr2)
      and therefore should work fine with sentinel values
    - Converting into a raw pointer no longer performs any checks and
      therefore dangling pointers can be safely passed around (as long
      as they are not dereferences afterwards).

Other minor updates:

- Linking to go/miracleptr

- Mentioning that initially the rewrite will not target renderer code

Change-Id: Ia1903572a01180f81af39c3a91498dad796e9baf
Bug: 1073933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419378
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811887}

Update the description to emphasize that newly marked obsolete
histograms don't need to be moved into this file.

Bug: 1132741
Change-Id: I6691db75b9579db09445e00d7b4ecbda16ad97a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438691
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811886}

On a typical textfield, the IME surrounding text change event is
triggered by [1]. However, this is guarded by a check for inputmode !=
NONE. Whilst this makes sense for a virtual keyboard IME since inputmode
of NONE means no virtual keyboard, it doesn't make sense for a physical
keyboard IME as inputmode doesn't apply to the physical keyboard.

Move the selection update check outside and only check for input type
!= NONE since it applies to both virtual and physical keyboard.

This fixes incorrect surrounding text information on the Google sheets
"input field" that that appears when pressing a key on a cell.

Note: The comments for [1] suggests that it's only used for a11y, but actually
it is crucial to getting the right surrounding text information to IMEs.

[1] https://source.chromium.org/chromium/chromium/src/+/master:content/browser/renderer_host/render_widget_host_view_aura.cc;l=2483;drc=ca19c6d8767e8c7e9c0d01c223587183a2e1278d

Bug: 1114559
Change-Id: I1b360a4f81d7c5e6479fab8f8fba4d1632881da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344331Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811885}

This reverts commit 7927c8a6.

Reason for revert: suspecting that this patch caused consistent test failure on chromeos: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8852 

Original change's description:
> Use JS modules for the NTP module
>
> Uses JS modules for the NTP module and updates
> closure so it can resolve chrome://kaleidoscope.
>
> Change-Id: I985b20a7faca215bd5194a4a21c790d5a4ff0262
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435441
> Reviewed-by: calamity <calamity@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811807}

TBR=calamity@chromium.org,beccahughes@chromium.org,steimel@chromium.org

Change-Id: I3d4fed8789ad99a9c289ed604b83d22a2c243dc4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438042Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811884}

Adds code to rollback MobileIdentityConsistency: when the feature is
disabled, SigninManager will trigger a signout if there's only primary
account, but no sync consent.

Bug: 1132290
Change-Id: Ia9f0143b908c1867743e0b89b7589ddbb03bff02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434330
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811883}

Bug: 1002914
Change-Id: I393bc371972d8140cf87308723af8852f5b80dc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432130Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#811882}

In the last CL, "cpu_arch_full" was set to "arm64-highbd" for Windows
ARM64, which seems not needed because "arm64 windows has it's own folder
for vp9_rtcd.h etc". This CL revert that part of the change so Windows
restores to the previous behavior.

Tbr: jzern@google.com
Bug: 1133301
Change-Id: Iba23fe496841965f491704d5a503b388c1859b7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437745Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811881}

This reverts commit f218ef61.

Reason for revert: Breaking downstream build. Feel free to reland once you have downstream fix ready to go, but I don't think we can let downstream be broken until then

Original change's description:
> Modularize Omaha on Android: modularized identity/ from //chrome/android
>
> New location: //chrome/browser/uid; this is a dependency of Omaha on Android.
>
> Bug: 1131415
> Change-Id: Id65534f432adb733c9b1224f8fc770f30cbf00df
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426045
> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com>
> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811874}

TBR=nyquist@chromium.org,msarda@chromium.org,waffles@chromium.org,bsazonov@chromium.org,chouinard@chromium.org,andzaytsev@google.com

Change-Id: I729d7bc353cf44d2f6e32e7a764726c82b6dd83a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1131415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439026Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811880}

This was never added to histograms.xml, but is being logged.

Bug: none
Change-Id: Id77fbd584c72d363e2dc7537f4a2ae5ebb65749a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438637
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Auto-Submit: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811879}

Generate DIR_METADATA files
and remove metadata from OWNERS files
for //buildtools.

Bug: 1113033
Change-Id: I54fdf94f060220d189ce9c843e02fc22f12df623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438877
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#811878}

This change makes ShelfController and AppListControllerImpl a
MessageCenterObserver. This allows them to hide/show the app badges from
being shown whenever quiet mode is enabled/disabled.

Bug: 1130940
Change-Id: Ia26890b266b1d8ba26529afddf8347f21729bfb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436859Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811877}

This is logged when webview is used in multiple processes in the same
app, the warm up connection hits a service used by another process and
is not retried again. It's not catastrophic, since launching a renderer
process for real will still succeed. So lower it to a warning.

Change-Id: Ic9b8bbdda4b6c5cbf45ea7ce15abca7289692625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438894Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811876}