• Julien Isorce's avatar
    Add specific initialisers to GLImageEGL's childs · 7089b2da
    Julien Isorce authored
    GLImageAHardwareBuffer:
        bool Initialize(AHardwareBuffer* buffer, bool preserved)
    
    GLImageNativePixmap:
        bool Initialize(uint32_t texture_id)
    
    Not keeping the same signature as GLImageEGL::Initialize
    to indicate how it is used. And if needed, more initialisers
    can be added.
    
    This prevents the user from doing mistakes when
    instantiating a subclass of GLImageEGL but calling
    the parent's initialiser.
    
    For consolidation this CL also moves GLImageEGL::Initialize
    from public to protected.
    
    Note that GLImageEGL cannot be instantiated directly
    because it does not implement a few pure virtual functions
    it got from its parent, gl::GLImage.
    
    Bug: 785201
    Test: gl_unittests --gtest_filter=*NativePixmap*
    Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    Change-Id: Ida5834bbf964893680f449f1f5da7371e46075bc
    Reviewed-on: https://chromium-review.googlesource.com/817563
    Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
    Reviewed-by: default avatarDavid Reveman <reveman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#525307}
    7089b2da
gl_image_ahardwarebuffer.cc 1.64 KB