• James Cook's avatar
    settings: Fix exception when search matches external storage management · 7368cffe
    James Cook authored
    Settings search relies on the HTML attribute associated-control to
    show yellow bubbles when a search matches a sub-page.
    
    Change the settings-subpage for external storage management to have
    an associated-control at the top level of the settings page, so the
    bubble appears on the Device > Storage row for a matching search.
    
    This also prevents JS exceptions in the search code (the previous
    selector didn't match any elements).
    
    Test: On a device with Google Play Store support, open OS settings and
        search for "stor". Verify: JS console has no errors. Search field
        spinner eventually stops spinning. Yellow bubble appears over the
        Device > Storage item. Clicking search (X) clear bubble removes all
        yellow bubbles.
    
    Bug: 1003970
    Change-Id: I752eccebca599b1275fe505cff7cf561dc7ed66c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808179Reviewed-by: default avatarMichael Giuffrida <michaelpg@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#697642}
    7368cffe
device_page.html 4.77 KB