GitLab

Settings search relies on the HTML attribute associated-control to
show yellow bubbles when a search matches a sub-page.

Change the settings-subpage for external storage management to have
an associated-control at the top level of the settings page, so the
bubble appears on the Device > Storage row for a matching search.

This also prevents JS exceptions in the search code (the previous
selector didn't match any elements).

Test: On a device with Google Play Store support, open OS settings and
    search for "stor". Verify: JS console has no errors. Search field
    spinner eventually stops spinning. Yellow bubble appears over the
    Device > Storage item. Clicking search (X) clear bubble removes all
    yellow bubbles.

Bug: 1003970
Change-Id: I752eccebca599b1275fe505cff7cf561dc7ed66c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808179Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697642}

... down into blink/renderer.

CL also moves the following pure virtual classes: network_list_manager.h
and network_list_observer.h to the same location, and adds a TODO to
verify their existence altogether.

BUG=787254, 919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Iabba2936c745d028f5388153d5fe0d10ec19a8b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806977
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697641}

for force dark behaviour (force dark vs media query).

Rename corresponding methods.

Bug: 1001516
Change-Id: I7af3bb835ddd2f9761ffe350e626ef10d7321087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796673
Commit-Queue: Anna Malova <amalova@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697640}

Intended to ease deletion of default implementations of methods in the
abstract PeerConnectionInterface. See webrtc cl
https://webrtc-review.googlesource.com/c/src/+/140860

Bug: webrtc:10716
Change-Id: I57d5b72b1650c3f1558773e9e86f1b77831e9f59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807826Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Niels Möller <nisse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697639}

Switching to running the perf collector on a dedicated sequence triggers
a crash in DCHECK_CALLED_ON_VALID_THREAD when the THREAD_CHECKER is
checked on 2 different threads in the same thread pool at different
times. Switch to SEQUENCE_CHECKER to fix the crash.

Bug: 904785
Test: Turn dcheck_always_on = true and revert https://crrev.com/c/1764319
      Verify on DUT that collections doesn't crash the system UI.

Change-Id: I9972baa568a2f7bad373777750085a160c6deb23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810146Reviewed-by: Gabriel Marin <gmx@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697638}

If addition of secondary accounts is disabled, an error page should be
displayed instead of Gaia sign-in screen.

Bug: 987218
Change-Id: I2954adddf8ece06ca9a0cf355539781e23817d42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731891Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697637}

https://swiftshader.googlesource.com/SwiftShader.git/+log/61a2765940a7..e70432574670

git log 61a2765940a7..e70432574670 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 chrisforbes@google.com Fix cf_x86_phone boot

Created with:
  gclient setdep -r src/third_party/swiftshader@e70432574670

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/141209513
Change-Id: I61e58792143ddcdc4bb3b7cc18ff03836c6ffb35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810181Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#697636}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a84a61e89596..dd281eec08fe


Created with:
  gclient setdep -r src-internal@dd281eec08fe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I1cbe5bc91131a709511a8481620cd8a99a53271a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810183Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#697635}

This CL converts PublicIpAddressGeolocationProviderPtr in
components to the new Mojo type.

Bug: 955171
Change-Id: I92b9e37fbdeb105893c45a99952e430e7b11b9c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809198Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#697634}

BUG=787254, 919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Id4b213f3a43515b3e501d5af9d9ce11fee5c09fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806976
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697633}

No change to logic.

The kDisableMetrics switch doesn't exist. I think the intended switch
name was kForceEnableMetricsReporting.

Bug: 994418
Test: N/A
Change-Id: I89e36fcf5f42225953c40c25ea00addcf1993185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809980
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697632}

Making to use IDS_FOO_BAR instead of WebLocalizedString::kFooBar
directly, callers of WebLocalizedString::kFooBar need to include
content_strings.h from //content. But, it can cause a layer
violation issue. So, we need to move conteont_string.grd to blink
in order to make the callers include IDS_FOO_BAR from Blink.

Major changes are as below,

 - Move content_string.grd to third_party/blink/public/strings/
 - Renames blink_strings.grd
 - Change content_ prefix with blink_ prefix.

TBR=jamesr@chromium.org, pfeldman@chromium.org

Bug: 995644
Change-Id: I8587cb4efd0d6a8d95ff7ad95cd416c3b55f7af2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788968
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697631}

In the majority of cases SMILTimeContainer::NotifyIntervalsChanged is
already called - or doesn't need to be called either because we're about
to perform an update already (Reset()), or because there is no time
container to notify anyway (constructor).

Bug: 998526
Change-Id: I2e36cbd622a79f3f74f2edf170e6e1d34be3582c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810897Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#697630}

Bug: 1001386
Change-Id: I4082dcdb5968d845c6dca0601c5d5f96a84f17a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805664Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697629}

https://boringssl.googlesource.com/boringssl/+log/5ce7022394055e183c12368778d361461fe90a6e..a7d9ac2af4684747c4524cbeba9737b04dce3e3e

Bug: none
Change-Id: I7580cf38646d98994dad027f8aace2fb07e2a342
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808421
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697628}

These tests rely on resources to be cached. Once split cache is enabled
by default, they will not be cached if there is no network isolation key in the
request. Thus populating the key for these requests.

Bug: 989067
Change-Id: Ie0edee408bf74dc17234cbc90b67c6ae2899f585
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806844Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697627}

This is a reland of b3373919

Original change's description:
> Convert ui/ARIAUtils.js to an ES module
>
> ES modules allow files to explicitly import and export symbols [1].
> This patch migrates ARIAUtils.js to an ES module, while maintaining
> backwards compatibility with existing usages of `window.UI.ARIAUtils`.
>
> The build system is updated to copy these modules verbatim, as it no
> longer require pre-processing to be loaded. The `module.json` no longer
> includes this file as a script, to make sure it is not double-bundled
> into `shell.js`. Instead, it is added to the new field `modules`, which
> contains all modules. By doing so, it becomes clear which files are
> converted to modules already and which require the legacy references
> to the global scope.
>
> This module and future modules will be imported from `root.js`, which is
> added to all existing HTML application files.
>
> Design Doc: https://docs.google.com/document/d/1h9dOy3nNPNfZ2AtZXzB-DwJqG4Oo37WWvKLCuzCcPzo/edit?usp=sharing
>
> [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import
>
> TBR=jochen@chromium.org
>
> Change-Id: Ie79c8f2fce3aff96fa28af0b575eae39bfe8e1a5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748949
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@google.com>
> Cr-Commit-Position: refs/heads/master@{#697238}

Change-Id: I7544cbf4364d0b1a3c2f137a4d17a1afdb1d4aed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810534Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697626}

This is a partial revert of
https://chromium-review.googlesource.com/c/chromium/src/+/1761666 coupled with a
string change discussed over email with srahim/markchang.

Bug: 1005025,1005026
Change-Id: I4451f9ff741a958906ce5d76174cafd52eff28a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810033Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697625}

Change-Id: Ic616ac3d020b0ec8302451408af459bda73a58d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810185Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697624}

Also fix a couple of miscounted constants

Bug: 1005220
Change-Id: I4eeebc048594030a1a7e86e730a2b01450c97f1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810802Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697623}

This CL also ensures that mitigation policy is applied before
adding any rules that depend on the policy.

It also restores the sandbox convention that mitigation
policies and rules can always be requested by a sandbox
user and the sandbox will try and enforce the maximum set
of rules supported by the running OS. i.e. the user should
not be aware of OS capabilities, merely sandbox capabilities.

BUG=996834

Change-Id: I5a8432d94dc1bcfbe327589f2b21c4c76fb9fedb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810937Reviewed-by: James Forshaw <forshaw@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697622}

This is a follow up of [1].

[1] https://crrev.com/c/1805159

BUG=787254, 919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ib3198c792586ebe2671b365d17d46201a07d5aa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806975
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697621}

This should be closer what happens in reality, since this will trigger
the "loading" via the setAttribute() call on the generated <img>
element. Otherwise the setAttribute() will essentially turn into a
removeAttribute() and do nothing, relying on the insertion of said
element to trigger "loading".

Bug: 1000273
Change-Id: Ib06b1d1b92cc6479d322663a896b0b0c8d6afc8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789812
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697620}

Tab and TabStrip are only ever instantiated as MdTab and MdTabStrip.  Combine
the code for the subclasses with the parents, eliminating unreachable code.

Inline various constants that are only used once and whose names added no
real clarity.  Rewrite a few places for brevity.  Reorder definitions to
match declarations.

Bug: 934273
Change-Id: I7853a96d0929e8eeedc60f421b8426e171befec7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809632
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697619}

At this point, no other language model than the primary model is used.
Hence, it's unnecessary to initiate anything else than the primary model.
We can thus simplify the `PrepareLanguageModels` function by collecting all the conditions in a single switch statement.

Change-Id: Ibbd3b0054fe5f8e12c3a69e01acfb57b211ce0ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801268Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697618}

This CL converts ScreenOrientationRequest and
ScreenOrientationListenerRequest in services and content to the
new Mojo type.

Bug: 955171
Change-Id: I1317ef2f1c6693604026b14c25f05045a7da79cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809044Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#697617}

It was never called.

Bug: none
Change-Id: I5bd87f1201628aa065d3d7d9f8ce8109d3928aad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810530
Auto-Submit: Marc Treib <treib@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697616}

This CL converts PowerMonitorClient{Ptr, Request} in services and
content to the new Mojo type, and uses
pending_remote<PowerMonitorClient> in power_monitor.mojom.

Bug: 955171
Change-Id: I3d5ca5416bad911e1d46d96afcff652f9895422f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808938Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#697615}

This CL uses PendingAssociatedReceiver and
AssociatedReceiver instead of
PasswordGenerationDriverAssociatedRequest and
AssociatedBinding,

Bug: 955171
Change-Id: I540d65f794cafaa3db5c0085fc2e4ba84a482a51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808942
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697614}

Bug: 984608
Change-Id: I7770ce7d177c4a9aa7cda9dd3243761c4716429e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808265Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697613}

This CL was generated by
//base/android/jni_generator/jni_refactorer.py.

Bug: 929661
Change-Id: Iad5d2c2c4d2c5a7ae1ed8cf6a844abf8b8946374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808592
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697612}

The Incognito BadgeButton needs a separate color when in
<=iOS12 since dynamic types are not supported.

Bug: 999216
Change-Id: Ifb7f41ae007618f3279aec31238f692fd4c33eeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808528Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697611}

This CL was generated by
//base/android/jni_generator/jni_refactorer.py.

Bug: 929661
Change-Id: Ib26cd65ad27cb8f339a701654e5b65d20559e5f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809497Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697610}

- Evict documents from BackForwardCache after 15secs. This can also be controlled by finch
experiment using the field trial parameter:"TimeToLiveInBackForwardcache".
- Design Document:
  https://docs.google.com/document/d/1tGva3Xl4_kRTlKSgTc1v_JA59wo2q81W1ctPj7vPX3Q/edit?usp=sharing

Bug: 987187
Change-Id: Ieb61303b25e971a70042c439b520a4f296a200b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801152
Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Lowell Manners <lowell@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697609}

This CL was generated by
//base/android/jni_generator/jni_refactorer.py.

Bug: 929661
Change-Id: I039efa85ff4cb4e28708e83201cf034b25987ea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808216
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697608}

This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1808810
as apparently another of the WebGLGreenTriangle tests has begun demonstarting
the same flakes.

This marks it as Skip on Intel.

TBR=ynovikov@chromium.org
TEST=vulkan_pixel_skia_gold_test
Pixel_WebGLGreenTriangle_NoAA_Alpha

Bug: 1004840
Change-Id: Idaf0d683e0c31ce12600d545181d63b0bb16a580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810823Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697607}

Visual: http://screen/uNyrKqcrQvM

Bug: 1004923
Change-Id: I94cc8988ec1f8f542ce7496c8acce5fc14f2ce98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808263Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697606}

https://chromium.googlesource.com/chromium/deps/icu.git/+log/faee8bc70570..2ecd66c696c4

$ git log faee8bc70..2ecd66c69 --date=short --no-merges --format='%ad %ae %s'
2019-09-12 thakis Remove a few TODO(GYP)s that look obsolete.
2019-08-29 jose.dapena Cherry-pick "Do not override clang compiler internal builtins" in ICU
2019-08-30 jose.dapena Cherry-pick "Remove obsolete U_HAVE_STD_ATOMICS and similar @internal macros." in ICU

Created with:
  roll-dep src/third_party/icu

TBR=jshin

Bug: 819294
Change-Id: I764954ad1d8675d3b614b120fdbb1fe2e607b946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810797Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697605}

I believe the original change crrev.com/ae8ee33c introduced the
problematic code. A related page could be in a detached state.

BUG=1002513

Change-Id: I84cab50cda65f0a66ac407fc89f35bbd2b2ff7cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808115Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697604}

Noticed during milestone binary size review.

Bug: 982762
Change-Id: If14512c734f726ad6bc74feb539d954ca177eb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803394
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697603}