• tsergeant's avatar
    MD History: Replace app-route with a custom router · 73e5d0ee
    tsergeant authored
    app-route is a fairly heavy-weight element, supporting complex routing
    patterns designed for large pages. This is unnecessary for MD History,
    which currently has one routing pattern and one query parameter.
    
    This CL replaces app-route with a custom router, <history-router>, which
    is responsible for two-way binding between the page state and the page
    URL. This also refactors handling of search terms elsewhere in the app
    to ensure that changes to the search term are reflected correctly across
    the page.
    
    This CL has a small positive impact on load time (~20ms on a Z620), code
    health (all routing is handled in one place) and binary size (app-route
    can be deleted from the binary).
    
    BUG=629710
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2352293002
    Cr-Commit-Position: refs/heads/master@{#420590}
    73e5d0ee
find_unused_elements.py 4.9 KB