• Michael Spang's avatar
    chromecast: tracing: Fix chromium-style warnings · 7bc90a28
    Michael Spang authored
    ../../chromecast/tracing/tracing_service_main.cc:96:28: error: [chromium-style] Overriding method must be marked with 'override' or 'final'.
      virtual ~TraceCopyTask() {}
                               ^
                                override
    ../../chromecast/tracing/tracing_service_main.cc:96:3: error: [chromium-style] 'virtual' will be redundant; 'override' implies 'virtual'.
      virtual ~TraceCopyTask() {}
      ^~~~~~~~
    ../../chromecast/tracing/tracing_service_main.cc:181:30: error: [chromium-style] Overriding method must be marked with 'override' or 'final'.
      virtual ~TraceConnection() {}
                                 ^
                                  override
    ../../chromecast/tracing/tracing_service_main.cc:181:3: error: [chromium-style] 'virtual' will be redundant; 'override' implies 'virtual'.
      virtual ~TraceConnection() {}
      ^~~~~~~~
    ../../chromecast/tracing/tracing_service_main.cc:339:29: error: [chromium-style] Overriding method must be marked with 'override' or 'final'.
      virtual ~TracingService() {}
                                ^
                                 override
    ../../chromecast/tracing/tracing_service_main.cc:339:3: error: [chromium-style] 'virtual' will be redundant; 'override' implies 'virtual'.
      virtual ~TracingService() {}
      ^~~~~~~~
    6 errors generated.
    
    BUG=b/31079742
    
    Change-Id: I8cc22c845599662e9a6088328933e67cd4ebf490
    Reviewed-on: https://chromium-review.googlesource.com/814218
    Commit-Queue: Michael Spang <spang@chromium.org>
    Reviewed-by: default avatarDoug Steedman <dougsteed@chromium.org>
    Reviewed-by: default avatarDaniel Nicoara <dnicoara@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#522453}
    7bc90a28
tracing_service_main.cc 11.7 KB