Commit 7bc90a28 authored by Michael Spang's avatar Michael Spang Committed by Commit Bot

chromecast: tracing: Fix chromium-style warnings

../../chromecast/tracing/tracing_service_main.cc:96:28: error: [chromium-style] Overriding method must be marked with 'override' or 'final'.
  virtual ~TraceCopyTask() {}
                           ^
                            override
../../chromecast/tracing/tracing_service_main.cc:96:3: error: [chromium-style] 'virtual' will be redundant; 'override' implies 'virtual'.
  virtual ~TraceCopyTask() {}
  ^~~~~~~~
../../chromecast/tracing/tracing_service_main.cc:181:30: error: [chromium-style] Overriding method must be marked with 'override' or 'final'.
  virtual ~TraceConnection() {}
                             ^
                              override
../../chromecast/tracing/tracing_service_main.cc:181:3: error: [chromium-style] 'virtual' will be redundant; 'override' implies 'virtual'.
  virtual ~TraceConnection() {}
  ^~~~~~~~
../../chromecast/tracing/tracing_service_main.cc:339:29: error: [chromium-style] Overriding method must be marked with 'override' or 'final'.
  virtual ~TracingService() {}
                            ^
                             override
../../chromecast/tracing/tracing_service_main.cc:339:3: error: [chromium-style] 'virtual' will be redundant; 'override' implies 'virtual'.
  virtual ~TracingService() {}
  ^~~~~~~~
6 errors generated.

BUG=b/31079742

Change-Id: I8cc22c845599662e9a6088328933e67cd4ebf490
Reviewed-on: https://chromium-review.googlesource.com/814218
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: default avatarDoug Steedman <dougsteed@chromium.org>
Reviewed-by: default avatarDaniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522453}
parent 30567e9c
...@@ -93,7 +93,7 @@ class TraceCopyTask : public base::MessagePumpLibevent::Watcher { ...@@ -93,7 +93,7 @@ class TraceCopyTask : public base::MessagePumpLibevent::Watcher {
out_fd_(std::move(out_fd)), out_fd_(std::move(out_fd)),
out_watcher_(FROM_HERE), out_watcher_(FROM_HERE),
callback_(std::move(callback)) {} callback_(std::move(callback)) {}
virtual ~TraceCopyTask() {} ~TraceCopyTask() override {}
void Start() { void Start() {
base::MessageLoopForIO::current()->WatchFileDescriptor( base::MessageLoopForIO::current()->WatchFileDescriptor(
...@@ -178,7 +178,7 @@ class TraceConnection : public base::MessagePumpLibevent::Watcher { ...@@ -178,7 +178,7 @@ class TraceConnection : public base::MessagePumpLibevent::Watcher {
connection_watcher_(FROM_HERE), connection_watcher_(FROM_HERE),
callback_(std::move(callback)), callback_(std::move(callback)),
weak_ptr_factory_(this) {} weak_ptr_factory_(this) {}
virtual ~TraceConnection() {} ~TraceConnection() override {}
void Init() { void Init() {
base::MessageLoopForIO::current()->WatchFileDescriptor( base::MessageLoopForIO::current()->WatchFileDescriptor(
...@@ -336,7 +336,7 @@ class TracingService : public base::MessagePumpLibevent::Watcher { ...@@ -336,7 +336,7 @@ class TracingService : public base::MessagePumpLibevent::Watcher {
public: public:
TracingService() TracingService()
: server_socket_watcher_(FROM_HERE), weak_ptr_factory_(this) {} : server_socket_watcher_(FROM_HERE), weak_ptr_factory_(this) {}
virtual ~TracingService() {} ~TracingService() override {}
bool Init() { bool Init() {
server_socket_ = CreateServerSocket(); server_socket_ = CreateServerSocket();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment