• Alexander Cooper's avatar
    Reland "Revert back to the default GPU when no renderers are using WebXR" · 7c8bfedb
    Alexander Cooper authored
    This reverts commit 4f0531b4.
    
    Reason for revert:Another change was speculatively reverted at the
    same time, when the webgl_conformance_tests began passing again.
    This change does not change behavior except on Windows, so shouldn't
    be the cause of the webgl_conformance_tests failure/passing on 
    chromeos.
    
    Original change's description:
    > Revert "Revert back to the default GPU when no renderers are using WebXR"
    > 
    > This reverts commit 0fb7ef15.
    > 
    > Reason for revert: Speculative revert
    > May have broken webgl_conformance_tests on chromeos-amd64-generic-rel:
    > https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/45665
    > 
    > Original change's description:
    > > Revert back to the default GPU when no renderers are using WebXR
    > > 
    > > The GPU process may have been restarted and initialized on a different
    > > GPU than the default if the VR headset is not plugged into the default
    > > GPU. Staying on this XR compatible GPU can drain battery a lot quicker.
    > > When there are no longer any renderers using WebXR, this change reverts
    > > reverts the GPU process back to the default GPU.
    > > 
    > > Bug: 1090951
    > > Change-Id: Ibc5e7f709d2c82d5a6e8cbda08766d1d654951a3
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321771
    > > Commit-Queue: Patrick To <patrto@microsoft.com>
    > > Reviewed-by: Alexander Cooper <alcooper@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#798950}
    > 
    > TBR=patrto@microsoft.com,alcooper@chromium.org
    > 
    > Change-Id: I14e44c4fe60cdde138ea281b8766ac113887aa99
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1090951
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359663
    > Reviewed-by: Fergus Dall <sidereal@google.com>
    > Commit-Queue: Fergus Dall <sidereal@google.com>
    > Cr-Commit-Position: refs/heads/master@{#798984}
    
    TBR=patrto@microsoft.com,sidereal@google.com,alcooper@chromium.org
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 1090951
    Change-Id: Id5cf2e4c949b2d5b727047bdadb7fe021a535e1e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363288Reviewed-by: default avatarAlexander Cooper <alcooper@chromium.org>
    Reviewed-by: default avatarPatrick To <patrto@microsoft.com>
    Commit-Queue: Alexander Cooper <alcooper@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#799742}
    7c8bfedb
xr_runtime_manager_impl.h 5.02 KB