• Ian Kilpatrick's avatar
    [LayoutNG] Skip positioning list-markers on empty line-boxes. · 7f4b45e6
    Ian Kilpatrick authored
    This fixes floats-do-not-fit-on-line.html which was two bugs combined.
    
    1) List-markers shouldn't be positioned next to empty line boxes
       (unless point 2 occurs). This occurs in particular with floats,
       the list marker should follow the text down (which was the
       primary bug here).
    
    2) List-markers should only be positioned next to empty line boxes if
       we are at the "last" line. I believe this includes forced \n breaks.
       We should produce a line box in these circumstances.
    
    This patch also cleans up the "is empty line" logic inside:
    NGInlineLayoutAlgorithm. Which was previously inconsistent :).
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I9bdc76a5cc40bf8c15651916594c44fd2383097c
    Bug: 636993
    Reviewed-on: https://chromium-review.googlesource.com/1136799Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
    Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575425}
    7f4b45e6
enable-blink-features=LayoutNG 83 KB