• Peter K. Lee's avatar
    Fix compilation of official build with Firebase enabled · 8420c60c
    Peter K. Lee authored
    Official build with Firebase enabled uses variants to specify
    which Info.plist to use as resource for Firebase. This causes
    a conflict as two bundle_data have the same output path.
    
    Move the dependency on ios_firebase_resources_target to the
    definition of the "chrome" target, behind the check for use
    of the variants to prevent this conflict.
    
    Patchset 1 is the original CL http://crrev/c/1250924 by sdefresne
    from which this CL is cloned from.
    
    TBR=sdefresne@chromium.org, justincohen@chromium.org
    
    Bug: 845383
    Change-Id: I0e74f04f27708eb970c61b1048cb2492c45cbba4
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Reviewed-on: https://chromium-review.googlesource.com/1252321
    Commit-Queue: Peter Lee <pkl@chromium.org>
    Reviewed-by: default avatarPeter Lee <pkl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#595187}
    8420c60c
BUILD.gn 1.12 KB