GitLab

Most instances of EXPECT_CALL(...).WillRepeatedly(...) don't actually
set up any expectation, they just set a return value for the mock
function. For this purpose, ON_CALL(...).WillByDefault(...) is more
appropriate, and IMO makes the tests easier to read, since it's clearer
what the actual expectations are.

Bug: none
Change-Id: I8b9da317bc24cd10a8349a75d6864808c3cd9a9d
Reviewed-on: https://chromium-review.googlesource.com/1141730Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576809}