GitLab

This reverts commit ef8dbf91.

Reason for revert: Fixed tests that are still failing/flaky.

Some of the logic around the layout of the PWA window in the original
patch was not as deterministic as it should have been, which caused test
flakiness. This addresses the problem along with several related bugs.

One of the fixes in this CL is to return the final resize of the failing
test back to something equivalent to the logic prior to the original
version of the patch, which was clearly done in a particular way to
handle different layout pathways on different platforms.

Original change's description:
> Revert "Reland "Make PWA titlebar and icons flex and animate properly.""
>
> This reverts commit e490a00a.
>
> Reason for revert: Sheriff here:
> Consistent failure of Linux MSan Tests:
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests
> First failed run:
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/22357
>
> Original change's description:
> > Reland "Make PWA titlebar and icons flex and animate properly."
> >
> > This reverts commit de7cd485.
> >
> > Reason for revert: Fixing issue with Mac tests.
> >
> > Original change's description:
> > > Revert "Make PWA titlebar and icons flex and animate properly."
> > >
> > > This reverts commit 8f2f4243.
> > >
> > > Reason for revert: speculative revert for test failures on Mac
> > > for WebAppFrameToolbarBrowserTest.SpaceConstrained, see e.g.
> > > https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31700
> > >
> > > Original change's description:
> > > > Make PWA titlebar and icons flex and animate properly.
> > > >
> > > > Nested layouts now allocate available space properly to their
> > > > descendents. Also, we consistently use flex layout in the PWA titlebar.
> > > >
> > > > Removed a couple of invalid assumptions that were encoded as DCHECKs.
> > > >
> > > > There are still some inkdrop issues but they are purely cosmetic, see
> > > > crbug.com/1006162 for more detail.
> > > >
> > > > Bug: 1048061
> > > > Change-Id: I403b71b5e2bbcb2d461e1ed6c543c76f91d4c652
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036264
> > > > Commit-Queue: Dana Fried <dfried@chromium.org>
> > > > Reviewed-by: Peter Boström <pbos@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#738874}
> > >
> > > TBR=pbos@chromium.org,dfried@chromium.org
> > >
> > > Change-Id: I731bad118043652a6dbd082c6099ebbd0c697835
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1048061
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041615
> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#738907}
> >
> > TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org
> >
> > Change-Id: Idb9712d1ffe45bf374af846278e26d61983a44f0
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1048061
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042326
> > Reviewed-by: Dana Fried <dfried@chromium.org>
> > Commit-Queue: Dana Fried <dfried@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#742203}
>
> TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org
>
> Change-Id: If65099915ea0efa01de8cc9b0df0a7e9bf03a60b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1048061
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062996
> Reviewed-by: Sergey Poromov <poromov@chromium.org>
> Commit-Queue: Sergey Poromov <poromov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742549}

TBR=pbos@chromium.org,poromov@chromium.org,mastiz@chromium.org,dfried@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1048061, 1050957, 1053899
Change-Id: I5e709a60ae2bd1331bb48687fa9af68d7833b9a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067639Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743824}