• Avery Musbach's avatar
    overview: Simplify RearrangeDuringDrag and its usage · 8fedb2ec
    Avery Musbach authored
    Consistent with UpdateDropTargetBackgroundVisibility,
    RearrangeDuringDrag shall have a dragged item parameter rather than a
    dragged window parameter. OverviewWindowDragController has the item
    which is what RearrangeDuringDrag really needs in the first place,
    meaning it is unnecessary that OverviewWindowDragController gets the
    window from the item and then RearrangeDuringDrag gets back the item
    from the window. Also, when RearrangeDuringDrag calls
    SetBoundsAndUpdatePositions, for dragging from the top or from the
    shelf, ignored_items shall be {} instead of the confusing {nullptr}.
    
    Bug: None
    Change-Id: Ia724128f6dcaf0adc71fa69f4501309e3994c398
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987827Reviewed-by: default avatarSammie Quon <sammiequon@chromium.org>
    Commit-Queue: Avery Musbach <amusbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#728708}
    8fedb2ec
overview_session.h 17.6 KB