• vasilii's avatar
    Revert of mojo: Add deserialization to python structs. (patchset #3 id:40001... · 9db2dffd
    vasilii authored
    Revert of mojo: Add deserialization to python structs. (patchset #3 id:40001 of https://codereview.chromium.org/588493002/)
    
    Reason for revert:
    Linux Tests mojo_python_bindings_tests failure
    http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13712
    
    ======================================================================
    ERROR: testDefaultsTestSerializationDeserialization (bindings_serialization_deserialization_unittest.SerializationDeserializationTest)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/mnt/data/b/build/slave/Linux_Tests/build/src/mojo/python/tests/bindings_serialization_deserialization_unittest.py", line 125, in testDefaultsTestSerializationDeserialization
        v2 = sample_service_mojom.DefaultsTest.Deserialize(data, handles)
      File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/reflection.py", line 113, in Deserialize
        serialization_object.Deserialize(fields, data, handles)
      File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/serialization.py", line 82, in Deserialize
        (_, version) = HEADER_STRUCT.unpack_from(data)
    TypeError: unpack_from() argument 1 must be string or read-only buffer, not bytearray
    
    Original issue's description:
    > mojo: Add deserialization to python structs.
    >
    > This is a reland of https://codereview.chromium.org/578263003 using
    > buffer instead of memoryview, because on some early version of python
    > 2.7, memoryview cannot be used with struct.unpack_from.
    >
    > BUG=415491
    > R=sdefresne@chromium.org,cmasone@chromium.org
    >
    > Committed: https://crrev.com/37dd5f484593b1c8b92b825a9648edf7fb6944e6
    > Cr-Commit-Position: refs/heads/master@{#295684}
    
    TBR=cmasone@chromium.org,sdefresne@chromium.org,qsr@chromium.org
    NOTREECHECKS=true
    NOTRY=true
    BUG=415491
    
    Review URL: https://codereview.chromium.org/584003002
    
    Cr-Commit-Position: refs/heads/master@{#295689}
    9db2dffd
bindings_serialization_deserialization_unittest.py 1.35 KB