• Dana Fried's avatar
    Revert "Layout invalidates when child view's visibility changes. · a078d9ff
    Dana Fried authored
    "
    
    This reverts commit 9932d106.
    
    Reason for revert: Broke a test with insufficient testing (see crbug.com/1021332) - will require additional investigation.
    
    Original change's description:
    > Layout invalidates when child view's visibility changes.
    > 
    > 
    > 
    > Exactly what it says on the tin.
    > 
    > 
    > 
    > This is a fix for legacy layouts (fill, box, grid) which aren't derived
    > 
    > from LayoutManagerBase and which do not benefit from the logic in that
    > 
    > class which handles the invalidation. LayoutManagerBase still overrides
    > 
    > this logic with something more sophisticated.
    > 
    > 
    > 
    > If in the future a legacy layout overrides ViewVisibilitySet(), it
    > 
    > should either call the base implementation or handle the invalidation on
    > 
    > its own.
    > 
    > 
    > 
    > 
    > Bug: 1003500
    > 
    > Change-Id: I9eccef21784175820816852e1b9c05d0713ef2eb
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894260
    > Commit-Queue: Dana Fried <dfried@chromium.org>
    > Reviewed-by: Siyu An <siyua@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#711966}
    
    TBR=siyua@chromium.org,dfried@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1003500
    Change-Id: I9f82556592e9e8db02900620085250e696ab30c6
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899387Reviewed-by: default avatarDana Fried <dfried@chromium.org>
    Commit-Queue: Dana Fried <dfried@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#712497}
    a078d9ff
layout_manager.cc 1.73 KB