- 05 Nov, 2019 40 commits
-
-
Dana Fried authored
" This reverts commit 9932d106. Reason for revert: Broke a test with insufficient testing (see crbug.com/1021332) - will require additional investigation. Original change's description: > Layout invalidates when child view's visibility changes. > > > > Exactly what it says on the tin. > > > > This is a fix for legacy layouts (fill, box, grid) which aren't derived > > from LayoutManagerBase and which do not benefit from the logic in that > > class which handles the invalidation. LayoutManagerBase still overrides > > this logic with something more sophisticated. > > > > If in the future a legacy layout overrides ViewVisibilitySet(), it > > should either call the base implementation or handle the invalidation on > > its own. > > > > > Bug: 1003500 > > Change-Id: I9eccef21784175820816852e1b9c05d0713ef2eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894260 > Commit-Queue: Dana Fried <dfried@chromium.org> > Reviewed-by: Siyu An <siyua@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711966} TBR=siyua@chromium.org,dfried@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1003500 Change-Id: I9f82556592e9e8db02900620085250e696ab30c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899387Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#712497}
-
Eero Häkkinen authored
Request and Response's formData() multipart/form-data parsing uses "UTF-8 decode without BOM" which should not strip BOMs. Spec issue: https://github.com/whatwg/fetch/issues/650 Spec fix: https://github.com/whatwg/fetch/pull/915 WPT fix: https://github.com/web-platform-tests/wpt/pull/17589 Bug: 796192 Change-Id: I24721899006a8c09cf657b3638f1cb17e7953171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796367 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#712496}
-
Joanmarie Diggs authored
Originally landed: crrev.com/c/1749145 Reverted: crrev.com/c/1751830 The revert was due to Trusty not supporting ATK_ROLE_STATIC. The change is something which can wait but should be made eventually. Original commit message: Text leaf nodes and line breaks were being exposed as ATK_ROLE_TEXT. However, the definition of ATK_ROLE_TEXT is: An interactive widget that supports multiple lines of text and optionally accepts user input, but whose purpose is not to solicit user input. In contrast, ATK_ROLE_STATIC is defined as: A generic non-container object whose purpose is to display a brief amount of information to the user and whose role is known by the implementor but lacks semantic value for the user. Thus text leaf nodes and line breaks should be exposed with the latter role; not the former. Bug: 984590 Change-Id: I7da4ea79dcac546a96e55d5ef57c9a052e9bd578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872409 Auto-Submit: Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#712495}
-
Roberto Carrillo authored
This reverts commit 677b08ef. Reason for revert: This seems to be messing with the code coverage builders. Original change's description: > Check for counter overflows when merging profraw files. > > R=sajjadm,liaoyuke > > Bug: 1020404 > Change-Id: I28e27f40aebbc9743da1fa7cc42deb03f77cee13 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894619 > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Roberto Carrillo <robertocn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712266} TBR=robertocn@chromium.org,liaoyuke@chromium.org,sajjadm@chromium.org Change-Id: Ib7e3c45ac146977c13e133be2200433778558741 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899546Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#712494}
-
Jan Wilken Dörrie authored
This is a reland of 83ced150 Original change's description: > [base] Introduce base::CheckedContiguousRange > > This change introduces base::CheckedContiguousRange, which similarly to > base::span is a light-weight wrapper around a contiguous container > performing bound CHECKs. > > However, in contrast to base::span this class keeps a pointer to the > underlying container, and thus is able to respond to changes to data() > and size(), which base::span can't do. > > Furthermore, this change provides a constexpr overload of base::data() > for std::array and fixes a bug in CheckedContiguousIterator::operator-=. > > Bug: 990059 > > Change-Id: I3fef91c7ef7874bf495ac2ab6dbaf3a8b02dab35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893858 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712120} Bug: 990059 Change-Id: If7cfd16ca526930643e9fac7567f58ba9ef60b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893069Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#712493}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/167e7ad444..2cf0518ef4 TBR=bmeurer@chromium.org Change-Id: Id494978d845223c4ff796e15f8819f53bea25d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898650Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712492}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/67527cb45293..df415528411f git log 67527cb45293..df415528411f --date=short --no-merges --format='%ad %ae %s' 2019-11-05 sunny.sun@arm.com Vulkan: Enable VK_IMAGE_USAGE_STORAGE_BIT when it is needed Created with: gclient setdep -r src/third_party/angle@df415528411f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I2456863799c8973de10966ceaeb10fdb85feaad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712491}
-
Mikel Astiz authored
There are multiple datatypes that are platform-dependent and nevertheless the types and enum values are compiled (no ifdef). This patch does the same for READING_LIST which is no different. Bug: 950874 Change-Id: I5598d1e7b221c1f4a1338bb83397066c2b79be60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893198 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#712490}
-
dpapad authored
README.js is clearly not holding JS contents, and is causing ESLint errors. This is in preparation of turning on ESLint PRESUBMIT checks for src/components. Bug: 1019312 Change-Id: Id32353b0f1e4bcd1cc62bd3983739c16fe0d24bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898868 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Yuzu Saijo authored
This CL removes the check to make sure rfh exists when ServiceWorkerProviderHost::OnBeginNavigationCommit is called. For tests this function is called with a fake frame, and this was causing ServiceWorker tests to fail. Bug: 1020884 Change-Id: I5d750e50ca19409cf94867b5e07a7ce35eaa33d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898165 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712488}
-
Dominic Farolino authored
This CL moves logic from NetworkServiceNetworkDelegate that performs a DumpWithoutCrash() on incorrect referrer detection, to where serialization of a network::ResourceRequest is performed before being passed to the network service. This is a temporary migration to aid in debugging long-standing referrer mismatches (crbug.com/912680) as well as recently-introduced referrer mismatches (crbug.com/1020592). Bug: 912680,1020592 Change-Id: Id6d7db1c7105bd86f125004868a49beea8c2c3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896251Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#712487}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9eccfe81. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Idd3c89fe559b3991fb1288ed5475a0757a5276ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898180Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712486}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f35966470fb..835991798ff9 Created with: gclient setdep -r src-internal@835991798ff9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0963bf0ec1df35b86efb094bf3c8ec00dc5a5e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899066Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712485}
-
Chih-Yu Huang authored
Bug: none Test: none Change-Id: I1aa70508f9e6a131dc39cf67827bf691558a6882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899235Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712484}
-
Keiichi Watanabe authored
Added a new rule to allow the user 'crosvm' to use libvda D-Bus service because crosvm is run as 'crosvm' when it's started by vm_concierge. Bug: b:142864350 Test: Play a video on VM with virtio-vdec Signed-off-by:
Keiichi Watanabe <keiichiw@chromium.org> Change-Id: I35562356b9a475fc3f72ec7de743cfe636b4a6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883451Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#712483}
-
Takashi Toyoshima authored
Please see the comments in the file before removing. NOTRY=true Bug: 1019501, 1001450 Change-Id: I99beba1bc7d3bacd25208ce1e8d5ab8356808e43 TBR: wangxianzhu@chromium.org, yhirano@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899237Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#712482}
-
Eric Roman authored
Bug: 1021236 Change-Id: I96599537914475508a3404b4771aeab9fa117a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896341 Auto-Submit: Eric Roman <eroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
To avoid inefficient AtomicString concatting when the header value has multiple commas. Bug: 930150 Change-Id: I33439d188be20d130278a961ec6ad82d2ba7fa7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893608Reviewed-by:
-
Dana Fried authored
We now use an overlay with opacity to show the hover card transition between adjacent tabs as the hover card slide-animates between them. This is done with a second title and domain label that starts out displaying the old title and domain (obscuring the title and domain labels displaying the new values) and fades away as the hover card animates. We also looked at using layer opacity but the results were less attractive. Change-Id: I5098838596ea1e674cdeb884520ac7ea3a328623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895945 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#712479}
-
Michael Lippautz authored
In the strongification case the callbacks should return false indicating that the key is alive and value should be traced. Bug: 1019191 Change-Id: I508dcb6fa90d91417788302aef1f448a8fc9a744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897928Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712478}
-
Koji Ishii authored
Following bot results are included. 178 179 180 A large number of new failures are probably due to r712444 crrev.com/c/1869076 . TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: If425fdfa62d25435f08f891742626d79ecb61c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898146Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#712477}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::DisplayPrivate using AssociatedRemote, PendingAssociatedReceiver, and AssociatedReceiver. Bug: 955171 Change-Id: Ia8191e6f88b11db9d61481caafcca18e61037976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894664 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#712476}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Iedb529071d050b6eaddf76d0b4d7841c788b2f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898900Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#712475}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I7f1cea25c7c66cb13a0ef9e4b56bb2a81f6d7869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898899Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d3f9d9a2..1dfdd03d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I306595250f8868ae0f9c63b17aa406b1793f4cff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898179Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712473}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=fukino@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I58d10f42096525ceb432d30ab59e74cdfa11d290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894889 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#712472}
-
Francois Beaufort authored
This CL adds a permission for Web NFC. The permission will be denied when the feature is disabled, which is true by default while we're implementing it. Spec: https://w3c.github.io/permissions/#nfc Bug: 520391 Change-Id: Ic8785dc9bf3e2adf0813652b056e29cc7f41c1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888655 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#712471}
-
Jinsuk Kim authored
The refactoring https://crrev.com/c/1861442 caused a regression in memory when loading a (blank) page. A side effect of the refactoring was introduced at didFinishNavigation event. Previously |showRenderedPage| earlied out if |mNativePage| is null, but after the change it triggered |notifyContentChanged|. This CL fixes it. Bug: 1019369 Change-Id: Ia4c663781f8d3c51a2f3157227b81b8ce213cfc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898156Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#712470}
-
Fergal Daly authored
These tests were parameterized and the .* does not cross the / boundary, so the filters didn't filter the tests. TBR=yuzus@chromium.org Bug: 1020884 Change-Id: I653b1ef797e0d77ae722080e2e0a33d6fbcfea3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898904Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#712469}
-
Takashi Sakamoto authored
WebKit Mac10.13 (retina) virtual/audio-service/media/video-controls-rendering.html Mac10.11 media/controls/video-overlay-cast-dark-rendering.html virtual/audio-service/media/controls/video-overlay-cast-dark-rendering.html Bug: 1021407 Change-Id: I73769f1ca62f570ecc7ef8fd629ab1ef5977950d Tbr: andypaicu@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898903Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#712468}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c898ec1a5e2f..67527cb45293 git log c898ec1a5e2f..67527cb45293 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 mrlachatte@gmail.com Fix compilation on UWP targets. Created with: gclient setdep -r src/third_party/angle@67527cb45293 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I76bb92cc0a372d9805ac995c3e5f7d8a3d345033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899166Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium eeb9d035. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ideb96a747000dc0cb5bdd2ef98fded6e08aeaf7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898178Reviewed-by:
-
Fergal Daly authored
Filter NavigationControllerBrowserTest.BrowserInitiatedLoadPostCommitErrorPageIgnoredForFramePendingDeletion on bfcache try bots. TBR=nasko@chromium.org Bug: 1021409 Change-Id: I251549fc413e8a12ef39f17933c06122f799c7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898901Reviewed-by:
-
Yuki Shiino authored
Improves ease-of-use of IdlType.unwrap. idl_type.unwrap() # Unwrap both of typedef and nullable idl_type.unwrap(typedef=True) # Unwrap only typedef This style works better when we'll add the third 'unwrappable'. Bug: 839389 Change-Id: I2b6a9a81a57dac8228eba32c676c9a21c00284a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896479 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Rolling this tool just to keep it up-to-date. Also want to try out new flag in a follow-up: --generate_base_classes_for_default_methods Change-Id: Ia357a27b9ed8064a4adb8abc00ce0c4c601972a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882306 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712463}
-
Lijin Shen authored
Moved some semantic names in color_palette.xml to semantic_colors.xml. And added some presubmit checks to prevent from adding more hex argb values in color resource files except color_palette.xml. Bug: 775198 Change-Id: Ie27dd8dc0e4fa6506ed192c6f5f9c4b5b5f88566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896241 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#712462}
-
Xianzhu Wang authored
Now we can use the names defined in web_tests/FlagSpecificConfig as the flag-specific test expectations files and baseline directories. Renamed: enable-blink-features=BackForwardCache -> back-forward-cache enable-blilk-features=CompositeAfterPaint -> composite-after-paint disable-blink-features=LayoutNG -> disable-layout-ng enable-blink-features=LayoutNGFragmentItem -> layout-ng-fragment-item enable-blink-features=NewSystemColors -> new-system-colors Removed: disable-blink-features=MediaCastOverlayButton enable-blink-features=HeapIncrementalMarkingStress disable-features=NetworkService enable-features=NetworkService enable-features=OutOfBlinkCors disable-perfetto enable-blink-features=HeapUnifiedGarbageCollection enable-features=OverflowIconsForMediaControls Unchanged: disable-site-isolation-trials: short enough enable-gpu-rasterization, use-gl=*, use-vulkan=*, enable-features-UseSkiaRenderer: need more follow-up for gpu rasterization configurations for different renderers. Bug: 1019501 Change-Id: I73aa8996a61d67c5852fd74cec7289c2491c4250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895928Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712461}
-
Yuki Shiino authored
PathManager provides paths to Blink headers and output files. Also supports cross-components output. Bug: 839389 Change-Id: If9514f421ac8dd2d54c68cd9048a5ad5d1eb0536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897577 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Make LooseFormatter support implicit ({}) and explicit ({0}, {1}, ...) positional argument specifiers. Bug: 839389 Change-Id: I8a820cba90a2be580e63c15d35c194c4ba31c702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897575 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: -
Xianzhu Wang authored
It didn't work by itself. It was just a redundant information of whether the scrollbar theme supports solid color scrollbars. Change-Id: I32c61c8337bb8546a05841723833905463e71457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896675Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712458}
-
